From nobody Thu May 15 19:21:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 150358015849036.46613240355816; Thu, 24 Aug 2017 06:09:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DE687EAA1; Thu, 24 Aug 2017 13:09:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0257B7B8DE; Thu, 24 Aug 2017 13:09:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 348CC3FC73; Thu, 24 Aug 2017 13:09:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v7OD9Cc7027786 for ; Thu, 24 Aug 2017 09:09:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id C38A27B8D4; Thu, 24 Aug 2017 13:09:12 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-123-165.rdu2.redhat.com [10.10.123.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91F5D7B9C9 for ; Thu, 24 Aug 2017 13:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5DE687EAA1 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: John Ferlan To: libvir-list@redhat.com Date: Thu, 24 Aug 2017 09:08:56 -0400 Message-Id: <20170824130905.5199-4-jferlan@redhat.com> In-Reply-To: <20170824130905.5199-1-jferlan@redhat.com> References: <20170824130905.5199-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 03/12] storage: Fill in storage pool @active properly X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 24 Aug 2017 13:09:17 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" It's a bool not an int, so use true/false and not 1/0 Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 4 ++-- src/test/test_driver.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index eb7664c..a9fa190 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -52,7 +52,7 @@ virStoragePoolObjNew(void) return NULL; } virStoragePoolObjLock(obj); - obj->active =3D 0; + obj->active =3D false; return obj; } =20 @@ -544,7 +544,7 @@ virStoragePoolObjLoadState(virStoragePoolObjListPtr poo= ls, * as active */ =20 - obj->active =3D 1; + obj->active =3D true; =20 cleanup: VIR_FREE(stateFile); diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aa38f54..989c3a8 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1130,7 +1130,7 @@ testParseStorage(testDriverPtr privconn, virStoragePoolObjUnlock(obj); goto error; } - obj->active =3D 1; + obj->active =3D true; =20 /* Find storage volumes */ if (testOpenVolumesForPool(file, ctxt, obj, i+1) < 0) { @@ -4322,7 +4322,7 @@ testStoragePoolCreate(virStoragePoolPtr pool, if (!(obj =3D testStoragePoolObjFindInactiveByName(privconn, pool->nam= e))) return -1; =20 - obj->active =3D 1; + obj->active =3D true; =20 event =3D virStoragePoolEventLifecycleNew(pool->name, pool->uuid, VIR_STORAGE_POOL_EVENT_STARTED, @@ -4470,7 +4470,7 @@ testStoragePoolCreateXML(virConnectPtr conn, * code will not Remove the pool */ VIR_FREE(obj->configFile); =20 - obj->active =3D 1; + obj->active =3D true; =20 event =3D virStoragePoolEventLifecycleNew(obj->def->name, obj->def->uu= id, VIR_STORAGE_POOL_EVENT_STARTED, @@ -4618,7 +4618,7 @@ testStoragePoolDestroy(virStoragePoolPtr pool) if (!(obj =3D testStoragePoolObjFindActiveByName(privconn, pool->name)= )) return -1; =20 - obj->active =3D 0; + obj->active =3D false; =20 if (obj->def->source.adapter.type =3D=3D VIR_STORAGE_ADAPTER_TYPE_FC_HOST) { --=20 2.9.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list