maint: correct quoting for gl_WARN_ADD

[libvirt] [PATCH] maint: correct quoting for gl_WARN_ADD

Posted by Eric Blake 7 years, 8 months ago

3 out of 4 uses of gl_WARN_ADD() were incorrectly adding "" around
the argument, which in turn resulted in the argument being used
unquoted (configure had gl_positive=""-fstack-protector-all"",
rather than the intended gl_positive="-fstack-protector-all").

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 m4/virt-compile-warnings.m4 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
index 7b56115ce6..e8f1351260 100644
--- a/m4/virt-compile-warnings.m4
+++ b/m4/virt-compile-warnings.m4
@@ -194,8 +194,8 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
     # This should be < 256 really. Currently we're down to 4096,
     # but using 1024 bytes sized buffers (mostly for virStrerror)
     # stops us from going down further
-    gl_WARN_ADD(["-Wframe-larger-than=4096"], [STRICT_FRAME_LIMIT_CFLAGS])
-    gl_WARN_ADD(["-Wframe-larger-than=25600"], [RELAXED_FRAME_LIMIT_CFLAGS])
+    gl_WARN_ADD([-Wframe-larger-than=4096], [STRICT_FRAME_LIMIT_CFLAGS])
+    gl_WARN_ADD([-Wframe-larger-than=25600], [RELAXED_FRAME_LIMIT_CFLAGS])

     # Extra special flags
     dnl -fstack-protector stuff passes gl_WARN_ADD with gcc
@@ -250,7 +250,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
         *-fstack-protector-strong*)
         ;;
         *)
-            gl_WARN_ADD(["-fstack-protector-all"])
+            gl_WARN_ADD([-fstack-protector-all])
         ;;
         esac
         ;;
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: correct quoting for gl_WARN_ADD

Posted by Andrea Bolognani 7 years, 8 months ago

On Thu, 2017-08-24 at 16:13 -0500, Eric Blake wrote:
> 3 out of 4 uses of gl_WARN_ADD() were incorrectly adding "" around
> the argument, which in turn resulted in the argument being used
> unquoted (configure had gl_positive=""-fstack-protector-all"",
> rather than the intended gl_positive="-fstack-protector-all").
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  m4/virt-compile-warnings.m4 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] maint: correct quoting for gl_WARN_ADD

Posted by Eric Blake 7 years, 8 months ago

On 08/28/2017 04:05 AM, Andrea Bolognani wrote:
> On Thu, 2017-08-24 at 16:13 -0500, Eric Blake wrote:
>> 3 out of 4 uses of gl_WARN_ADD() were incorrectly adding "" around
>> the argument, which in turn resulted in the argument being used
>> unquoted (configure had gl_positive=""-fstack-protector-all"",
>> rather than the intended gl_positive="-fstack-protector-all").
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>  m4/virt-compile-warnings.m4 | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Thanks; pushed.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list