1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] apparmor: cater for new AAVMF image location

Guido Günther posted 1 patch 8 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170915161015.utmgz22qhvzi66o5@bogon.m.sigxcpu.org
src/security/virt-aa-helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[libvirt] [PATCH] apparmor: cater for new AAVMF image location
Posted by Guido Günther 8 years, 1 month ago 
Things moved again, sigh.
---
 src/security/virt-aa-helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 55a686a59c..0b43c8e391 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -516,7 +516,8 @@ valid_path(const char *path, const bool readonly)
         "/usr/share/OVMF/",              /* for OVMF images */
         "/usr/share/ovmf/",              /* for OVMF images */
         "/usr/share/AAVMF/",             /* for AAVMF images */
-        "/usr/share/qemu-efi/"           /* for AAVMF images */
+        "/usr/share/qemu-efi/",          /* for AAVMF images */
+        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
     };
     /* override the above with these */
     const char * const override[] = {
-- 
2.14.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location
Posted by Jamie Strandboge 8 years, 1 month ago 
On Fri, 2017-09-15 at 18:10 +0200, Guido Günther wrote:
> Things moved again, sigh.
> ---
>  src/security/virt-aa-helper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index 55a686a59c..0b43c8e391 100644
> --- a/src/security/virt-aa-helper.c
> +++ b/src/security/virt-aa-helper.c
> @@ -516,7 +516,8 @@ valid_path(const char *path, const bool readonly)
>          "/usr/share/OVMF/",              /* for OVMF images */
>          "/usr/share/ovmf/",              /* for OVMF images */
>          "/usr/share/AAVMF/",             /* for AAVMF images */
> -        "/usr/share/qemu-efi/"           /* for AAVMF images */
> +        "/usr/share/qemu-efi/",          /* for AAVMF images */
> +        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
>      };
>      /* override the above with these */
>      const char * const override[] = {

+1. LGTM

-- 
Jamie Strandboge             | http://www.canonical.com--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location
Posted by intrigeri 8 years, 1 month ago 
Jamie Strandboge:
> On Fri, 2017-09-15 at 18:10 +0200, Guido Günther wrote:
>> Things moved again, sigh.
>> ---
>>  src/security/virt-aa-helper.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
>> index 55a686a59c..0b43c8e391 100644
>> --- a/src/security/virt-aa-helper.c
>> +++ b/src/security/virt-aa-helper.c
>> @@ -516,7 +516,8 @@ valid_path(const char *path, const bool readonly)
>>          "/usr/share/OVMF/",              /* for OVMF images */
>>          "/usr/share/ovmf/",              /* for OVMF images */
>>          "/usr/share/AAVMF/",             /* for AAVMF images */
>> -        "/usr/share/qemu-efi/"           /* for AAVMF images */
>> +        "/usr/share/qemu-efi/",          /* for AAVMF images */
>> +        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
>>      };
>>      /* override the above with these */
>>      const char * const override[] = {

> +1. LGTM

+1 too after verifying that qemu-efi-aarch64 on current Debian sid
indeed ships QEMU_EFI.fd in there..

Cheers,
-- 
intrigeri

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location
Posted by Michal Privoznik 8 years, 1 month ago 
On 09/15/2017 06:10 PM, Guido Günther wrote:
> Things moved again, sigh.
> ---
>  src/security/virt-aa-helper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index 55a686a59c..0b43c8e391 100644
> --- a/src/security/virt-aa-helper.c
> +++ b/src/security/virt-aa-helper.c
> @@ -516,7 +516,8 @@ valid_path(const char *path, const bool readonly)
>          "/usr/share/OVMF/",              /* for OVMF images */
>          "/usr/share/ovmf/",              /* for OVMF images */
>          "/usr/share/AAVMF/",             /* for AAVMF images */
> -        "/usr/share/qemu-efi/"           /* for AAVMF images */
> +        "/usr/share/qemu-efi/",          /* for AAVMF images */
> +        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
>      };
>      /* override the above with these */
>      const char * const override[] = {
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location
Posted by Guido Günther 8 years, 1 month ago 
Hi,
On Mon, Sep 18, 2017 at 02:05:41PM +0200, Michal Privoznik wrote:
> On 09/15/2017 06:10 PM, Guido Günther wrote:
> > Things moved again, sigh.
> > ---
> >  src/security/virt-aa-helper.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> > index 55a686a59c..0b43c8e391 100644
> > --- a/src/security/virt-aa-helper.c
> > +++ b/src/security/virt-aa-helper.c
> > @@ -516,7 +516,8 @@ valid_path(const char *path, const bool readonly)
> >          "/usr/share/OVMF/",              /* for OVMF images */
> >          "/usr/share/ovmf/",              /* for OVMF images */
> >          "/usr/share/AAVMF/",             /* for AAVMF images */
> > -        "/usr/share/qemu-efi/"           /* for AAVMF images */
> > +        "/usr/share/qemu-efi/",          /* for AAVMF images */
> > +        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
> >      };
> >      /* override the above with these */
> >      const char * const override[] = {
> > 
> 
> ACK

Pushed. Thanks
 -- Guido

> 
> Michal
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.