Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #2)

[libvirt] [PATCH REPOST 0/6] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #2)

Posted by John Ferlan 7 years, 7 months ago

Since the original series (19 patches):

https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html

didn't garner any attention, I'm going with smaller patch piles to make
forward progress.

This series is the first half of the storage backend changes to use
the virStoragePoolObjGetDef accessor.

The next/last series will be the next half, plus the change to move
virStoragePoolObj and virStorageVolDefList into virstoragepoolobj.c.

After that adjustments to virstoragepoolobj similar to other drivers
and perhaps even generating a virStorageVolObjPtr - e.g. a hash table
of volume defs rather than a linked list of defs.

John Ferlan (6):
  storage: Use virStoragePoolObjGetDef accessor for storage_util
  storage: Use virStoragePoolObjGetDef accessor for Disk backend
  storage: Use virStoragePoolObjGetDef accessor for Logical backend
  storage: Use virStoragePoolObjGetDef accessor for Sheepdog backend
  storage: Use virStoragePoolObjGetDef accessor for FS backend
  storage: Use virStoragePoolObjGetDef accessor for Gluster backend

 src/storage/storage_backend_disk.c     |  98 ++++++++++++++++------------
 src/storage/storage_backend_fs.c       |  90 +++++++++++++------------
 src/storage/storage_backend_gluster.c  |  20 +++---
 src/storage/storage_backend_logical.c  |  63 ++++++++++--------
 src/storage/storage_backend_sheepdog.c |  23 ++++---
 src/storage/storage_util.c             | 116 ++++++++++++++++++---------------
 6 files changed, 230 insertions(+), 180 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH REPOST 0/6] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #2)

Posted by Michal Privoznik 7 years, 7 months ago

On 10/06/2017 01:23 PM, John Ferlan wrote:
> Since the original series (19 patches):
> 
> https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html
> 
> didn't garner any attention, I'm going with smaller patch piles to make
> forward progress.
> 
> This series is the first half of the storage backend changes to use
> the virStoragePoolObjGetDef accessor.
> 
> The next/last series will be the next half, plus the change to move
> virStoragePoolObj and virStorageVolDefList into virstoragepoolobj.c.
> 
> After that adjustments to virstoragepoolobj similar to other drivers
> and perhaps even generating a virStorageVolObjPtr - e.g. a hash table
> of volume defs rather than a linked list of defs.
> 
> John Ferlan (6):
>   storage: Use virStoragePoolObjGetDef accessor for storage_util
>   storage: Use virStoragePoolObjGetDef accessor for Disk backend
>   storage: Use virStoragePoolObjGetDef accessor for Logical backend
>   storage: Use virStoragePoolObjGetDef accessor for Sheepdog backend
>   storage: Use virStoragePoolObjGetDef accessor for FS backend
>   storage: Use virStoragePoolObjGetDef accessor for Gluster backend
> 
>  src/storage/storage_backend_disk.c     |  98 ++++++++++++++++------------
>  src/storage/storage_backend_fs.c       |  90 +++++++++++++------------
>  src/storage/storage_backend_gluster.c  |  20 +++---
>  src/storage/storage_backend_logical.c  |  63 ++++++++++--------
>  src/storage/storage_backend_sheepdog.c |  23 ++++---
>  src/storage/storage_util.c             | 116 ++++++++++++++++++---------------
>  6 files changed, 230 insertions(+), 180 deletions(-)
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list