[libvirt] [PATCH REPOST 0/8] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #3)

John Ferlan posted 8 patches 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171006144302.9892-1-jferlan@redhat.com
src/conf/storage_conf.h                |  4 ---
src/conf/virstorageobj.c               | 20 +++++++++++
src/conf/virstorageobj.h               | 15 --------
src/storage/storage_backend_iscsi.c    | 41 ++++++++++++----------
src/storage/storage_backend_mpath.c    |  8 +++--
src/storage/storage_backend_rbd.c      | 64 ++++++++++++++++++----------------
src/storage/storage_backend_scsi.c     | 30 +++++++++-------
src/storage/storage_backend_vstorage.c | 31 ++++++++--------
src/storage/storage_backend_zfs.c      | 39 ++++++++++++---------
src/storage/storage_driver.c           |  8 ++---
10 files changed, 144 insertions(+), 116 deletions(-)
[libvirt] [PATCH REPOST 0/8] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #3)
Posted by John Ferlan 7 years, 7 months ago
Since the original series (19 patches):

https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html

didn't garner any attention, I'm going with smaller patch piles to make
forward progress.

This is the last half of the storage backends plus one missed merge
(because I broke things up <sigh>)

John Ferlan (8):
  storage: Use virStoragePoolObjGetDef accessor for iSCSI backend
  storage: Use virStoragePoolObjGetDef accessor for MPATH backend
  storage: Use virStoragePoolObjGetDef accessor for RBD backend
  storage: Use virStoragePoolObjGetDef accessor for SCSI backend
  storage: Use virStoragePoolObjGetDef accessor for VSTORAGE backend
  storage: Use virStoragePoolObjGetDef accessor for ZFS backend
  storage: Use virStoragePoolObjGetDef accessor for new driver events
  storage: Privatize virStoragePoolObj and virStorageVolDefList

 src/conf/storage_conf.h                |  4 ---
 src/conf/virstorageobj.c               | 20 +++++++++++
 src/conf/virstorageobj.h               | 15 --------
 src/storage/storage_backend_iscsi.c    | 41 ++++++++++++----------
 src/storage/storage_backend_mpath.c    |  8 +++--
 src/storage/storage_backend_rbd.c      | 64 ++++++++++++++++++----------------
 src/storage/storage_backend_scsi.c     | 30 +++++++++-------
 src/storage/storage_backend_vstorage.c | 31 ++++++++--------
 src/storage/storage_backend_zfs.c      | 39 ++++++++++++---------
 src/storage/storage_driver.c           |  8 ++---
 10 files changed, 144 insertions(+), 116 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH REPOST 0/8] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #3)
Posted by John Ferlan 7 years, 6 months ago
ping?

Tks -

John

On 10/06/2017 10:42 AM, John Ferlan wrote:
> Since the original series (19 patches):
> 
> https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html
> 
> didn't garner any attention, I'm going with smaller patch piles to make
> forward progress.
> 
> This is the last half of the storage backends plus one missed merge
> (because I broke things up <sigh>)
> 
> John Ferlan (8):
>   storage: Use virStoragePoolObjGetDef accessor for iSCSI backend
>   storage: Use virStoragePoolObjGetDef accessor for MPATH backend
>   storage: Use virStoragePoolObjGetDef accessor for RBD backend
>   storage: Use virStoragePoolObjGetDef accessor for SCSI backend
>   storage: Use virStoragePoolObjGetDef accessor for VSTORAGE backend
>   storage: Use virStoragePoolObjGetDef accessor for ZFS backend
>   storage: Use virStoragePoolObjGetDef accessor for new driver events
>   storage: Privatize virStoragePoolObj and virStorageVolDefList
> 
>  src/conf/storage_conf.h                |  4 ---
>  src/conf/virstorageobj.c               | 20 +++++++++++
>  src/conf/virstorageobj.h               | 15 --------
>  src/storage/storage_backend_iscsi.c    | 41 ++++++++++++----------
>  src/storage/storage_backend_mpath.c    |  8 +++--
>  src/storage/storage_backend_rbd.c      | 64 ++++++++++++++++++----------------
>  src/storage/storage_backend_scsi.c     | 30 +++++++++-------
>  src/storage/storage_backend_vstorage.c | 31 ++++++++--------
>  src/storage/storage_backend_zfs.c      | 39 ++++++++++++---------
>  src/storage/storage_driver.c           |  8 ++---
>  10 files changed, 144 insertions(+), 116 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH REPOST 0/8] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #3)
Posted by John Ferlan 7 years, 6 months ago
ping^2,

TKs,

John

On 10/19/2017 11:02 AM, John Ferlan wrote:
> 
> ping?
> 
> Tks -
> 
> John
> 
> On 10/06/2017 10:42 AM, John Ferlan wrote:
>> Since the original series (19 patches):
>>
>> https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html
>>
>> didn't garner any attention, I'm going with smaller patch piles to make
>> forward progress.
>>
>> This is the last half of the storage backends plus one missed merge
>> (because I broke things up <sigh>)
>>
>> John Ferlan (8):
>>   storage: Use virStoragePoolObjGetDef accessor for iSCSI backend
>>   storage: Use virStoragePoolObjGetDef accessor for MPATH backend
>>   storage: Use virStoragePoolObjGetDef accessor for RBD backend
>>   storage: Use virStoragePoolObjGetDef accessor for SCSI backend
>>   storage: Use virStoragePoolObjGetDef accessor for VSTORAGE backend
>>   storage: Use virStoragePoolObjGetDef accessor for ZFS backend
>>   storage: Use virStoragePoolObjGetDef accessor for new driver events
>>   storage: Privatize virStoragePoolObj and virStorageVolDefList
>>
>>  src/conf/storage_conf.h                |  4 ---
>>  src/conf/virstorageobj.c               | 20 +++++++++++
>>  src/conf/virstorageobj.h               | 15 --------
>>  src/storage/storage_backend_iscsi.c    | 41 ++++++++++++----------
>>  src/storage/storage_backend_mpath.c    |  8 +++--
>>  src/storage/storage_backend_rbd.c      | 64 ++++++++++++++++++----------------
>>  src/storage/storage_backend_scsi.c     | 30 +++++++++-------
>>  src/storage/storage_backend_vstorage.c | 31 ++++++++--------
>>  src/storage/storage_backend_zfs.c      | 39 ++++++++++++---------
>>  src/storage/storage_driver.c           |  8 ++---
>>  10 files changed, 144 insertions(+), 116 deletions(-)
>>
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH REPOST 0/8] Privatize _virStoragePoolObj and _virStorageVolDefList (Batch #3)
Posted by Erik Skultety 7 years, 6 months ago
On Fri, Oct 06, 2017 at 10:42:54AM -0400, John Ferlan wrote:
> Since the original series (19 patches):
>
> https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html
>
> didn't garner any attention, I'm going with smaller patch piles to make
> forward progress.
>
> This is the last half of the storage backends plus one missed merge
> (because I broke things up <sigh>)
>
> John Ferlan (8):
>   storage: Use virStoragePoolObjGetDef accessor for iSCSI backend
>   storage: Use virStoragePoolObjGetDef accessor for MPATH backend
>   storage: Use virStoragePoolObjGetDef accessor for RBD backend
>   storage: Use virStoragePoolObjGetDef accessor for SCSI backend
>   storage: Use virStoragePoolObjGetDef accessor for VSTORAGE backend
>   storage: Use virStoragePoolObjGetDef accessor for ZFS backend
>   storage: Use virStoragePoolObjGetDef accessor for new driver events
>   storage: Privatize virStoragePoolObj and virStorageVolDefList
>
>  src/conf/storage_conf.h                |  4 ---
>  src/conf/virstorageobj.c               | 20 +++++++++++
>  src/conf/virstorageobj.h               | 15 --------
>  src/storage/storage_backend_iscsi.c    | 41 ++++++++++++----------
>  src/storage/storage_backend_mpath.c    |  8 +++--
>  src/storage/storage_backend_rbd.c      | 64 ++++++++++++++++++----------------
>  src/storage/storage_backend_scsi.c     | 30 +++++++++-------
>  src/storage/storage_backend_vstorage.c | 31 ++++++++--------
>  src/storage/storage_backend_zfs.c      | 39 ++++++++++++---------
>  src/storage/storage_driver.c           |  8 ++---
>  10 files changed, 144 insertions(+), 116 deletions(-)

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list