From nobody Thu May 15 11:31:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1507644856917981.6527078723993; Tue, 10 Oct 2017 07:14:16 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1411E5F2974; Tue, 10 Oct 2017 14:14:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB08F6C412; Tue, 10 Oct 2017 14:14:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 84E2A410B3; Tue, 10 Oct 2017 14:14:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9ADsYFA015298 for ; Tue, 10 Oct 2017 09:54:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 659CB18ABA; Tue, 10 Oct 2017 13:54:34 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-36.phx2.redhat.com [10.3.116.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E8E96C407 for ; Tue, 10 Oct 2017 13:54:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1411E5F2974 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: John Ferlan To: libvir-list@redhat.com Date: Tue, 10 Oct 2017 09:54:27 -0400 Message-Id: <20171010135428.23097-3-jferlan@redhat.com> In-Reply-To: <20171010135428.23097-1-jferlan@redhat.com> References: <20171010135428.23097-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] nodedev: Convert virNodeDeviceObjHasCap to bool X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 10 Oct 2017 14:14:15 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" It only returns 0 or 1 anyway, let's be realistic Signed-off-by: John Ferlan Reviewed-by: Erik Skultety --- src/conf/virnodedeviceobj.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index 49f4f436b8..7db8fccbc3 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c @@ -120,7 +120,7 @@ virNodeDeviceObjGetDef(virNodeDeviceObjPtr obj) } =20 =20 -static int +static bool virNodeDeviceObjHasCap(const virNodeDeviceObj *obj, const char *cap) { @@ -134,13 +134,13 @@ virNodeDeviceObjHasCap(const virNodeDeviceObj *obj, =20 while (caps) { if (STREQ(cap, virNodeDevCapTypeToString(caps->data.type))) { - return 1; + return true; } else { switch (caps->data.type) { case VIR_NODE_DEV_CAP_PCI_DEV: if ((STREQ(cap, mdev_types)) && (caps->data.pci_dev.flags & VIR_NODE_DEV_CAP_FLAG_PCI_= MDEV)) - return 1; + return true; break; =20 case VIR_NODE_DEV_CAP_SCSI_HOST: @@ -148,7 +148,7 @@ virNodeDeviceObjHasCap(const virNodeDeviceObj *obj, (caps->data.scsi_host.flags & VIR_NODE_DEV_CAP_FLAG_HB= A_FC_HOST)) || (STREQ(cap, vports_cap) && (caps->data.scsi_host.flags & VIR_NODE_DEV_CAP_FLAG_HB= A_VPORT_OPS))) - return 1; + return true; break; =20 case VIR_NODE_DEV_CAP_SYSTEM: @@ -172,7 +172,7 @@ virNodeDeviceObjHasCap(const virNodeDeviceObj *obj, =20 caps =3D caps->next; } - return 0; + return false; } =20 =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list