From nobody Wed Jul 9 23:43:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1507674229685231.0551907474803; Tue, 10 Oct 2017 15:23:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3799E7EA99; Tue, 10 Oct 2017 22:23:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E98C868886; Tue, 10 Oct 2017 22:23:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 023F24EE50; Tue, 10 Oct 2017 22:23:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9ALq9gb021598 for ; Tue, 10 Oct 2017 17:52:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id EFB3251893; Tue, 10 Oct 2017 21:52:09 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB03D68881 for ; Tue, 10 Oct 2017 21:52:06 +0000 (UTC) Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com [209.85.216.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 11BDE7F755 for ; Tue, 10 Oct 2017 21:52:06 +0000 (UTC) Received: by mail-qt0-f182.google.com with SMTP id z19so10279323qtg.11 for ; Tue, 10 Oct 2017 14:52:06 -0700 (PDT) Received: from dawid-fedora.datto.lan ([47.19.105.250]) by smtp.gmail.com with ESMTPSA id 4sm6879379qke.50.2017.10.10.14.52.04 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 14:52:04 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3799E7EA99 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3799E7EA99 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=datto-com.20150623.gappssmtp.com header.i=@datto-com.20150623.gappssmtp.com header.b="Xq0KQGr9" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 11BDE7F755 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dzamirski@datto.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 11BDE7F755 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datto-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=bYuUt9kCBp/m+s+HjaTAcZUJOKBbVnbkiR1E8l0dQIs=; b=Xq0KQGr962HMSKgqD0k+3ndWtk0S4X03yYMBAUqCwh9kzQCEDPY/enXT0U1MG5n54q EfzqagaWEb1KiEk0qHCA07W3y5nVR/PUIBjvd/iXc/jq44UnO6OTBbMUttMttR8zi8HS jzu8KZ5CNud+pRceMeUvevt+sBxQ0F9hWYsphayVUBDwigr7Y197tYw7nVFL4u1aCbJ3 UpzwVPBd6KuBrizsDMkkaO5id+WI4LONWT+QI/nuGPKkzb5UOMfJxfBre8tfv7DSqvTt xPiy2MUPrdoM1XNkfjqFH2SAQI2VvljMImKijPhp+OTPBRno8+U96itxeMt9Z3S/Q+5W qgSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=bYuUt9kCBp/m+s+HjaTAcZUJOKBbVnbkiR1E8l0dQIs=; b=rGd3SJyMz5u1Tjr/amlPgkqwyPcRmJof8H6uXq72iiM39O+2pJv0UgGam8tzhVhxfa PtRDBYWhblfnEqM1+NtNd5MStPYOClZLam2anXed1iAlcl/7EcnW7ExENNNyJgcLXHRp 9xDzwA1wTyMeqCb8Jo+3/U15JuahhiUfPVt1vrbKL/ljzEzKAUVndt1sZgji8fosiQsj gypk59BD0HMzxRyvQB0yToQ/S5zjjgJuZJTUFKZWSMxriz7waWPAvwmJmoZWyrgSPlvP HJldrHAks4uBQ1nQkyFJJwivxuWa4+D+Y7ZgLoBcEV92UYhUNxYUHww+q6x9xDR0X9XA rEIA== X-Gm-Message-State: AMCzsaVw/WdYrc5IJKyiG3kE0CdmoEa7Mwjzyzcsn9f8yeg/RKQFBRST d7vKMiYF8LeQCGA2ocwZu0ZA7ZOjP8A= X-Google-Smtp-Source: AOwi7QDHuCLKat2Pp2gEmb6RcWDzLT8LFXeGtpGZ21EOsiPiJu3pMJLq8YR9IKqjW4JHCpFLLpi9FQ== X-Received: by 10.55.112.65 with SMTP id l62mr15462774qkc.357.1507672325071; Tue, 10 Oct 2017 14:52:05 -0700 (PDT) From: Dawid Zamirski X-Google-Original-From: Dawid Zamirski To: libvir-list@redhat.com Date: Tue, 10 Oct 2017 17:52:00 -0400 Message-Id: <20171010215202.11415-2-dzrudy@gmail.com> In-Reply-To: <20171010215202.11415-1-dzrudy@gmail.com> References: <20171010215202.11415-1-dzrudy@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 10 Oct 2017 21:52:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 10 Oct 2017 21:52:06 +0000 (UTC) for IP:'209.85.216.182' DOMAIN:'mail-qt0-f182.google.com' HELO:'mail-qt0-f182.google.com' FROM:'dzamirski@datto.com' RCPT:'' X-RedHat-Spam-Score: -0.221 (DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.216.182 mail-qt0-f182.google.com 209.85.216.182 mail-qt0-f182.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] vbox: Make autoport set RDP port range. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 Oct 2017 22:23:48 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Originally autoport in vbox driver was setting the port to default value (3389) which caused mutiple VM instances use the same port. Since libvirt XML does not allow to set port ranges, this patch changes the "autoport" behavior to set VBox's "TCP/Ports" property to an arbitraty port range (3389-3689) to avoid that issue. --- src/vbox/vbox_tmpl.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index dffeabde0..8e47d90d6 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -152,6 +152,9 @@ if (strUtf16) {\ =20 #define VBOX_IID_INITIALIZER { NULL, true } =20 +/* default RDP port range to use for auto-port setting */ +#define VBOX_RDP_AUTOPORT_RANGE "3389-3689" + static void _vboxIIDUnalloc(vboxDriverPtr data, vboxIID *iid) { @@ -1601,20 +1604,27 @@ _vrdeServerGetPorts(vboxDriverPtr data ATTRIBUTE_UN= USED, } =20 static nsresult -_vrdeServerSetPorts(vboxDriverPtr data ATTRIBUTE_UNUSED, - IVRDEServer *VRDEServer, virDomainGraphicsDefPtr graph= ics) +_vrdeServerSetPorts(vboxDriverPtr data, IVRDEServer *VRDEServer, + virDomainGraphicsDefPtr graphics) { nsresult rc =3D 0; PRUnichar *VRDEPortsKey =3D NULL; PRUnichar *VRDEPortsValue =3D NULL; =20 VBOX_UTF8_TO_UTF16("TCP/Ports", &VRDEPortsKey); - VRDEPortsValue =3D PRUnicharFromInt(data->pFuncs, graphics->data.rdp.p= ort); + + if (graphics->data.rdp.port) + VRDEPortsValue =3D PRUnicharFromInt(data->pFuncs, + graphics->data.rdp.port); + else if (graphics->data.rdp.autoport) + VBOX_UTF8_TO_UTF16(VBOX_RDP_AUTOPORT_RANGE, &VRDEPortsValue); + rc =3D VRDEServer->vtbl->SetVRDEProperty(VRDEServer, VRDEPortsKey, VRDEPortsValue); VBOX_UTF16_FREE(VRDEPortsKey); VBOX_UTF16_FREE(VRDEPortsValue); =20 + return rc; } =20 --=20 2.14.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list