The 'manage' tool can now be used to install most known guests
without requiring user interaction.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
ansible/group_vars/all/install.yml | 10 +++
ansible/host_vars/libvirt-centos-6/install.yml | 3 +
ansible/host_vars/libvirt-centos-7/install.yml | 3 +
ansible/host_vars/libvirt-debian-8/install.yml | 3 +
ansible/host_vars/libvirt-debian-9/install.yml | 3 +
ansible/host_vars/libvirt-fedora-25/install.yml | 3 +
ansible/host_vars/libvirt-fedora-26/install.yml | 3 +
.../host_vars/libvirt-fedora-rawhide/install.yml | 3 +
ansible/host_vars/libvirt-ubuntu-12/install.yml | 3 +
ansible/host_vars/libvirt-ubuntu-14/install.yml | 3 +
ansible/host_vars/libvirt-ubuntu-16/install.yml | 3 +
ansible/kickstart.cfg | 60 +++++++++++++++
ansible/manage | 74 +++++++++++++++++++
ansible/preseed.cfg | 85 ++++++++++++++++++++++
14 files changed, 259 insertions(+)
create mode 100644 ansible/group_vars/all/install.yml
create mode 100644 ansible/host_vars/libvirt-centos-6/install.yml
create mode 100644 ansible/host_vars/libvirt-centos-7/install.yml
create mode 100644 ansible/host_vars/libvirt-debian-8/install.yml
create mode 100644 ansible/host_vars/libvirt-debian-9/install.yml
create mode 100644 ansible/host_vars/libvirt-fedora-25/install.yml
create mode 100644 ansible/host_vars/libvirt-fedora-26/install.yml
create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/install.yml
create mode 100644 ansible/host_vars/libvirt-ubuntu-12/install.yml
create mode 100644 ansible/host_vars/libvirt-ubuntu-14/install.yml
create mode 100644 ansible/host_vars/libvirt-ubuntu-16/install.yml
create mode 100644 ansible/kickstart.cfg
create mode 100644 ansible/preseed.cfg
diff --git a/ansible/group_vars/all/install.yml b/ansible/group_vars/all/install.yml
new file mode 100644
index 0000000..714328e
--- /dev/null
+++ b/ansible/group_vars/all/install.yml
@@ -0,0 +1,10 @@
+---
+# Sizes are in GiB
+install_virt_type: kvm
+install_arch: x86_64
+install_machine: pc
+install_vcpus: 2
+install_memory_size: 2
+install_disk_size: 10
+install_storage_pool: default
+install_network: default
diff --git a/ansible/host_vars/libvirt-centos-6/install.yml b/ansible/host_vars/libvirt-centos-6/install.yml
new file mode 100644
index 0000000..3a9459b
--- /dev/null
+++ b/ansible/host_vars/libvirt-centos-6/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://mirror.centos.org/centos/6/os/x86_64/
+install_config: kickstart.cfg
diff --git a/ansible/host_vars/libvirt-centos-7/install.yml b/ansible/host_vars/libvirt-centos-7/install.yml
new file mode 100644
index 0000000..f003b89
--- /dev/null
+++ b/ansible/host_vars/libvirt-centos-7/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://mirror.centos.org/centos/7/os/x86_64/
+install_config: kickstart.cfg
diff --git a/ansible/host_vars/libvirt-debian-8/install.yml b/ansible/host_vars/libvirt-debian-8/install.yml
new file mode 100644
index 0000000..a2c8341
--- /dev/null
+++ b/ansible/host_vars/libvirt-debian-8/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://deb.debian.org/debian/dists/jessie/main/installer-amd64/
+install_config: preseed.cfg
diff --git a/ansible/host_vars/libvirt-debian-9/install.yml b/ansible/host_vars/libvirt-debian-9/install.yml
new file mode 100644
index 0000000..5b1da76
--- /dev/null
+++ b/ansible/host_vars/libvirt-debian-9/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
+install_config: preseed.cfg
diff --git a/ansible/host_vars/libvirt-fedora-25/install.yml b/ansible/host_vars/libvirt-fedora-25/install.yml
new file mode 100644
index 0000000..bb4bde3
--- /dev/null
+++ b/ansible/host_vars/libvirt-fedora-25/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: https://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/x86_64/os
+install_config: kickstart.cfg
diff --git a/ansible/host_vars/libvirt-fedora-26/install.yml b/ansible/host_vars/libvirt-fedora-26/install.yml
new file mode 100644
index 0000000..eff160d
--- /dev/null
+++ b/ansible/host_vars/libvirt-fedora-26/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: https://download.fedoraproject.org/pub/fedora/linux/releases/26/Server/x86_64/os
+install_config: kickstart.cfg
diff --git a/ansible/host_vars/libvirt-fedora-rawhide/install.yml b/ansible/host_vars/libvirt-fedora-rawhide/install.yml
new file mode 100644
index 0000000..2216e81
--- /dev/null
+++ b/ansible/host_vars/libvirt-fedora-rawhide/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: https://download.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/x86_64/os
+install_config: kickstart.cfg
diff --git a/ansible/host_vars/libvirt-ubuntu-12/install.yml b/ansible/host_vars/libvirt-ubuntu-12/install.yml
new file mode 100644
index 0000000..997304f
--- /dev/null
+++ b/ansible/host_vars/libvirt-ubuntu-12/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://archive.ubuntu.com/ubuntu/dists/precise/main/installer-amd64/
+install_config: preseed.cfg
diff --git a/ansible/host_vars/libvirt-ubuntu-14/install.yml b/ansible/host_vars/libvirt-ubuntu-14/install.yml
new file mode 100644
index 0000000..d7862a5
--- /dev/null
+++ b/ansible/host_vars/libvirt-ubuntu-14/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://archive.ubuntu.com/ubuntu/dists/trusty/main/installer-amd64/
+install_config: preseed.cfg
diff --git a/ansible/host_vars/libvirt-ubuntu-16/install.yml b/ansible/host_vars/libvirt-ubuntu-16/install.yml
new file mode 100644
index 0000000..a7bb2da
--- /dev/null
+++ b/ansible/host_vars/libvirt-ubuntu-16/install.yml
@@ -0,0 +1,3 @@
+---
+install_url: http://archive.ubuntu.com/ubuntu/dists/xenial/main/installer-amd64/
+install_config: preseed.cfg
diff --git a/ansible/kickstart.cfg b/ansible/kickstart.cfg
new file mode 100644
index 0000000..c28f275
--- /dev/null
+++ b/ansible/kickstart.cfg
@@ -0,0 +1,60 @@
+# Installer configuration
+#
+# Perform a text based installation followed by a reboot, and disable
+# the first boot assistant
+text
+install
+reboot
+firstboot --disable
+
+
+# Environment configuration
+#
+# Locale, keyboard and timezone. All these will be configured again
+# later with Ansible, but they're required information so we must
+# provide them
+lang en_US.UTF-8
+keyboard us
+timezone --utc Europe/Prague
+
+
+# User creation
+#
+# We don't create any user except for root. We can use a very insecure
+# root password because the guest will not be exposed to the Internet:
+# it will only be accessible from the host itself
+authconfig --enableshadow --passalgo=sha512
+rootpw --plaintext root
+
+
+# Partition disk
+#
+# Erase everything and set up a 2 GiB swap partition, then assign all
+# remaining space to the root partition
+ignoredisk --only-use=vda
+zerombr
+clearpart --none
+part / --fstype=ext4 --size=2048 --grow
+part swap --fstype=swap --size=2048
+
+
+# Install bootloader
+#
+# The bootloader will be installed in the MBR
+bootloader --location=mbr --timeout=1
+
+
+# Configure networking
+#
+# The only network interface available to the guest will come up
+# at boot using IPv4-only DHCP
+network --bootproto=dhcp --noipv6 --activate --onboot=yes
+
+
+# Software installation
+#
+# Only install the very base packages: everything else will be
+# installed later using Ansible
+%packages
+@core
+%end
diff --git a/ansible/manage b/ansible/manage
index 46bec6c..d84b8b0 100755
--- a/ansible/manage
+++ b/ansible/manage
@@ -14,6 +14,33 @@ die() {
exit 1
}
+# yaml_var FILE VAR
+#
+# Read $FILE and output the value of YAML variable $VAR. Only trivial YAML
+# values are supported, eg. strings and numbers that don't depend on the
+# value of other variables. That's enough for our use case.
+yaml_var() {
+ grep "^$2:\\s*" "$1" 2>/dev/null | tail -1 | sed "s/$2:\\s*//g"
+}
+
+# load_config FILE
+#
+# Read all known configuration variables from $FILE and set them in the
+# environment. Configuration variables that have already been set in
+# the environment will not be updated.
+load_config() {
+ INSTALL_URL=${INSTALL_URL:-$(yaml_var "$1" install_url)}
+ INSTALL_CONFIG=${INSTALL_CONFIG:-$(yaml_var "$1" install_config)}
+ INSTALL_VIRT_TYPE=${INSTALL_ARCH:-$(yaml_var "$1" install_virt_type)}
+ INSTALL_ARCH=${INSTALL_ARCH:-$(yaml_var "$1" install_arch)}
+ INSTALL_MACHINE=${INSTALL_MACHINE:-$(yaml_var "$1" install_machine)}
+ INSTALL_VCPUS=${INSTALL_VCPUS:-$(yaml_var "$1" install_vcpus)}
+ INSTALL_MEMORY_SIZE=${INSTALL_MEMORY_SIZE:-$(yaml_var "$1" install_memory_size)}
+ INSTALL_DISK_SIZE=${INSTALL_DISK_SIZE:-$(yaml_var "$1" install_disk_size)}
+ INSTALL_STORAGE_POOL=${INSTALL_STORAGE_POOL:-$(yaml_var "$1" install_storage_pool)}
+ INSTALL_NETWORK=${INSTALL_NETWORK:-$(yaml_var "$1" install_network)}
+}
+
# ----------------------
# User-visible actions
# ----------------------
@@ -24,6 +51,7 @@ Usage: $PROGRAM_NAME ACTION [OPTIONS]
Actions:
list List known guests
+ install GUEST Install GUEST
prepare GUEST Prepare or update GUEST. Can be run as many times as needed
update GUEST Alias for prepare
help Display this help"
@@ -36,6 +64,51 @@ do_list() {
grep -v '^\[' "$INVENTORY" | sort -u
}
+do_install()
+{
+ GUEST="$1"
+
+ test "$GUEST" || {
+ die "Usage: $PROGRAM_NAME install GUEST"
+ }
+ do_list | grep -q "$GUEST" || {
+ die "$PROGRAM_NAME: $GUEST: Unknown guest"
+ }
+ test -f "host_vars/$GUEST/install.yml" || {
+ die "$PROGRAM_NAME: $GUEST: Missing configuration, guest must be installed manually"
+ }
+
+ # Load configuration files. Values don't get overwritten after being
+ # set the first time, so loading the host-specific configuration before
+ # the group configuration ensures overrides work as expected
+ load_config "host_vars/$GUEST/install.yml"
+ load_config "group_vars/all/install.yml"
+
+ # Both memory size and disk size use GiB as unit, but virt-install wants
+ # disk size in GiB and memory size in *MiB*, so perform conversion here
+ INSTALL_MEMORY_SIZE=$(expr "$INSTALL_MEMORY_SIZE" \* 1024 2>/dev/null)
+
+ # preseed files must use a well-known name to be picked up by d-i;
+ # for kickstart files, we can use whatever name we please but we need
+ # to point anaconda in the right direction through a kernel argument
+ case "$INSTALL_CONFIG" in
+ *kickstart*|*ks*) EXTRA_ARGS="ks=file:/${INSTALL_CONFIG##*/}" ;;
+ esac
+
+ virt-install \
+ --name "$GUEST" \
+ --location "$INSTALL_URL" \
+ --virt-type "$INSTALL_VIRT_TYPE" \
+ --arch "$INSTALL_ARCH" \
+ --machine "$INSTALL_MACHINE" \
+ --vcpus "$INSTALL_VCPUS" \
+ --ram "$INSTALL_MEMORY_SIZE" \
+ --disk "size=$INSTALL_DISK_SIZE,pool=$INSTALL_STORAGE_POOL,bus=virtio" \
+ --network "network=$INSTALL_NETWORK,model=virtio" \
+ --initrd-inject "$INSTALL_CONFIG" \
+ --extra-args "$EXTRA_ARGS"
+}
+
do_prepare() {
GUEST="$1"
@@ -51,6 +124,7 @@ do_prepare() {
case "$1" in
list) do_list ;;
+ install) do_install "$2" ;;
prepare|update) do_prepare "$2" ;;
*help) do_help ;;
*) die "Usage: $PROGRAM_NAME ACTION [OPTIONS]" ;;
diff --git a/ansible/preseed.cfg b/ansible/preseed.cfg
new file mode 100644
index 0000000..192118e
--- /dev/null
+++ b/ansible/preseed.cfg
@@ -0,0 +1,85 @@
+# Installer configuration
+#
+# Perform an automated installation where only critical questions
+# are asked interactively
+d-i auto-install/enable boolean true
+d-i debconf/priority string critical
+d-i finish-install/reboot_in_progress note
+
+
+# Environment configuration
+#
+# Locale, keyboard and timezone. All these will be configured again
+# later with Ansible, but they're required information so we must
+# provide them
+d-i debian-installer/locale string en_US.UTF-8
+d-i keyboard-configuration/xkb-keymap select us
+d-i time/zone string Europe/Prague
+d-i clock-setup/utc boolean true
+d-i clock-setup/ntp boolean true
+
+
+# User creation
+#
+# We don't create any user except for root. We can use a very insecure
+# root password because the guest will not be exposed to the Internet:
+# it will only be accessible from the host itself
+d-i passwd/make-user boolean false
+d-i passwd/root-login boolean true
+d-i passwd/root-password password root
+d-i passwd/root-password-again password root
+d-i user-setup/allow-password-weak boolean true
+
+
+# Partition disk
+#
+# Erase everything and set up a 2 GiB swap partition, then assign all
+# remaining space to the root partition
+d-i partman-auto/disk string /dev/vda
+d-i partman-auto/method string regular
+d-i partman-auto/expert_recipe string \
+ custom :: \
+ 2048 4096 -1 ext4 \
+ $primary{ } $bootable{ } \
+ method{ format } format{ } \
+ use_filesystem{ } filesystem{ ext4 } \
+ mountpoint{ / } \
+ . \
+ 2048 2048 2048 linux-swap \
+ $primary{ } \
+ method{ swap } format{ } \
+ .
+d-i partman-partitioning/confirm_write_new_label boolean true
+d-i partman/choose_partition select finish
+d-i partman/confirm boolean true
+d-i partman/confirm_nooverwrite boolean true
+
+
+# Install bootloader
+#
+# The bootloader will be installed in the MBR
+d-i grub-installer/skip boolean false
+d-i grub-installer/bootdev string /dev/vda
+d-i grub-installer/only_debian boolean true
+
+
+# Configure networking
+#
+# The only network interface available to the guest will come up
+# at boot using DHCP
+d-i netcfg/enable boolean true
+d-i netcfg/choose_interface select auto
+d-i netcfg/get_hostname string localhost
+d-i netcfg/get_domain string localdomain
+
+
+# Software installation
+#
+# Only install the very base packages: everything else will be
+# installed later using Ansible. We need to install openssh-server
+# and configure it to permit root login now, though, otherwise we
+# won't be able to access the machine for Ansible use later on
+tasksel tasksel/first multiselect standard
+d-i pkgsel/upgrade select none
+d-i pkgsel/include string openssh-server
+d-i preseed/late_command string in-target sed -i 's/^#* *PermitRootLogin .*$/PermitRootLogin yes/g' /etc/ssh/sshd_config
--
2.13.6
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote:
> The 'manage' tool can now be used to install most known guests
> without requiring user interaction.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> ansible/group_vars/all/install.yml | 10 +++
> ansible/host_vars/libvirt-centos-6/install.yml | 3 +
> ansible/host_vars/libvirt-centos-7/install.yml | 3 +
> ansible/host_vars/libvirt-debian-8/install.yml | 3 +
> ansible/host_vars/libvirt-debian-9/install.yml | 3 +
> ansible/host_vars/libvirt-fedora-25/install.yml | 3 +
> ansible/host_vars/libvirt-fedora-26/install.yml | 3 +
> .../host_vars/libvirt-fedora-rawhide/install.yml | 3 +
> ansible/host_vars/libvirt-ubuntu-12/install.yml | 3 +
> ansible/host_vars/libvirt-ubuntu-14/install.yml | 3 +
> ansible/host_vars/libvirt-ubuntu-16/install.yml | 3 +
> ansible/kickstart.cfg | 60 +++++++++++++++
> ansible/manage | 74 +++++++++++++++++++
> ansible/preseed.cfg | 85 ++++++++++++++++++++++
> 14 files changed, 259 insertions(+)
> create mode 100644 ansible/group_vars/all/install.yml
> create mode 100644 ansible/host_vars/libvirt-centos-6/install.yml
> create mode 100644 ansible/host_vars/libvirt-centos-7/install.yml
> create mode 100644 ansible/host_vars/libvirt-debian-8/install.yml
> create mode 100644 ansible/host_vars/libvirt-debian-9/install.yml
> create mode 100644 ansible/host_vars/libvirt-fedora-25/install.yml
> create mode 100644 ansible/host_vars/libvirt-fedora-26/install.yml
> create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/install.yml
I wouldn't include Ubuntu related things. Yes, we use travis where they
have Ubuntu nodes, but this is jenkins-ci repository where we don't use
Ubuntu at all.
> create mode 100644 ansible/host_vars/libvirt-ubuntu-12/install.yml
> create mode 100644 ansible/host_vars/libvirt-ubuntu-14/install.yml
> create mode 100644 ansible/host_vars/libvirt-ubuntu-16/install.yml
> create mode 100644 ansible/kickstart.cfg
> create mode 100644 ansible/preseed.cfg
>
> diff --git a/ansible/group_vars/all/install.yml b/ansible/group_vars/all/install.yml
> new file mode 100644
> index 0000000..714328e
> --- /dev/null
> +++ b/ansible/group_vars/all/install.yml
> @@ -0,0 +1,10 @@
> +---
> +# Sizes are in GiB
> +install_virt_type: kvm
> +install_arch: x86_64
> +install_machine: pc
> +install_vcpus: 2
> +install_memory_size: 2
> +install_disk_size: 10
Currently we have 15 GiB per guest and in some cases we are able to run
out of space. Let's use 15 GiB.
> +install_storage_pool: default
> +install_network: default
> diff --git a/ansible/host_vars/libvirt-centos-6/install.yml b/ansible/host_vars/libvirt-centos-6/install.yml
> new file mode 100644
> index 0000000..3a9459b
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-centos-6/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://mirror.centos.org/centos/6/os/x86_64/
> +install_config: kickstart.cfg
> diff --git a/ansible/host_vars/libvirt-centos-7/install.yml b/ansible/host_vars/libvirt-centos-7/install.yml
> new file mode 100644
> index 0000000..f003b89
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-centos-7/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://mirror.centos.org/centos/7/os/x86_64/
> +install_config: kickstart.cfg
> diff --git a/ansible/host_vars/libvirt-debian-8/install.yml b/ansible/host_vars/libvirt-debian-8/install.yml
> new file mode 100644
> index 0000000..a2c8341
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-debian-8/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://deb.debian.org/debian/dists/jessie/main/installer-amd64/
> +install_config: preseed.cfg
> diff --git a/ansible/host_vars/libvirt-debian-9/install.yml b/ansible/host_vars/libvirt-debian-9/install.yml
> new file mode 100644
> index 0000000..5b1da76
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-debian-9/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
> +install_config: preseed.cfg
> diff --git a/ansible/host_vars/libvirt-fedora-25/install.yml b/ansible/host_vars/libvirt-fedora-25/install.yml
> new file mode 100644
> index 0000000..bb4bde3
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-fedora-25/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: https://download.fedoraproject.org/pub/fedora/linux/releases/25/Server/x86_64/os
> +install_config: kickstart.cfg
> diff --git a/ansible/host_vars/libvirt-fedora-26/install.yml b/ansible/host_vars/libvirt-fedora-26/install.yml
> new file mode 100644
> index 0000000..eff160d
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-fedora-26/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: https://download.fedoraproject.org/pub/fedora/linux/releases/26/Server/x86_64/os
> +install_config: kickstart.cfg
> diff --git a/ansible/host_vars/libvirt-fedora-rawhide/install.yml b/ansible/host_vars/libvirt-fedora-rawhide/install.yml
> new file mode 100644
> index 0000000..2216e81
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-fedora-rawhide/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: https://download.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/x86_64/os
> +install_config: kickstart.cfg
> diff --git a/ansible/host_vars/libvirt-ubuntu-12/install.yml b/ansible/host_vars/libvirt-ubuntu-12/install.yml
> new file mode 100644
> index 0000000..997304f
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-ubuntu-12/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://archive.ubuntu.com/ubuntu/dists/precise/main/installer-amd64/
> +install_config: preseed.cfg
> diff --git a/ansible/host_vars/libvirt-ubuntu-14/install.yml b/ansible/host_vars/libvirt-ubuntu-14/install.yml
> new file mode 100644
> index 0000000..d7862a5
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-ubuntu-14/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://archive.ubuntu.com/ubuntu/dists/trusty/main/installer-amd64/
> +install_config: preseed.cfg
> diff --git a/ansible/host_vars/libvirt-ubuntu-16/install.yml b/ansible/host_vars/libvirt-ubuntu-16/install.yml
> new file mode 100644
> index 0000000..a7bb2da
> --- /dev/null
> +++ b/ansible/host_vars/libvirt-ubuntu-16/install.yml
> @@ -0,0 +1,3 @@
> +---
> +install_url: http://archive.ubuntu.com/ubuntu/dists/xenial/main/installer-amd64/
> +install_config: preseed.cfg
> diff --git a/ansible/kickstart.cfg b/ansible/kickstart.cfg
> new file mode 100644
> index 0000000..c28f275
> --- /dev/null
> +++ b/ansible/kickstart.cfg
> @@ -0,0 +1,60 @@
> +# Installer configuration
> +#
> +# Perform a text based installation followed by a reboot, and disable
> +# the first boot assistant
> +text
> +install
> +reboot
> +firstboot --disable
> +
> +
> +# Environment configuration
> +#
> +# Locale, keyboard and timezone. All these will be configured again
> +# later with Ansible, but they're required information so we must
> +# provide them
> +lang en_US.UTF-8
> +keyboard us
> +timezone --utc Europe/Prague
> +
> +
> +# User creation
> +#
> +# We don't create any user except for root. We can use a very insecure
> +# root password because the guest will not be exposed to the Internet:
> +# it will only be accessible from the host itself
> +authconfig --enableshadow --passalgo=sha512
> +rootpw --plaintext root
> +
> +
> +# Partition disk
> +#
> +# Erase everything and set up a 2 GiB swap partition, then assign all
> +# remaining space to the root partition
> +ignoredisk --only-use=vda
> +zerombr
> +clearpart --none
> +part / --fstype=ext4 --size=2048 --grow
> +part swap --fstype=swap --size=2048
> +
> +
> +# Install bootloader
> +#
> +# The bootloader will be installed in the MBR
> +bootloader --location=mbr --timeout=1
> +
> +
> +# Configure networking
> +#
> +# The only network interface available to the guest will come up
> +# at boot using IPv4-only DHCP
> +network --bootproto=dhcp --noipv6 --activate --onboot=yes
> +
> +
> +# Software installation
> +#
> +# Only install the very base packages: everything else will be
> +# installed later using Ansible
> +%packages
> +@core
> +%end
> diff --git a/ansible/manage b/ansible/manage
> index 46bec6c..d84b8b0 100755
> --- a/ansible/manage
> +++ b/ansible/manage
> @@ -14,6 +14,33 @@ die() {
> exit 1
> }
>
> +# yaml_var FILE VAR
> +#
> +# Read $FILE and output the value of YAML variable $VAR. Only trivial YAML
> +# values are supported, eg. strings and numbers that don't depend on the
> +# value of other variables. That's enough for our use case.
> +yaml_var() {
> + grep "^$2:\\s*" "$1" 2>/dev/null | tail -1 | sed "s/$2:\\s*//g"
> +}
> +
> +# load_config FILE
> +#
> +# Read all known configuration variables from $FILE and set them in the
> +# environment. Configuration variables that have already been set in
> +# the environment will not be updated.
> +load_config() {
> + INSTALL_URL=${INSTALL_URL:-$(yaml_var "$1" install_url)}
> + INSTALL_CONFIG=${INSTALL_CONFIG:-$(yaml_var "$1" install_config)}
> + INSTALL_VIRT_TYPE=${INSTALL_ARCH:-$(yaml_var "$1" install_virt_type)}
> + INSTALL_ARCH=${INSTALL_ARCH:-$(yaml_var "$1" install_arch)}
> + INSTALL_MACHINE=${INSTALL_MACHINE:-$(yaml_var "$1" install_machine)}
> + INSTALL_VCPUS=${INSTALL_VCPUS:-$(yaml_var "$1" install_vcpus)}
> + INSTALL_MEMORY_SIZE=${INSTALL_MEMORY_SIZE:-$(yaml_var "$1" install_memory_size)}
> + INSTALL_DISK_SIZE=${INSTALL_DISK_SIZE:-$(yaml_var "$1" install_disk_size)}
> + INSTALL_STORAGE_POOL=${INSTALL_STORAGE_POOL:-$(yaml_var "$1" install_storage_pool)}
> + INSTALL_NETWORK=${INSTALL_NETWORK:-$(yaml_var "$1" install_network)}
> +}
> +
> # ----------------------
> # User-visible actions
> # ----------------------
> @@ -24,6 +51,7 @@ Usage: $PROGRAM_NAME ACTION [OPTIONS]
>
> Actions:
> list List known guests
> + install GUEST Install GUEST
> prepare GUEST Prepare or update GUEST. Can be run as many times as needed
> update GUEST Alias for prepare
> help Display this help"
> @@ -36,6 +64,51 @@ do_list() {
> grep -v '^\[' "$INVENTORY" | sort -u
> }
>
> +do_install()
> +{
> + GUEST="$1"
> +
> + test "$GUEST" || {
> + die "Usage: $PROGRAM_NAME install GUEST"
> + }
> + do_list | grep -q "$GUEST" || {
> + die "$PROGRAM_NAME: $GUEST: Unknown guest"
> + }
> + test -f "host_vars/$GUEST/install.yml" || {
> + die "$PROGRAM_NAME: $GUEST: Missing configuration, guest must be installed manually"
> + }
> +
> + # Load configuration files. Values don't get overwritten after being
> + # set the first time, so loading the host-specific configuration before
> + # the group configuration ensures overrides work as expected
> + load_config "host_vars/$GUEST/install.yml"
> + load_config "group_vars/all/install.yml"
> +
> + # Both memory size and disk size use GiB as unit, but virt-install wants
> + # disk size in GiB and memory size in *MiB*, so perform conversion here
> + INSTALL_MEMORY_SIZE=$(expr "$INSTALL_MEMORY_SIZE" \* 1024 2>/dev/null)
> +
> + # preseed files must use a well-known name to be picked up by d-i;
> + # for kickstart files, we can use whatever name we please but we need
> + # to point anaconda in the right direction through a kernel argument
> + case "$INSTALL_CONFIG" in
> + *kickstart*|*ks*) EXTRA_ARGS="ks=file:/${INSTALL_CONFIG##*/}" ;;
> + esac
I would add "console=ttyS0" into EXTRA_ARGS to get serial console
working.
> +
> + virt-install \
> + --name "$GUEST" \
> + --location "$INSTALL_URL" \
> + --virt-type "$INSTALL_VIRT_TYPE" \
> + --arch "$INSTALL_ARCH" \
> + --machine "$INSTALL_MACHINE" \
> + --vcpus "$INSTALL_VCPUS" \
> + --ram "$INSTALL_MEMORY_SIZE" \
Don't use --ram, that is deprecated, --memory should be used instead.
> + --disk "size=$INSTALL_DISK_SIZE,pool=$INSTALL_STORAGE_POOL,bus=virtio" \
> + --network "network=$INSTALL_NETWORK,model=virtio" \
> + --initrd-inject "$INSTALL_CONFIG" \
> + --extra-args "$EXTRA_ARGS"
and we might add:
--cpu host-passthrough // we will not migrate the guest
--graphics none // we use only ssh to the CI host
--serial pty // if something is really wrong with the guest
--autostart
Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote: > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote: > > The 'manage' tool can now be used to install most known guests > > without requiring user interaction. > > > > Signed-off-by: Andrea Bolognani <abologna@redhat.com> > > --- > > ansible/group_vars/all/install.yml | 10 +++ > > ansible/host_vars/libvirt-centos-6/install.yml | 3 + > > ansible/host_vars/libvirt-centos-7/install.yml | 3 + > > ansible/host_vars/libvirt-debian-8/install.yml | 3 + > > ansible/host_vars/libvirt-debian-9/install.yml | 3 + > > ansible/host_vars/libvirt-fedora-25/install.yml | 3 + > > ansible/host_vars/libvirt-fedora-26/install.yml | 3 + > > .../host_vars/libvirt-fedora-rawhide/install.yml | 3 + > > ansible/host_vars/libvirt-ubuntu-12/install.yml | 3 + > > ansible/host_vars/libvirt-ubuntu-14/install.yml | 3 + > > ansible/host_vars/libvirt-ubuntu-16/install.yml | 3 + > > ansible/kickstart.cfg | 60 +++++++++++++++ > > ansible/manage | 74 +++++++++++++++++++ > > ansible/preseed.cfg | 85 ++++++++++++++++++++++ > > 14 files changed, 259 insertions(+) > > create mode 100644 ansible/group_vars/all/install.yml > > create mode 100644 ansible/host_vars/libvirt-centos-6/install.yml > > create mode 100644 ansible/host_vars/libvirt-centos-7/install.yml > > create mode 100644 ansible/host_vars/libvirt-debian-8/install.yml > > create mode 100644 ansible/host_vars/libvirt-debian-9/install.yml > > create mode 100644 ansible/host_vars/libvirt-fedora-25/install.yml > > create mode 100644 ansible/host_vars/libvirt-fedora-26/install.yml > > create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/install.yml > > I wouldn't include Ubuntu related things. Yes, we use travis where they > have Ubuntu nodes, but this is jenkins-ci repository where we don't use > Ubuntu at all. > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-12/install.yml > > create mode 100644 ansible/host_vars/libvirt-ubuntu-14/install.yml > > create mode 100644 ansible/host_vars/libvirt-ubuntu-16/install.yml > > create mode 100644 ansible/kickstart.cfg > > create mode 100644 ansible/preseed.cfg > > > > diff --git a/ansible/group_vars/all/install.yml b/ansible/group_vars/all/install.yml > > new file mode 100644 > > index 0000000..714328e > > --- /dev/null > > +++ b/ansible/group_vars/all/install.yml > > @@ -0,0 +1,10 @@ > > +--- > > +# Sizes are in GiB > > +install_virt_type: kvm > > +install_arch: x86_64 > > +install_machine: pc > > +install_vcpus: 2 > > +install_memory_size: 2 > > +install_disk_size: 10 > > Currently we have 15 GiB per guest and in some cases we are able to run > out of space. Let's use 15 GiB. We used to run out of space periodically because our RPM build jobs were creating RPMs in $HOME/rpmbuild which jenkins never purged. I reconfigured Jenkins to use the GIT workspace as the RPM build dir, so jenkins always purges RPMs. Since then we've not run out of space again AFAIK. None the less, I agree that 15 GiB is probably the min we need > > diff --git a/ansible/kickstart.cfg b/ansible/kickstart.cfg > > new file mode 100644 > > index 0000000..c28f275 > > --- /dev/null > > +++ b/ansible/kickstart.cfg > > @@ -0,0 +1,60 @@ > > +# Installer configuration > > +# > > +# Perform a text based installation followed by a reboot, and disable > > +# the first boot assistant > > +text > > +install > > +reboot > > +firstboot --disable > > + > > + > > +# Environment configuration > > +# > > +# Locale, keyboard and timezone. All these will be configured again > > +# later with Ansible, but they're required information so we must > > +# provide them > > +lang en_US.UTF-8 > > +keyboard us > > +timezone --utc Europe/Prague How about UTC as a neutral option for timezone ;-) > > + > > + > > +# User creation > > +# > > +# We don't create any user except for root. We can use a very insecure > > +# root password because the guest will not be exposed to the Internet: > > +# it will only be accessible from the host itself > > +authconfig --enableshadow --passalgo=sha512 > > +rootpw --plaintext root > > + > > + > > +# Partition disk > > +# > > +# Erase everything and set up a 2 GiB swap partition, then assign all > > +# remaining space to the root partition > > +ignoredisk --only-use=vda > > +zerombr > > +clearpart --none > > +part / --fstype=ext4 --size=2048 --grow > > +part swap --fstype=swap --size=2048 We shouldn't need 2 GiB swap - any builder that uses even a few 100 MB of swap is doomed. I'd give it 300 MB swap max. > > + virt-install \ > > + --name "$GUEST" \ > > + --location "$INSTALL_URL" \ > > + --virt-type "$INSTALL_VIRT_TYPE" \ > > + --arch "$INSTALL_ARCH" \ > > + --machine "$INSTALL_MACHINE" \ > > + --vcpus "$INSTALL_VCPUS" \ > > + --ram "$INSTALL_MEMORY_SIZE" \ > > Don't use --ram, that is deprecated, --memory should be used instead. > > > + --disk "size=$INSTALL_DISK_SIZE,pool=$INSTALL_STORAGE_POOL,bus=virtio" \ > > + --network "network=$INSTALL_NETWORK,model=virtio" \ > > + --initrd-inject "$INSTALL_CONFIG" \ > > + --extra-args "$EXTRA_ARGS" > > and we might add: > > --cpu host-passthrough // we will not migrate the guest > --graphics none // we use only ssh to the CI host > --serial pty // if something is really wrong with the guest > --autostart Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Oct 17, 2017 at 05:04:57PM +0100, Daniel P. Berrange wrote: > On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote: > > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote: > > > The 'manage' tool can now be used to install most known guests > > > without requiring user interaction. > > > > > > Signed-off-by: Andrea Bolognani <abologna@redhat.com> > > > --- > > > ansible/group_vars/all/install.yml | 10 +++ > > > ansible/host_vars/libvirt-centos-6/install.yml | 3 + > > > ansible/host_vars/libvirt-centos-7/install.yml | 3 + > > > ansible/host_vars/libvirt-debian-8/install.yml | 3 + > > > ansible/host_vars/libvirt-debian-9/install.yml | 3 + > > > ansible/host_vars/libvirt-fedora-25/install.yml | 3 + > > > ansible/host_vars/libvirt-fedora-26/install.yml | 3 + > > > .../host_vars/libvirt-fedora-rawhide/install.yml | 3 + > > > ansible/host_vars/libvirt-ubuntu-12/install.yml | 3 + > > > ansible/host_vars/libvirt-ubuntu-14/install.yml | 3 + > > > ansible/host_vars/libvirt-ubuntu-16/install.yml | 3 + > > > ansible/kickstart.cfg | 60 +++++++++++++++ > > > ansible/manage | 74 +++++++++++++++++++ > > > ansible/preseed.cfg | 85 ++++++++++++++++++++++ > > > 14 files changed, 259 insertions(+) > > > create mode 100644 ansible/group_vars/all/install.yml > > > create mode 100644 ansible/host_vars/libvirt-centos-6/install.yml > > > create mode 100644 ansible/host_vars/libvirt-centos-7/install.yml > > > create mode 100644 ansible/host_vars/libvirt-debian-8/install.yml > > > create mode 100644 ansible/host_vars/libvirt-debian-9/install.yml > > > create mode 100644 ansible/host_vars/libvirt-fedora-25/install.yml > > > create mode 100644 ansible/host_vars/libvirt-fedora-26/install.yml > > > create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/install.yml > > > > I wouldn't include Ubuntu related things. Yes, we use travis where they > > have Ubuntu nodes, but this is jenkins-ci repository where we don't use > > Ubuntu at all. > > > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-12/install.yml > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-14/install.yml > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-16/install.yml > > > create mode 100644 ansible/kickstart.cfg > > > create mode 100644 ansible/preseed.cfg > > > > > > diff --git a/ansible/group_vars/all/install.yml b/ansible/group_vars/all/install.yml > > > new file mode 100644 > > > index 0000000..714328e > > > --- /dev/null > > > +++ b/ansible/group_vars/all/install.yml > > > @@ -0,0 +1,10 @@ > > > +--- > > > +# Sizes are in GiB > > > +install_virt_type: kvm > > > +install_arch: x86_64 > > > +install_machine: pc > > > +install_vcpus: 2 > > > +install_memory_size: 2 > > > +install_disk_size: 10 > > > > Currently we have 15 GiB per guest and in some cases we are able to run > > out of space. Let's use 15 GiB. > > We used to run out of space periodically because our RPM build jobs were > creating RPMs in $HOME/rpmbuild which jenkins never purged. I reconfigured > Jenkins to use the GIT workspace as the RPM build dir, so jenkins always > purges RPMs. Since then we've not run out of space again AFAIK. None the > less, I agree that 15 GiB is probably the min we need Mainly because some of the guests have only 10 GiB disk. > > > diff --git a/ansible/kickstart.cfg b/ansible/kickstart.cfg > > > new file mode 100644 > > > index 0000000..c28f275 > > > --- /dev/null > > > +++ b/ansible/kickstart.cfg > > > @@ -0,0 +1,60 @@ > > > +# Installer configuration > > > +# > > > +# Perform a text based installation followed by a reboot, and disable > > > +# the first boot assistant > > > +text > > > +install > > > +reboot > > > +firstboot --disable > > > + > > > + > > > +# Environment configuration > > > +# > > > +# Locale, keyboard and timezone. All these will be configured again > > > +# later with Ansible, but they're required information so we must > > > +# provide them > > > +lang en_US.UTF-8 > > > +keyboard us > > > +timezone --utc Europe/Prague > > How about UTC as a neutral option for timezone ;-) +1 > > > > > + > > > + > > > +# User creation > > > +# > > > +# We don't create any user except for root. We can use a very insecure > > > +# root password because the guest will not be exposed to the Internet: > > > +# it will only be accessible from the host itself > > > +authconfig --enableshadow --passalgo=sha512 > > > +rootpw --plaintext root > > > + > > > + > > > +# Partition disk > > > +# > > > +# Erase everything and set up a 2 GiB swap partition, then assign all > > > +# remaining space to the root partition > > > +ignoredisk --only-use=vda > > > +zerombr > > > +clearpart --none > > > +part / --fstype=ext4 --size=2048 --grow > > > +part swap --fstype=swap --size=2048 > > We shouldn't need 2 GiB swap - any builder that uses even a few 100 MB > of swap is doomed. I'd give it 300 MB swap max. We can definitely try that, I'm not sure how much memory the guest needs if there are multiple jobs running. Pavel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Oct 17, 2017 at 06:14:35PM +0200, Pavel Hrdina wrote: > On Tue, Oct 17, 2017 at 05:04:57PM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote: > > > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote: > > > > The 'manage' tool can now be used to install most known guests > > > > without requiring user interaction. > > > > > > > > Signed-off-by: Andrea Bolognani <abologna@redhat.com> > > > > --- > > > > ansible/group_vars/all/install.yml | 10 +++ > > > > ansible/host_vars/libvirt-centos-6/install.yml | 3 + > > > > ansible/host_vars/libvirt-centos-7/install.yml | 3 + > > > > ansible/host_vars/libvirt-debian-8/install.yml | 3 + > > > > ansible/host_vars/libvirt-debian-9/install.yml | 3 + > > > > ansible/host_vars/libvirt-fedora-25/install.yml | 3 + > > > > ansible/host_vars/libvirt-fedora-26/install.yml | 3 + > > > > .../host_vars/libvirt-fedora-rawhide/install.yml | 3 + > > > > ansible/host_vars/libvirt-ubuntu-12/install.yml | 3 + > > > > ansible/host_vars/libvirt-ubuntu-14/install.yml | 3 + > > > > ansible/host_vars/libvirt-ubuntu-16/install.yml | 3 + > > > > ansible/kickstart.cfg | 60 +++++++++++++++ > > > > ansible/manage | 74 +++++++++++++++++++ > > > > ansible/preseed.cfg | 85 ++++++++++++++++++++++ > > > > 14 files changed, 259 insertions(+) > > > > create mode 100644 ansible/group_vars/all/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-centos-6/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-centos-7/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-debian-8/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-debian-9/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-fedora-25/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-fedora-26/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/install.yml > > > > > > I wouldn't include Ubuntu related things. Yes, we use travis where they > > > have Ubuntu nodes, but this is jenkins-ci repository where we don't use > > > Ubuntu at all. > > > > > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-12/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-14/install.yml > > > > create mode 100644 ansible/host_vars/libvirt-ubuntu-16/install.yml > > > > create mode 100644 ansible/kickstart.cfg > > > > create mode 100644 ansible/preseed.cfg > > > > > > > > diff --git a/ansible/group_vars/all/install.yml b/ansible/group_vars/all/install.yml > > > > new file mode 100644 > > > > index 0000000..714328e > > > > --- /dev/null > > > > +++ b/ansible/group_vars/all/install.yml > > > > @@ -0,0 +1,10 @@ > > > > +--- > > > > +# Sizes are in GiB > > > > +install_virt_type: kvm > > > > +install_arch: x86_64 > > > > +install_machine: pc > > > > +install_vcpus: 2 > > > > +install_memory_size: 2 > > > > +install_disk_size: 10 > > > > > > Currently we have 15 GiB per guest and in some cases we are able to run > > > out of space. Let's use 15 GiB. > > > > We used to run out of space periodically because our RPM build jobs were > > creating RPMs in $HOME/rpmbuild which jenkins never purged. I reconfigured > > Jenkins to use the GIT workspace as the RPM build dir, so jenkins always > > purges RPMs. Since then we've not run out of space again AFAIK. None the > > less, I agree that 15 GiB is probably the min we need > > Mainly because some of the guests have only 10 GiB disk. > > > > > diff --git a/ansible/kickstart.cfg b/ansible/kickstart.cfg > > > > new file mode 100644 > > > > index 0000000..c28f275 > > > > --- /dev/null > > > > +++ b/ansible/kickstart.cfg > > > > @@ -0,0 +1,60 @@ > > > > +# Installer configuration > > > > +# > > > > +# Perform a text based installation followed by a reboot, and disable > > > > +# the first boot assistant > > > > +text > > > > +install > > > > +reboot > > > > +firstboot --disable > > > > + > > > > + > > > > +# Environment configuration > > > > +# > > > > +# Locale, keyboard and timezone. All these will be configured again > > > > +# later with Ansible, but they're required information so we must > > > > +# provide them > > > > +lang en_US.UTF-8 > > > > +keyboard us > > > > +timezone --utc Europe/Prague > > > > How about UTC as a neutral option for timezone ;-) > > +1 > > > > > > > > > + > > > > + > > > > +# User creation > > > > +# > > > > +# We don't create any user except for root. We can use a very insecure > > > > +# root password because the guest will not be exposed to the Internet: > > > > +# it will only be accessible from the host itself > > > > +authconfig --enableshadow --passalgo=sha512 > > > > +rootpw --plaintext root > > > > + > > > > + > > > > +# Partition disk > > > > +# > > > > +# Erase everything and set up a 2 GiB swap partition, then assign all > > > > +# remaining space to the root partition > > > > +ignoredisk --only-use=vda > > > > +zerombr > > > > +clearpart --none > > > > +part / --fstype=ext4 --size=2048 --grow > > > > +part swap --fstype=swap --size=2048 > > > > We shouldn't need 2 GiB swap - any builder that uses even a few 100 MB > > of swap is doomed. I'd give it 300 MB swap max. > > We can definitely try that, I'm not sure how much memory the guest needs > if there are multiple jobs running. If we have too much load from jobs for the amount of RAM allocated, such that some are pushed to swap, the build time is just going to balloon. We would get faster builds by reducing the number of parallel jobs so that we don't exceed RAM, even if this ends up basically serializing most of it. Or give guests more RAM, and let the host OS do swapping of idle KVM instances instead. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, 2017-10-17 at 17:57 +0200, Pavel Hrdina wrote:
> I wouldn't include Ubuntu related things. Yes, we use travis where they
> have Ubuntu nodes, but this is jenkins-ci repository where we don't use
> Ubuntu at all.
While a sane CI setup is definitely the primary reason why this work
is happening, a secondary goal is making it possible for (potential)
developers to ensure portability and debug build issues on platforms
that they don't already have easy access to. The overlap between the
two goals is basically 99% anyway.
Moreover, if some build job fails on Travis, it would be nice to
quickly reproduce the failure locally[1] instead of doing multiple
round-trips to Travis. So I vote for keeping the Ubuntu bits,
especially considering that the overhead is literally 9 lines :)
> > +install_disk_size: 10
>
> Currently we have 15 GiB per guest and in some cases we are able to run
> out of space. Let's use 15 GiB.
Sure.
> > + case "$INSTALL_CONFIG" in
> > + *kickstart*|*ks*) EXTRA_ARGS="ks=file:/${INSTALL_CONFIG##*/}" ;;
> > + esac
>
> I would add "console=ttyS0" into EXTRA_ARGS to get serial console
> working.
I prefer serial console to graphical console too, but for some reason
I thought that would not be appropriate for the CI setup... Guess I
should just have asked ;)
> > + --ram "$INSTALL_MEMORY_SIZE" \
>
> Don't use --ram, that is deprecated, --memory should be used instead.
TIL! Consider it done.
> > + --disk "size=$INSTALL_DISK_SIZE,pool=$INSTALL_STORAGE_POOL,bus=virtio" \
> > + --network "network=$INSTALL_NETWORK,model=virtio" \
> > + --initrd-inject "$INSTALL_CONFIG" \
> > + --extra-args "$EXTRA_ARGS"
>
> and we might add:
>
> --cpu host-passthrough // we will not migrate the guest
> --graphics none // we use only ssh to the CI host
> --serial pty // if something is really wrong with the guest
> --autostart
These all look sensible, I'll add them.
[1] I almost had a success story I could use to prove my point today:
Martin ran into a Travis build failure while testing out some new
stuff, and thanks to the Ubuntu configs we were able to bring up
a fully-configured Ubuntu 14.04 guest in around 10 minutes.
Unfortunately the failure ended up not reproducing in the guest,
which is quite annoying and something that requires more
investigation, but the point about the usefulness of having this
ability still stands IMHO.
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Oct 17, 2017 at 06:24:47PM +0200, Andrea Bolognani wrote: > On Tue, 2017-10-17 at 17:57 +0200, Pavel Hrdina wrote: > > I wouldn't include Ubuntu related things. Yes, we use travis where they > > have Ubuntu nodes, but this is jenkins-ci repository where we don't use > > Ubuntu at all. > > While a sane CI setup is definitely the primary reason why this work > is happening, a secondary goal is making it possible for (potential) > developers to ensure portability and debug build issues on platforms > that they don't already have easy access to. The overlap between the > two goals is basically 99% anyway. > > Moreover, if some build job fails on Travis, it would be nice to > quickly reproduce the failure locally[1] instead of doing multiple > round-trips to Travis. So I vote for keeping the Ubuntu bits, > especially considering that the overhead is literally 9 lines :) Yeah, I think it is reasonable to have Ubuntu support. Travis is somewhat performance limited, so if we ever get more CI hardware of our own I would expect us to move Ubuntu jobs off Travis. The only key unique thing about Travis is ability to build on OS-X - we can't easily replicate that ourselves due to OS-X restrictive licensing. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, 2017-10-17 at 17:32 +0100, Daniel P. Berrange wrote: > Yeah, I think it is reasonable to have Ubuntu support. Travis is somewhat > performance limited Not to mention the embarassingly outdated OS offering. But hey, it's worth every penny we spend on it! :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2025 Red Hat, Inc.