From nobody Thu May 15 12:27:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508427416132445.10231310091865; Thu, 19 Oct 2017 08:36:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0433913A5F; Thu, 19 Oct 2017 15:36:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE02DD9555; Thu, 19 Oct 2017 15:36:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 90EC81800C9D; Thu, 19 Oct 2017 15:36:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9JFaoBW013832 for ; Thu, 19 Oct 2017 11:36:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 38168BA215; Thu, 19 Oct 2017 15:36:50 +0000 (UTC) Received: from inaba.usersys.redhat.com (ovpn-204-95.brq.redhat.com [10.40.204.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9190DBA213 for ; Thu, 19 Oct 2017 15:36:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0433913A5F Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 19 Oct 2017 17:36:31 +0200 Message-Id: <20171019153632.15016-6-abologna@redhat.com> In-Reply-To: <20171019153632.15016-1-abologna@redhat.com> References: <20171019153632.15016-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-jenkins-ci PATCH 5/6] guests: Hand root password location over to Ansible X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 19 Oct 2017 15:36:54 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Instead of hard-coding the location in the playbook, we hand it over at runtime when calling ansible-playbook, ensuring better separation of concerns. Signed-off-by: Andrea Bolognani --- guests/lcitool | 2 +- guests/tasks/base.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 018640b..1efe7e5 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -197,7 +197,7 @@ do_prepare() { =20 load_config =20 - EXTRA_VARS=3D"flavor=3D$FLAVOR" + EXTRA_VARS=3D"flavor=3D$FLAVOR root_password_file=3D$ROOT_HASH_FILE" =20 ansible-playbook \ --vault-password-file "$VAULT_PASS_FILE" \ diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index b220bb0..8949632 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -99,7 +99,7 @@ - name: Configure root password and shell user: name: root - password: '{{ lookup("file", lookup("env", "HOME") + "/.config/lcitool= /.root-password.hash") }}' + password: '{{ lookup("file", root_password_file) }}' shell: '{{ bash }}' =20 - name: Configure ssh access for the root user --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list