From nobody Thu May 15 12:18:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508758551351556.1694107516057; Mon, 23 Oct 2017 04:35:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2FB9C0006E1; Mon, 23 Oct 2017 11:35:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60C177982B; Mon, 23 Oct 2017 11:35:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 808BC1804482; Mon, 23 Oct 2017 11:35:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9NBZkdH016577 for ; Mon, 23 Oct 2017 07:35:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id D489E7BFFD; Mon, 23 Oct 2017 11:35:46 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D0267BFFB for ; Mon, 23 Oct 2017 11:35:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B2FB9C0006E1 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 23 Oct 2017 13:35:37 +0200 Message-Id: <20171023113538.10047-3-abologna@redhat.com> In-Reply-To: <20171023113538.10047-1-abologna@redhat.com> References: <20171023113538.10047-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 2/3] ansible: Use ansible_distribution_release on FreeBSD X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 23 Oct 2017 11:35:50 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In general, we can rely on ansible_distribution_major_version for a quick way to figure out the OS version; however, when it comes to FreeBSD's -CURRENT snapshots, that variable is not available, which causes the playbook to fail. Work around the problem by always extracting the OS version from ansible_distribution_release, which is available even on -CURRENT. Signed-off-by: Andrea Bolognani --- guests/tasks/base.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index abfd6a1..64fbabd 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -4,6 +4,7 @@ os_name: '{{ ansible_distribution }}' os_version: '{{ ansible_distribution_major_version }}' when: + - ansible_distribution !=3D 'FreeBSD' - ansible_distribution_release !=3D 'Rawhide' =20 - name: Set additional facts (OS) @@ -11,8 +12,16 @@ os_name: '{{ ansible_distribution }}' os_version: Rawhide when: + - ansible_distribution !=3D 'FreeBSD' - ansible_distribution_release =3D=3D 'Rawhide' =20 +- name: Set additional facts (OS) + set_fact: + os_name: '{{ ansible_distribution }}' + os_version: '{{ ansible_distribution_release|regex_replace("^(\d+)\.\d= +-.*$", "\1") }}' + when: + - ansible_distribution =3D=3D 'FreeBSD' + - name: Set additional facts (package format) set_fact: package_format: deb --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list