From nobody Tue Dec 16 08:51:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508764755999794.5441216020699; Mon, 23 Oct 2017 06:19:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14E6772D10; Mon, 23 Oct 2017 13:19:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E09A078DEF; Mon, 23 Oct 2017 13:19:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B9E575EC64; Mon, 23 Oct 2017 13:19:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9NDJCJe002275 for ; Mon, 23 Oct 2017 09:19:12 -0400 Received: by smtp.corp.redhat.com (Postfix) id 51E697982B; Mon, 23 Oct 2017 13:19:12 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE8436A509 for ; Mon, 23 Oct 2017 13:19:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 14E6772D10 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Date: Mon, 23 Oct 2017 15:19:00 +0200 Message-Id: <20171023131904.28213-2-abologna@redhat.com> In-Reply-To: <20171023131904.28213-1-abologna@redhat.com> References: <20171023131904.28213-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH v2 1/5] guests: Shuffle base steps around X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 23 Oct 2017 13:19:14 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We want to add extra repositories before updating the installed packages; however, adding extra repositories might require the libselinux-python package to be installed on some systems. Reorder the steps so that the libselinux-python package is installed before adding extra repositories, which in turn happens before updating installed packages. Signed-off-by: Andrea Bolognani --- guests/tasks/base.yml | 48 ++++++++++++++++++++++++------------------------ 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index 572da9d..798d7cd 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -33,6 +33,30 @@ - ( os_name =3D=3D 'CentOS' or os_name =3D=3D 'Fedora' ) =20 +- name: Bootstrap the package module + command: apt-get install -y python-apt + args: + creates: /usr/lib/python2*/*-packages/apt + warn: no + when: + - package_format =3D=3D 'deb' + +- name: Bootstrap the package module + command: dnf install -y python2-dnf + args: + creates: /usr/lib*/python2*/*-packages/dnf + warn: no + when: + - os_name =3D=3D 'Fedora' + +- name: Permit file editing on SELinux-enabled systems + package: + name: libselinux-python + state: present + when: + - ( os_name =3D=3D 'CentOS' or + os_name =3D=3D 'Fedora' ) + - name: Enable jessie-backports repository copy: src: files/jessie-backports.sources @@ -53,22 +77,6 @@ - os_name =3D=3D 'Debian' - os_version =3D=3D '8' =20 -- name: Bootstrap the package module - command: apt-get install -y python-apt - args: - creates: /usr/lib/python2*/*-packages/apt - warn: no - when: - - package_format =3D=3D 'deb' - -- name: Bootstrap the package module - command: dnf install -y python2-dnf - args: - creates: /usr/lib*/python2*/*-packages/dnf - warn: no - when: - - os_name =3D=3D 'Fedora' - - name: Update installed packages package: name: '*' @@ -106,14 +114,6 @@ with_items: - nano =20 -- name: Permit file editing on SELinux-enabled systems - package: - name: libselinux-python - state: present - when: - - ( os_name =3D=3D 'CentOS' or - os_name =3D=3D 'Fedora' ) - - name: Configure hostname hostname: name: '{{ inventory_hostname }}' --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list