From nobody Thu May 15 18:13:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 150887936985364.4992129743448; Tue, 24 Oct 2017 14:09:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 276A2820FF; Tue, 24 Oct 2017 21:09:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C74A660176; Tue, 24 Oct 2017 21:09:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 039D46EF22; Tue, 24 Oct 2017 21:09:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9OL9Opf023729 for ; Tue, 24 Oct 2017 17:09:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1CCD45DA69; Tue, 24 Oct 2017 21:09:24 +0000 (UTC) Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 175325D9CB for ; Tue, 24 Oct 2017 21:09:21 +0000 (UTC) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF40F7EA9E for ; Tue, 24 Oct 2017 21:09:20 +0000 (UTC) Received: by mail-qk0-f195.google.com with SMTP id b15so28062183qkg.9 for ; Tue, 24 Oct 2017 14:09:20 -0700 (PDT) Received: from dawid-fedora.datto.lan ([47.19.105.250]) by smtp.gmail.com with ESMTPSA id e43sm901453qte.74.2017.10.24.14.09.19 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 14:09:19 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 276A2820FF Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 276A2820FF Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=datto-com.20150623.gappssmtp.com header.i=@datto-com.20150623.gappssmtp.com header.b="IjHq7ZXO" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AF40F7EA9E Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dzamirski@datto.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AF40F7EA9E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datto-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=gBsLN01U/jEUPkPVyu7h3sE4MUrEbiQvUpodKz8EY7g=; b=IjHq7ZXObQsmfAxX4//CXjJ3grDfUipl9fcmjs5HGeTqoafv/X9zLQ0UCAvTZvdfXN xvNOOIuf1XwnuS3Z6XgJzr+UqC62ZrOXpLFFjIDTT7gh/clIZnrjr+hDfBj6002i9iuy DM13ICXX/YO5iXAH38UuDPp6eSbJWuAe3ka+4A7aP/D5u3P370E0FRDedtZL+/Yn8WsF 0bqFmkvlvAc/QEpCnZHTgUxCALTca/ePJcLq3ugMIX4Fa0f7yRATNVI8H1nFz9WKOnFS j4Vy8m9jR2ZinbRn4Ip7dd80uMzloQi7nfHrdBEjHRLYwhYC8ksM44YQ6TKSM7AAQyfX LRyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=gBsLN01U/jEUPkPVyu7h3sE4MUrEbiQvUpodKz8EY7g=; b=LrrKhQRA4X3JhOJhcgZ3fDmf8OFm33Q9x97AjkIEdkY2Ejbv94R09JbXCTv9ja5foo W0eNcIdenwzT3kEYgvIH7ZxZi+08D9sZkEHSK/s5xEJG+7G9EojUY9ziHbXfH60lyn2s VD7dTWO+zidMpJS+YUvIlDuNO/fLaJFvFvp4nVkPtMoGcY6c282vVFs7yAAzXR3SedIm sTec0QhxO4DNEnzPJ1hBhqARcf7wXr+zpI7I7xTDAfv2Cetxl0O98SHKBcH3UKAIViOY lO3IO7AStKEQGCX+B+TDsIx++6neMjGdtau2mapT9K+COU0pQV82Y4vK2wY+P+TOfO0x wL2A== X-Gm-Message-State: AMCzsaWKCO1WlPRk+Nolvw1YG4zsIGnTgp/dpvSsybOruRTIehByWXX5 CQ7Dp2maBi6xOJH7QP6MsnfN7JCIYK4= X-Google-Smtp-Source: ABhQp+RYTCRuTiXIC1YVgKOFSNlzWfdbbpzQqXpLKVrPrm5V31B0f1bElKws+ZLgorv48/XqpPCt1g== X-Received: by 10.55.26.219 with SMTP id l88mr26277952qkh.57.1508879359700; Tue, 24 Oct 2017 14:09:19 -0700 (PDT) From: Dawid Zamirski To: libvir-list@redhat.com Date: Tue, 24 Oct 2017 17:09:16 -0400 Message-Id: <20171024210917.7728-3-dzamirski@datto.com> In-Reply-To: <20171024210917.7728-1-dzamirski@datto.com> References: <20171024210917.7728-1-dzamirski@datto.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 24 Oct 2017 21:09:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 24 Oct 2017 21:09:20 +0000 (UTC) for IP:'209.85.220.195' DOMAIN:'mail-qk0-f195.google.com' HELO:'mail-qk0-f195.google.com' FROM:'dzamirski@datto.com' RCPT:'' X-RedHat-Spam-Score: 0.469 (DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.220.195 mail-qk0-f195.google.com 209.85.220.195 mail-qk0-f195.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 2/3] vbox: Make autoport set RDP port range. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 24 Oct 2017 21:09:28 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Dawid Zamirski Originally autoport in vbox driver was setting the port to default value (3389) which caused multiple VM instances use the same port. Since libvirt XML does not allow to set port ranges, this patch changes the "autoport" behavior to set VBox's "TCP/Ports" property to an arbitrary port range (3389-3689) to avoid that issue. Reviewed-by: John Ferlan --- src/vbox/vbox_tmpl.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index ce2ee9037..2b3f2e3eb 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -146,6 +146,9 @@ if (strUtf16) {\ =20 #define VBOX_IID_INITIALIZER { NULL, true } =20 +/* default RDP port range to use for auto-port setting */ +#define VBOX_RDP_AUTOPORT_RANGE "3389-3689" + static void _vboxIIDUnalloc(vboxDriverPtr data, vboxIID *iid) { @@ -1595,15 +1598,21 @@ _vrdeServerGetPorts(vboxDriverPtr data ATTRIBUTE_UN= USED, } =20 static nsresult -_vrdeServerSetPorts(vboxDriverPtr data ATTRIBUTE_UNUSED, - IVRDEServer *VRDEServer, virDomainGraphicsDefPtr graph= ics) +_vrdeServerSetPorts(vboxDriverPtr data, IVRDEServer *VRDEServer, + virDomainGraphicsDefPtr graphics) { nsresult rc =3D 0; PRUnichar *VRDEPortsKey =3D NULL; PRUnichar *VRDEPortsValue =3D NULL; =20 VBOX_UTF8_TO_UTF16("TCP/Ports", &VRDEPortsKey); - VRDEPortsValue =3D PRUnicharFromInt(data->pFuncs, graphics->data.rdp.p= ort); + + if (graphics->data.rdp.autoport) + VBOX_UTF8_TO_UTF16(VBOX_RDP_AUTOPORT_RANGE, &VRDEPortsValue); + else + VRDEPortsValue =3D PRUnicharFromInt(data->pFuncs, + graphics->data.rdp.port); + rc =3D VRDEServer->vtbl->SetVRDEProperty(VRDEServer, VRDEPortsKey, VRDEPortsValue); VBOX_UTF16_FREE(VRDEPortsKey); --=20 2.14.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list