From nobody Thu May 15 04:37:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1509111176075461.5779188364222; Fri, 27 Oct 2017 06:32:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4E1961D35; Fri, 27 Oct 2017 13:32:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0C4E80DFC; Fri, 27 Oct 2017 13:32:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6D71F6EF25; Fri, 27 Oct 2017 13:32:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9RDVslh000932 for ; Fri, 27 Oct 2017 09:31:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 43A9960C8A; Fri, 27 Oct 2017 13:31:54 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-204-199.brq.redhat.com [10.40.204.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2006960BEB; Fri, 27 Oct 2017 13:31:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D4E1961D35 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: "Daniel P. Berrange" To: libvir-list@redhat.com Date: Fri, 27 Oct 2017 14:31:40 +0100 Message-Id: <20171027133143.2553-3-berrange@redhat.com> In-Reply-To: <20171027133143.2553-1-berrange@redhat.com> References: <20171027133143.2553-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH dbus 2/5] src: annotate parameters that are unused in functions X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 27 Oct 2017 13:32:54 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Introduce a VIR_ATTR_UNUSED macro to annotate parameters that are unused in functions. Signed-off-by: Daniel P. Berrange --- src/domain.c | 78 +++++++++++++++++++++++++++++--------------------------= ---- src/events.c | 12 ++++----- src/main.c | 12 ++++----- src/manager.c | 4 +-- src/util.h | 2 ++ 5 files changed, 55 insertions(+), 53 deletions(-) diff --git a/src/domain.c b/src/domain.c index bbe27b9..5527778 100644 --- a/src/domain.c +++ b/src/domain.c @@ -2,13 +2,13 @@ #include "util.h" =20 static int -virtDBusDomainGetName(sd_bus *bus, +virtDBusDomainGetName(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -26,13 +26,13 @@ virtDBusDomainGetName(sd_bus *bus, } =20 static int -virtDBusDomainGetUUID(sd_bus *bus, +virtDBusDomainGetUUID(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -48,13 +48,13 @@ virtDBusDomainGetUUID(sd_bus *bus, } =20 static int -virtDBusDomainGetId(sd_bus *bus, +virtDBusDomainGetId(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -67,13 +67,13 @@ virtDBusDomainGetId(sd_bus *bus, } =20 static int -virtDBusDomainGetVcpus(sd_bus *bus, +virtDBusDomainGetVcpus(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -86,13 +86,13 @@ virtDBusDomainGetVcpus(sd_bus *bus, } =20 static int -virtDBusDomainGetOsType(sd_bus *bus, +virtDBusDomainGetOsType(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -110,13 +110,13 @@ virtDBusDomainGetOsType(sd_bus *bus, } =20 static int -virtDBusDomainGetActive(sd_bus *bus, +virtDBusDomainGetActive(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -134,13 +134,13 @@ virtDBusDomainGetActive(sd_bus *bus, } =20 static int -virtDBusDomainGetPersistent(sd_bus *bus, +virtDBusDomainGetPersistent(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -158,13 +158,13 @@ virtDBusDomainGetPersistent(sd_bus *bus, } =20 static int -virtDBusDomainGetState(sd_bus *bus, +virtDBusDomainGetState(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -209,13 +209,13 @@ virtDBusDomainGetState(sd_bus *bus, } =20 static int -virtDBusDomainGetAutostart(sd_bus *bus, +virtDBusDomainGetAutostart(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, - const char *property, + const char *interface VIR_ATTR_UNUSED, + const char *property VIR_ATTR_UNUSED, sd_bus_message *reply, void *userdata, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilVirDomainFreep) virDomainPtr domain =3D NULL; @@ -502,12 +502,12 @@ static const sd_bus_vtable virt_domain_vtable[] =3D { }; =20 static int -virtDBusDomainLookup(sd_bus *bus, +virtDBusDomainLookup(sd_bus *bus VIR_ATTR_UNUSED, const char *path, - const char *interface, + const char *interface VIR_ATTR_UNUSED, void *userdata, void **found, - sd_bus_error *error) + sd_bus_error *error VIR_ATTR_UNUSED) { virtDBusManager *manager =3D userdata; _cleanup_(virtDBusUtilFreep) char *name =3D NULL; diff --git a/src/events.c b/src/events.c index f8fe839..731ef02 100644 --- a/src/events.c +++ b/src/events.c @@ -6,10 +6,10 @@ #include =20 static int -virtDBusEventsDomainLifecycle(virConnectPtr connection, +virtDBusEventsDomainLifecycle(virConnectPtr connection VIR_ATTR_UNUSED, virDomainPtr domain, int event, - int detail, + int detail VIR_ATTR_UNUSED, void *opaque) { virtDBusManager *manager =3D opaque; @@ -70,7 +70,7 @@ virtDBusEventsDomainLifecycle(virConnectPtr connection, } =20 static int -virtDBusEventsDomainDeviceAdded(virConnectPtr connection, +virtDBusEventsDomainDeviceAdded(virConnectPtr connection VIR_ATTR_UNUSED, virDomainPtr domain, const char *device, void *opaque) @@ -98,7 +98,7 @@ virtDBusEventsDomainDeviceAdded(virConnectPtr connection, } =20 static int -virtDBusEventsDomainDeviceRemoved(virConnectPtr connection, +virtDBusEventsDomainDeviceRemoved(virConnectPtr connection VIR_ATTR_UNUSED, virDomainPtr domain, const char *device, void *opaque) @@ -126,7 +126,7 @@ virtDBusEventsDomainDeviceRemoved(virConnectPtr connect= ion, } =20 static int -virtDBusEventsDomainDiskChange(virConnectPtr connection, +virtDBusEventsDomainDiskChange(virConnectPtr connection VIR_ATTR_UNUSED, virDomainPtr domain, const char *device, int reason, @@ -168,7 +168,7 @@ virtDBusEventsDomainDiskChange(virConnectPtr connection, } =20 static int -virtDBusEventsDomainTrayChange(virConnectPtr connection, +virtDBusEventsDomainTrayChange(virConnectPtr connection VIR_ATTR_UNUSED, virDomainPtr domain, const char *old_src_path, const char *new_src_path, diff --git a/src/main.c b/src/main.c index db5d4a5..a6a0212 100644 --- a/src/main.c +++ b/src/main.c @@ -55,18 +55,18 @@ virtDBusVirEventRemoveHandlep(int *watchp) } =20 static void -virtDBusHandleSignal(int watch, - int fd, - int events, - void *opaque) +virtDBusHandleSignal(int watch VIR_ATTR_UNUSED, + int fd VIR_ATTR_UNUSED, + int events VIR_ATTR_UNUSED, + void *opaque VIR_ATTR_UNUSED) { loop_status =3D -ECANCELED; } =20 static void virtDBusHandleBusEvent(int watch, - int fd, - int events, + int fd VIR_ATTR_UNUSED, + int events VIR_ATTR_UNUSED, void *opaque) { sd_bus *bus =3D opaque; diff --git a/src/manager.c b/src/manager.c index 77fb4bc..f289a7a 100644 --- a/src/manager.c +++ b/src/manager.c @@ -7,8 +7,8 @@ #include =20 static int -virtDBusManagerEnumarateDomains(sd_bus *bus, - const char *path, +virtDBusManagerEnumarateDomains(sd_bus *bus VIR_ATTR_UNUSED, + const char *path VIR_ATTR_UNUSED, void *userdata, char ***nodes, sd_bus_error *error) diff --git a/src/util.h b/src/util.h index 3c80fef..0c9f3d7 100644 --- a/src/util.h +++ b/src/util.h @@ -6,6 +6,8 @@ #include =20 #define _cleanup_(_x) __attribute__((__cleanup__(_x))) +#define VIR_ATTR_UNUSED __attribute__((__unused__)) + =20 int virtDBusUtilMessageAppendTypedParameters(sd_bus_message *message, --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list