The architecture itself is called ppc64, and it can run both in big
endian and little endian mode - the latter is known as ppc64le.

>From the (virtual) hardware point of view, ppc64 is a more accurate
name so it should be used here.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 .../{qemu_2.6.0.ppc64le.xml => qemu_2.6.0.ppc64.xml}                  | 2 +-
 tests/domaincapstest.c                                                | 2 +-
 .../{caps_2.6.0.ppc64le.replies => caps_2.6.0.ppc64.replies}          | 0
 .../{caps_2.6.0.ppc64le.xml => caps_2.6.0.ppc64.xml}                  | 0
 .../{caps_2.9.0.ppc64le.replies => caps_2.9.0.ppc64.replies}          | 0
 .../{caps_2.9.0.ppc64le.xml => caps_2.9.0.ppc64.xml}                  | 0
 tests/qemucapabilitiestest.c                                          | 4 ++--
 7 files changed, 4 insertions(+), 4 deletions(-)
 rename tests/domaincapsschemadata/{qemu_2.6.0.ppc64le.xml => qemu_2.6.0.ppc64.xml} (98%)
 rename tests/qemucapabilitiesdata/{caps_2.6.0.ppc64le.replies => caps_2.6.0.ppc64.replies} (100%)
 rename tests/qemucapabilitiesdata/{caps_2.6.0.ppc64le.xml => caps_2.6.0.ppc64.xml} (100%)
 rename tests/qemucapabilitiesdata/{caps_2.9.0.ppc64le.replies => caps_2.9.0.ppc64.replies} (100%)
 rename tests/qemucapabilitiesdata/{caps_2.9.0.ppc64le.xml => caps_2.9.0.ppc64.xml} (100%)

diff --git a/tests/domaincapsschemadata/qemu_2.6.0.ppc64le.xml b/tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml
similarity index 98%
rename from tests/domaincapsschemadata/qemu_2.6.0.ppc64le.xml
rename to tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml
index 5b986e52f..98c72d36d 100644
--- a/tests/domaincapsschemadata/qemu_2.6.0.ppc64le.xml
+++ b/tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml
@@ -2,7 +2,7 @@
   <path>/usr/bin/qemu-system-ppc64</path>
   <domain>kvm</domain>
   <machine>pseries-2.6</machine>
-  <arch>ppc64le</arch>
+  <arch>ppc64</arch>
   <vcpu max='255'/>
   <os supported='yes'>
     <loader supported='yes'>
diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c
index b997e6542..76494a01c 100644
--- a/tests/domaincapstest.c
+++ b/tests/domaincapstest.c
@@ -460,7 +460,7 @@ mymain(void)
 
     DO_TEST_QEMU("2.6.0", "caps_2.6.0",
                  "/usr/bin/qemu-system-ppc64", NULL,
-                 "ppc64le", VIR_DOMAIN_VIRT_KVM);
+                 "ppc64", VIR_DOMAIN_VIRT_KVM);
 
     DO_TEST_QEMU("2.8.0", "caps_2.8.0",
                  "/usr/bin/qemu-system-x86_64", NULL,
diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.replies b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.replies
similarity index 100%
rename from tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.replies
rename to tests/qemucapabilitiesdata/caps_2.6.0.ppc64.replies
diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml
similarity index 100%
rename from tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
rename to tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml
diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.replies b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.replies
similarity index 100%
rename from tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.replies
rename to tests/qemucapabilitiesdata/caps_2.9.0.ppc64.replies
diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml
similarity index 100%
rename from tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
rename to tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml
diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c
index 5d198baf4..e2f1cc4cc 100644
--- a/tests/qemucapabilitiestest.c
+++ b/tests/qemucapabilitiestest.c
@@ -175,8 +175,8 @@ mymain(void)
     DO_TEST("aarch64", "caps_2.6.0-gicv3");
     DO_TEST("aarch64", "caps_2.10.0-gicv2");
     DO_TEST("aarch64", "caps_2.10.0-gicv3");
-    DO_TEST("ppc64le", "caps_2.6.0");
-    DO_TEST("ppc64le", "caps_2.9.0");
+    DO_TEST("ppc64", "caps_2.6.0");
+    DO_TEST("ppc64", "caps_2.9.0");
     DO_TEST("s390x", "caps_2.7.0");
     DO_TEST("s390x", "caps_2.8.0");
     DO_TEST("s390x", "caps_2.9.0");
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 11/06/2017 08:26 AM, Andrea Bolognani wrote:
> The architecture itself is called ppc64, and it can run both in big
> endian and little endian mode - the latter is known as ppc64le.
> 
>>From the (virtual) hardware point of view, ppc64 is a more accurate
> name so it should be used here.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .../{qemu_2.6.0.ppc64le.xml => qemu_2.6.0.ppc64.xml}                  | 2 +-
>  tests/domaincapstest.c                                                | 2 +-
>  .../{caps_2.6.0.ppc64le.replies => caps_2.6.0.ppc64.replies}          | 0
>  .../{caps_2.6.0.ppc64le.xml => caps_2.6.0.ppc64.xml}                  | 0
>  .../{caps_2.9.0.ppc64le.replies => caps_2.9.0.ppc64.replies}          | 0
>  .../{caps_2.9.0.ppc64le.xml => caps_2.9.0.ppc64.xml}                  | 0
>  tests/qemucapabilitiestest.c                                          | 4 ++--
>  7 files changed, 4 insertions(+), 4 deletions(-)
>  rename tests/domaincapsschemadata/{qemu_2.6.0.ppc64le.xml => qemu_2.6.0.ppc64.xml} (98%)
>  rename tests/qemucapabilitiesdata/{caps_2.6.0.ppc64le.replies => caps_2.6.0.ppc64.replies} (100%)
>  rename tests/qemucapabilitiesdata/{caps_2.6.0.ppc64le.xml => caps_2.6.0.ppc64.xml} (100%)
>  rename tests/qemucapabilitiesdata/{caps_2.9.0.ppc64le.replies => caps_2.9.0.ppc64.replies} (100%)
>  rename tests/qemucapabilitiesdata/{caps_2.9.0.ppc64le.xml => caps_2.9.0.ppc64.xml} (100%)
> 

So this is just for our tests right?  I guess I see a name change like
this and I think - is there some sort of migrate or save/restore issue
we could have by changing the "name"...

Anyway - I see the the "ppc64" matches the JSON return:

{
  "return": {
    "arch": "ppc64"
  },
  "id": "libvirt-3"
}

So, close my eyes and hope it all works ;-)

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2017-11-07 at 17:47 -0500, John Ferlan wrote:
> So this is just for our tests right?  I guess I see a name change like
> this and I think - is there some sort of migrate or save/restore issue
> we could have by changing the "name"...

Nah, it's pretty much just the names of the files in the test suite
bothering me :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list