[v3] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks

[libvirt] [PATCH v3 00/12] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks

John Ferlan posted 12 patches 7 years, 5 months ago

Diff against v1 v2 v4 v5 v6
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20171207011408.15091-1-jferlan@redhat.com

There is a newer version of this series

src/qemu/qemu_command.c | 497 ++++++++----------------------------------------
src/qemu/qemu_domain.c  | 469 ++++++++++++++++++++++++++++++++++++++++++++-
tests/qemumemlocktest.c |  14 ++
tests/qemuxml2xmltest.c |   5 +-
4 files changed, 564 insertions(+), 421 deletions(-)

Expand all Fold all

[libvirt] [PATCH v3 00/12] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks

Posted by John Ferlan 7 years, 5 months ago

v2:
https://www.redhat.com/archives/libvir-list/2017-December/msg00173.html

Changes since v2:

 * Push a few patches from v1 that were ACK'd

 * Make the Skip helper private to qemu_command.c and just copied
   the various skip checks from the new helper into the specific
   controller validate helper to make it painfully obvious what
   was being skipped rather than having common code handle that
   and possibly obsfuscate those details from the casual reader.



John Ferlan (11):
  qemu: Introduce qemuBuildSkipController
  qemu: Introduce qemuDomainDeviceDefValidateController
  qemu: Move CCW S390 Address check to controller def validate
  qemu: Introduce qemuDomainDeviceDefValidateControllerSCSI
  qemu: Introduce qemuDomainDeviceDefValidateControllerPCI
  qemu: Use virDomainPCIControllerOpts in qemuBuildControllerDevStr
  qemu: Move PCI command modelName check to controller def validate
  qemu: Move PCI command modelName TypeToString to controller def
    validate
  qemu: Move PCI more command checks to controller def validate
  qemu: Complete PCI command checks to controller def validate
  qemu: Introduce qemuDomainDeviceDefValidateControllerSATA

Lin Ma (1):
  qemu: Introduce qemuDomainDeviceDefValidateControllerIDE

 src/qemu/qemu_command.c | 497 ++++++++----------------------------------------
 src/qemu/qemu_domain.c  | 469 ++++++++++++++++++++++++++++++++++++++++++++-
 tests/qemumemlocktest.c |  14 ++
 tests/qemuxml2xmltest.c |   5 +-
 4 files changed, 564 insertions(+), 421 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list