From nobody Thu May 15 01:26:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1513088621025810.6148347668723; Tue, 12 Dec 2017 06:23:41 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 926517EA80; Tue, 12 Dec 2017 14:23:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F0C54F9D4; Tue, 12 Dec 2017 14:23:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1DDD64E565; Tue, 12 Dec 2017 14:23:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id vBCEN2Nb027082 for ; Tue, 12 Dec 2017 09:23:02 -0500 Received: by smtp.corp.redhat.com (Postfix) id 795E670A0D; Tue, 12 Dec 2017 14:23:02 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-108.phx2.redhat.com [10.3.116.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3FCF070A06 for ; Tue, 12 Dec 2017 14:23:02 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 12 Dec 2017 09:22:57 -0500 Message-Id: <20171212142257.21061-4-jferlan@redhat.com> In-Reply-To: <20171212142257.21061-1-jferlan@redhat.com> References: <20171212142257.21061-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/3] util: Report error if vhost-scsi device file cannot be found X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 12 Dec 2017 14:23:39 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1523564 If the vhost-scsi device file cannot be found, the generic error "error: An error occurred, but the cause is unknown" is returned. Let's add a real error message to make it clear why the failure occurred. Signed-off-by: John Ferlan Reviewed-by: Eric Farman --- src/util/virscsivhost.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/virscsivhost.c b/src/util/virscsivhost.c index d6fbf5ed5..5f176e177 100644 --- a/src/util/virscsivhost.c +++ b/src/util/virscsivhost.c @@ -86,8 +86,12 @@ VIR_ONCE_GLOBAL_INIT(virSCSIVHost) int virSCSIVHostOpenVhostSCSI(int *vhostfd) { - if (!virFileExists(VHOST_SCSI_DEVICE)) + if (!virFileExists(VHOST_SCSI_DEVICE)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("vhost-scsi device file '%s' cannot be found"), + VHOST_SCSI_DEVICE); return -1; + } =20 *vhostfd =3D open(VHOST_SCSI_DEVICE, O_RDWR); =20 --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list