[libvirt] [PATCH v3 3/5] util: Print architecture name in /proc/cpuinfo parser

Andrea Bolognani posted 5 patches 7 years, 5 months ago
[libvirt] [PATCH v3 3/5] util: Print architecture name in /proc/cpuinfo parser
Posted by Andrea Bolognani 7 years, 5 months ago
Instead of a generic "your architecture", print the actual
architecture name.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/Makefile.am       | 1 +
 src/util/virhostcpu.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 4c022d1e4..166c9a8e9 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -2477,6 +2477,7 @@ noinst_LTLIBRARIES += libvirt-setuid-rpc-client.la
 
 libvirt_setuid_rpc_client_la_SOURCES = \
 		util/viralloc.c \
+		util/virarch.c \
 		util/viratomic.c \
 		util/viratomic.h \
 		util/virbitmap.c \
diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
index d47062013..3c20755eb 100644
--- a/src/util/virhostcpu.c
+++ b/src/util/virhostcpu.c
@@ -554,7 +554,8 @@ virHostCPUParseFrequency(FILE *cpuinfo,
         prefix = "BogoMIPS";
 
     if (!prefix) {
-        VIR_WARN("Your architecture is not supported by the %s parser",
+        VIR_WARN("%s is not supported by the %s parser",
+                 virArchToString(arch),
                  CPUINFO_PATH);
         return 1;
     }
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v3 3/5] util: Print architecture name in /proc/cpuinfo parser
Posted by Bjoern Walk 7 years, 5 months ago
Andrea Bolognani <abologna@redhat.com> [2017-12-14, 01:33PM +0100]:
> Instead of a generic "your architecture", print the actual
> architecture name.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/Makefile.am       | 1 +
>  src/util/virhostcpu.c | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 4c022d1e4..166c9a8e9 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -2477,6 +2477,7 @@ noinst_LTLIBRARIES += libvirt-setuid-rpc-client.la
> 
>  libvirt_setuid_rpc_client_la_SOURCES = \
>  		util/viralloc.c \
> +		util/virarch.c \
>  		util/viratomic.c \
>  		util/viratomic.h \
>  		util/virbitmap.c \
> diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
> index d47062013..3c20755eb 100644
> --- a/src/util/virhostcpu.c
> +++ b/src/util/virhostcpu.c
> @@ -554,7 +554,8 @@ virHostCPUParseFrequency(FILE *cpuinfo,
>          prefix = "BogoMIPS";
> 
>      if (!prefix) {
> -        VIR_WARN("Your architecture is not supported by the %s parser",
> +        VIR_WARN("%s is not supported by the %s parser",
> +                 virArchToString(arch),
>                   CPUINFO_PATH);
>          return 1;
>      }
> -- 
> 2.14.3
> 

Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>

> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

-- 
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk@de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list