From: Chen Hanxiao <chenhanxiao@gmail.com>

We don't have @result. Use the right one: @matches

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 src/util/virstring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virstring.c b/src/util/virstring.c
index b2ebce27f..0cb06bdc9 100644
--- a/src/util/virstring.c
+++ b/src/util/virstring.c
@@ -1038,7 +1038,7 @@ int virStringSortRevCompare(const void *a, const void *b)
  * @str: string to search
  * @regexp: POSIX Extended regular expression pattern used for matching
  * @max_matches: maximum number of substrings to return
- * @result: pointer to an array to be filled with NULL terminated list of matches
+ * @matches: pointer to an array to be filled with NULL terminated list of matches
  *
  * Performs a POSIX extended regex search against a string and return all matching substrings.
  * The @result value should be freed with virStringListFree() when no longer
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sat, Dec 23, 2017 at 05:49:08PM +0800, Chen Hanxiao wrote:
>From: Chen Hanxiao <chenhanxiao@gmail.com>
>
>We don't have @result. Use the right one: @matches
>
>Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>---
> src/util/virstring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/util/virstring.c b/src/util/virstring.c
>index b2ebce27f..0cb06bdc9 100644
>--- a/src/util/virstring.c
>+++ b/src/util/virstring.c
>@@ -1038,7 +1038,7 @@ int virStringSortRevCompare(const void *a, const void *b)
>  * @str: string to search
>  * @regexp: POSIX Extended regular expression pattern used for matching
>  * @max_matches: maximum number of substrings to return
>- * @result: pointer to an array to be filled with NULL terminated list of matches
>+ * @matches: pointer to an array to be filled with NULL terminated list of matches
>  *
>  * Performs a POSIX extended regex search against a string and return all matching substrings.
>  * The @result value should be freed with virStringListFree() when no longer

The same old variable name is referenced here in the context.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

At 2018-01-03 17:46:02, "Ján Tomko" <jtomko@redhat.com> wrote:
>On Sat, Dec 23, 2017 at 05:49:08PM +0800, Chen Hanxiao wrote:
>>From: Chen Hanxiao <chenhanxiao@gmail.com>
>>
>>We don't have @result. Use the right one: @matches
>>
>>Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
>>---
>> src/util/virstring.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/src/util/virstring.c b/src/util/virstring.c
>>index b2ebce27f..0cb06bdc9 100644
>>--- a/src/util/virstring.c
>>+++ b/src/util/virstring.c
>>@@ -1038,7 +1038,7 @@ int virStringSortRevCompare(const void *a, const void *b)
>>  * @str: string to search
>>  * @regexp: POSIX Extended regular expression pattern used for matching
>>  * @max_matches: maximum number of substrings to return
>>- * @result: pointer to an array to be filled with NULL terminated list of matches
>>+ * @matches: pointer to an array to be filled with NULL terminated list of matches
>>  *
>>  * Performs a POSIX extended regex search against a string and return all matching substrings.
>>  * The @result value should be freed with virStringListFree() when no longer
>
>The same old variable name is referenced here in the context.
>

Sorry for that uncompleted fix.
Will be fixed soon.

Regards,
- Chen

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sat, Dec 23, 2017 at 05:49:08PM +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
>
> We don't have @result. Use the right one: @matches
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>

I slightly adjusted the commit message, but

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list