[libvirt] [PATCH 3/3] rpc: fix non-NULL annotations when GNUTLS is disabled

Daniel P. Berrangé posted 3 patches 7 years, 3 months ago
[libvirt] [PATCH 3/3] rpc: fix non-NULL annotations when GNUTLS is disabled
Posted by Daniel P. Berrangé 7 years, 3 months ago
The position of various parameters changes depending on the WITH_GNUTLS
macro.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/rpc/virnetserverclient.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/rpc/virnetserverclient.h b/src/rpc/virnetserverclient.h
index 4a0d3cc25e..1a939ad4e1 100644
--- a/src/rpc/virnetserverclient.h
+++ b/src/rpc/virnetserverclient.h
@@ -73,7 +73,11 @@ virNetServerClientPtr virNetServerClientNew(unsigned long long id,
                                             virNetServerClientPrivPreExecRestart privPreExecRestart,
                                             virFreeCallback privFree,
                                             void *privOpaque)
+# ifdef WITH_GNUTLS
     ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(7) ATTRIBUTE_NONNULL(9);
+# else
+    ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(6) ATTRIBUTE_NONNULL(8);
+# endif
 
 virNetServerClientPtr virNetServerClientNewPostExecRestart(virNetServerPtr srv,
                                                            virJSONValuePtr object,
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 3/3] rpc: fix non-NULL annotations when GNUTLS is disabled
Posted by John Ferlan 7 years, 3 months ago

On 02/01/2018 10:35 AM, Daniel P. Berrangé wrote:
> The position of various parameters changes depending on the WITH_GNUTLS
> macro.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/rpc/virnetserverclient.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list