From nobody Wed Dec 17 04:05:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1518423368934685.1094592157069; Mon, 12 Feb 2018 00:16:08 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6026BC05686E; Mon, 12 Feb 2018 08:16:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 154C360BF0; Mon, 12 Feb 2018 08:16:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A85254A46D; Mon, 12 Feb 2018 08:16:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1C8Foaa020294 for ; Mon, 12 Feb 2018 03:15:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1864F5D997; Mon, 12 Feb 2018 08:15:50 +0000 (UTC) Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1196B5D996 for ; Mon, 12 Feb 2018 08:15:50 +0000 (UTC) Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C533D2D1EE6 for ; Mon, 12 Feb 2018 08:15:48 +0000 (UTC) Received: by mail-it0-f68.google.com with SMTP id u12so5521072ite.0 for ; Mon, 12 Feb 2018 00:15:48 -0800 (PST) Received: from linux-8bx1.caveonetworks.com ([115.113.156.2]) by smtp.googlemail.com with ESMTPSA id s70sm6742882itb.0.2018.02.12.00.15.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Feb 2018 00:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jA4++WQT3aWzzePqnbmuvLTli3cRtyuiNmXoy8oVSfs=; b=ILdjHJCik6a1psP6QdYDwN4s8y68HiW71OANxrpbYw0vsi/3UmFpUlvCy9LBWZHbsY O2mIsXXgbqbNGfplzxJGNXtlf5UWH7UmhZ1h/LfkvdJ2f609cZSNzyRyDImKoUCPECN2 lSnYY7ekrVmKNY3cq9SPPqIWr/nORt6u0sxR9FMu2ZfpTIoQyhzdsVWC7cxwO0UR5eKE xnXmCzjgvguMGop16q4/Q/LicOLD5WmE6a7CbBfLSfemU+L456QNjFpK4GrQhtQ32Mv0 iXH/begI+EQxRvBOhf9jtpZ5d0WmdEBW6uNh0YDF9RdRC6i0cTgwtdwT9GlJmzFFGhYE Rn3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jA4++WQT3aWzzePqnbmuvLTli3cRtyuiNmXoy8oVSfs=; b=W0ioK0kbv9GMrGZPmOUF+cu99PqlUkW48bg9La3r/tt/x3+Xx2fAQuzfMwo1RvlU8L E0QiAjX4NOKKyPy/9TPaqJSDjf39ZYQn0Tj7QM6tGBwP1bMqcdels60FFGggXLwYNsWD 3pMmLR1BUJ8RkO6bausXctSMF6KgOT5IdXRXn/nBJJlfDP0+w2byrzRcyBrIdFZZIeUU GbvY8+zuqwWErtMNxKriVpBb6a0EDOT9WssvGYmW+tbSs+BdI/I9qFkJmPG+c+A82LhT zSy3FWDtPutvXU7Qdk5xy8A02YukB8nFGpAdOYuVwzbAbIZpGyzoeIe0I20EdvptLXDr himQ== X-Gm-Message-State: APf1xPC7ZrkODYHWQ048TRSHMW/dXUGBrWlRgM6Fvm6reRdFPnueiU90 kdTjGRRqz6rEGKW71mcs1n0lRQ== X-Google-Smtp-Source: AH8x2250cCT+pbZymgbph2Ti6NP2ZdJua6ieTCvceKq82NvFBUO2PqjiY1iylzSrSyBnKzePQNUAtw== X-Received: by 10.36.212.69 with SMTP id x66mr4575023itg.18.1518423347944; Mon, 12 Feb 2018 00:15:47 -0800 (PST) From: Jai Singh Rana X-Google-Original-From: Jai Singh Rana To: libvir-list@redhat.com Date: Mon, 12 Feb 2018 13:37:55 +0530 Message-Id: <20180212080755.12523-3-JaiSingh.Rana@cavium.com> In-Reply-To: <20180212080755.12523-1-JaiSingh.Rana@cavium.com> References: <20180212080755.12523-1-JaiSingh.Rana@cavium.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 12 Feb 2018 08:15:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 12 Feb 2018 08:15:48 +0000 (UTC) for IP:'209.85.214.68' DOMAIN:'mail-it0-f68.google.com' HELO:'mail-it0-f68.google.com' FROM:'jai.rana@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.214.68 mail-it0-f68.google.com 209.85.214.68 mail-it0-f68.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.29 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Jai Singh Rana Subject: [libvirt] [PATCH v2 2/2] qemu: conf: Network stats support for hostdev VF Representor X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 12 Feb 2018 08:16:07 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In case of , return stats if its a Switchdev VF Representor interface of pci SR-IOV device. --- v2 fixes bracket spacing in domain_conf.c src/conf/domain_conf.c | 7 +++++++ src/qemu/qemu_driver.c | 34 ++++++++++++++++++++++++++++++---- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index fb732a0c2..b553c5a2f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -58,6 +58,7 @@ #include "virnetdev.h" #include "virnetdevmacvlan.h" #include "virhostdev.h" +#include "virnetdevhostdev.h" #include "virmdev.h" =20 #define VIR_FROM_THIS VIR_FROM_DOMAIN @@ -28112,6 +28113,12 @@ virDomainNetFind(virDomainDefPtr def, const char *= device) return net; } =20 + /* Give a try to hostdev */ + for (i =3D 0; i < def->nnets; i++) { + if (!virNetdevHostdevCheckVFRepIFName(def->hostdevs[i], device)) + return def->nets[i]; + } + virReportError(VIR_ERR_INVALID_ARG, _("'%s' is not a known interface"), device); return NULL; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bbce5bd81..24484ab92 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -67,6 +67,7 @@ #include "virhostcpu.h" #include "virhostmem.h" #include "virnetdevtap.h" +#include "virnetdevhostdev.h" #include "virnetdevopenvswitch.h" #include "capabilities.h" #include "viralloc.h" @@ -11153,6 +11154,11 @@ qemuDomainInterfaceStats(virDomainPtr dom, if (virDomainNetGetActualType(net) =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUSE= R) { if (virNetDevOpenvswitchInterfaceStats(net->ifname, stats) < 0) goto cleanup; + } else if (virDomainNetGetActualType(net) =3D=3D VIR_DOMAIN_NET_TYPE_H= OSTDEV) { + if (virNetdevHostdevVFRepInterfaceStats(device, stats, + !virDomainNetTypeSharesHos= tView + (net)) < 0) + goto cleanup; } else { if (virNetDevTapInterfaceStats(net->ifname, stats, !virDomainNetTypeSharesHostView(net= )) < 0) @@ -19794,6 +19800,7 @@ qemuDomainGetStatsInterface(virQEMUDriverPtr driver= ATTRIBUTE_UNUSED, { size_t i; struct _virDomainInterfaceStats tmp; + char *vf_representor_ifname =3D NULL; int ret =3D -1; =20 if (!virDomainObjIsActive(dom)) @@ -19806,21 +19813,40 @@ qemuDomainGetStatsInterface(virQEMUDriverPtr driv= er ATTRIBUTE_UNUSED, virDomainNetDefPtr net =3D dom->def->nets[i]; virDomainNetType actualType; =20 - if (!net->ifname) + actualType =3D virDomainNetGetActualType(net); + + if (actualType =3D=3D VIR_DOMAIN_NET_TYPE_HOSTDEV) { + if (virNetdevHostdevGetVFRepIFName(dom->def->hostdevs[i], + &vf_representor_ifname)) + continue; + } + else if (!net->ifname) continue; =20 memset(&tmp, 0, sizeof(tmp)); =20 - actualType =3D virDomainNetGetActualType(net); =20 - QEMU_ADD_NAME_PARAM(record, maxparams, - "net", "name", i, net->ifname); + if (actualType !=3D VIR_DOMAIN_NET_TYPE_HOSTDEV) + QEMU_ADD_NAME_PARAM(record, maxparams, + "net", "name", i, net->ifname); + else + QEMU_ADD_NAME_PARAM(record, maxparams, + "net", "name", i, vf_representor_ifname); =20 if (actualType =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUSER) { if (virNetDevOpenvswitchInterfaceStats(net->ifname, &tmp) < 0)= { virResetLastError(); continue; } + } else if (actualType =3D=3D VIR_DOMAIN_NET_TYPE_HOSTDEV) { + if (virNetdevHostdevVFRepInterfaceStats + (vf_representor_ifname, &tmp, + !virDomainNetTypeSharesHostView(net)) < 0) { + VIR_FREE(vf_representor_ifname); + virResetLastError(); + continue; + } + VIR_FREE(vf_representor_ifname); } else { if (virNetDevTapInterfaceStats(net->ifname, &tmp, !virDomainNetTypeSharesHostView= (net)) < 0) { --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list