Enforce presence of all switch enum cases

[libvirt] [PATCH v2 11/14] security: handle missing switch enum cases

Posted by Daniel P. Berrangé 7 years, 2 months ago

Ensure all enum cases are listed in switch statements.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/security/security_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/security/security_driver.c b/src/security/security_driver.c
index 4800d5255a..a845dc7995 100644
--- a/src/security/security_driver.c
+++ b/src/security/security_driver.c
@@ -82,6 +82,7 @@ virSecurityDriverPtr virSecurityDriverLookup(const char *name,
             }
             break;
 
+        case SECURITY_DRIVER_ERROR:
         default:
             return NULL;
         }
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 11/14] security: handle missing switch enum cases

Posted by John Ferlan 7 years, 2 months ago


On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote:
> Ensure all enum cases are listed in switch statements.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/security/security_driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list