From nobody Wed May 14 18:21:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1519812890592719.5375453310866; Wed, 28 Feb 2018 02:14:50 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 452D1C0587D2; Wed, 28 Feb 2018 10:14:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8F0D5E1C3; Wed, 28 Feb 2018 10:14:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B21614A479; Wed, 28 Feb 2018 10:14:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1SAEiZg005619 for ; Wed, 28 Feb 2018 05:14:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id AC3932024CA8; Wed, 28 Feb 2018 10:14:44 +0000 (UTC) Received: from t460.redhat.com (unknown [10.33.36.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CB902024CA6; Wed, 28 Feb 2018 10:14:43 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 28 Feb 2018 10:14:25 +0000 Message-Id: <20180228101435.464-8-berrange@redhat.com> In-Reply-To: <20180228101435.464-1-berrange@redhat.com> References: <20180228101435.464-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 07/17] make: split remote driver & daemon build rules into remote/Makefile.inc.am X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 28 Feb 2018 10:14:49 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Signed-off-by: Daniel P. Berrang=C3=A9 --- src/Makefile.am | 349 +++--------------------------------------= ---- src/remote/Makefile.inc.am | 342 +++++++++++++++++++++++++++++++++++++++++= +++ 2 files changed, 365 insertions(+), 326 deletions(-) create mode 100644 src/remote/Makefile.inc.am diff --git a/src/Makefile.am b/src/Makefile.am index 8d0780d25e..bbfd3b0427 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -81,6 +81,15 @@ tapset_DATA =3D endif WITH_DTRACE_PROBES libexec_PROGRAMS =3D RPC_PROBE_FILES =3D +LOGROTATE_FILES_IN =3D +PODFILES =3D +MANINFILES =3D +SYSTEMD_UNIT_FILES_IN =3D +SYSVINIT_FILES_IN =3D +UPSTART_FILES =3D +SYSCONF_FILES =3D +sbin_PROGRAMS =3D +man8_MANS =3D =20 include uml/Makefile.inc.am include phyp/Makefile.inc.am @@ -104,6 +113,7 @@ include nwfilter/Makefile.inc.am include node_device/Makefile.inc.am include secret/Makefile.inc.am include storage/Makefile.inc.am +include remote/Makefile.inc.am =20 =20 THREAD_LIBS =3D $(LIB_PTHREAD) $(LTLIBMULTITHREAD) @@ -123,7 +133,6 @@ endif WITH_SECDRIVER_APPARMOR lib_LTLIBRARIES =3D libvirt.la libvirt-qemu.la libvirt-lxc.la =20 moddir =3D $(libdir)/libvirt/connection-driver -sbin_PROGRAMS =3D =20 confdir =3D $(sysconfdir)/libvirt conf_DATA +=3D libvirt.conf libvirt-admin.conf @@ -538,81 +547,6 @@ CONF_SOURCES =3D \ $(CHRDEV_CONF_SOURCES) \ $(DEVICE_CONF_SOURCES) =20 -# The remote RPC driver, covering domains, storage, networks, etc -REMOTE_DRIVER_GENERATED =3D \ - remote/remote_protocol.c \ - remote/remote_protocol.h \ - remote/remote_client_bodies.h \ - remote/lxc_protocol.c \ - remote/lxc_protocol.h \ - remote/lxc_client_bodies.h \ - remote/qemu_protocol.c \ - remote/qemu_protocol.h \ - remote/qemu_client_bodies.h \ - $(NULL) - -REMOTE_PROTOCOL =3D $(srcdir)/remote/remote_protocol.x -LXC_PROTOCOL =3D $(srcdir)/remote/lxc_protocol.x -QEMU_PROTOCOL =3D $(srcdir)/remote/qemu_protocol.x -REMOTE_DRIVER_PROTOCOL =3D $(REMOTE_PROTOCOL) $(QEMU_PROTOCOL) $(LXC_PROTO= COL) - -remote/remote_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \ - $(REMOTE_PROTOCOL) Makefile.am - $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \ - remote REMOTE $(REMOTE_PROTOCOL) \ - > $(srcdir)/remote/remote_client_bodies.h - -remote/lxc_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \ - $(LXC_PROTOCOL) Makefile.am - $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \ - lxc LXC $(LXC_PROTOCOL) \ - > $(srcdir)/remote/lxc_client_bodies.h - -remote/qemu_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \ - $(QEMU_PROTOCOL) Makefile.am - $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \ - qemu QEMU $(QEMU_PROTOCOL) \ - > $(srcdir)/remote/qemu_client_bodies.h - -remote/remote_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \ - $(REMOTE_PROTOCOL) Makefile.am - $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ - --mode=3Dserver remote REMOTE $(REMOTE_PROTOCOL) \ - > $(srcdir)/remote/remote_daemon_dispatch_stubs.h - -remote/remote_daemon_dispatch_lxc_stubs.h: $(srcdir)/rpc/gendispatch.pl \ - $(LXC_PROTOCOL) Makefile.am - $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ - --mode=3Dserver lxc LXC $(LXC_PROTOCOL) \ - > $(srcdir)/remote/remote_daemon_dispatch_lxc_stubs.h - -remote/remote_daemon_dispatch_qemu_stubs.h: $(srcdir)/rpc/gendispatch.pl \ - $(QEMU_PROTOCOL) Makefile.am - $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ - --mode=3Dserver qemu QEMU $(QEMU_PROTOCOL) \ - > $(srcdir)/remote/remote_daemon_dispatch_qemu_stubs.h - -REMOTE_DRIVER_SOURCES =3D \ - remote/remote_driver.c remote/remote_driver.h \ - $(REMOTE_DRIVER_GENERATED) - -LIBVIRTD_GENERATED =3D \ - remote/remote_daemon_dispatch_stubs.h \ - remote/remote_daemon_dispatch_lxc_stubs.h \ - remote/remote_daemon_dispatch_qemu_stubs.h \ - $(NULL) - -LIBVIRTD_SOURCES =3D \ - remote/remote_daemon.c remote/remote_daemon.h \ - remote/remote_daemon_config.c remote/remote_daemon_config.h \ - remote/remote_daemon_dispatch.c remote/remote_daemon_dispatch.h \ - remote/remote_daemon_stream.c remote/remote_daemon_stream.h \ - $(LIBVIRTD_GENERATED) - -EXTRA_DIST +=3D $(REMOTE_DRIVER_PROTOCOL) \ - $(REMOTE_DRIVER_GENERATED) \ - $(LIBVIRTD_SOURCES) \ - $(NULL) =20 ADMIN_PROTOCOL =3D $(srcdir)/admin/admin_protocol.x =20 @@ -783,10 +717,6 @@ check-drivername: =20 EXTRA_DIST +=3D check-drivername.pl =20 -DRIVER_SOURCE_FILES +=3D \ - $(REMOTE_DRIVER_SOURCES) \ - $(NULL) - check-driverimpls: $(AM_V_GEN)$(PERL) $(srcdir)/check-driverimpls.pl \ $(filter /%,$(DRIVER_SOURCE_FILES)) \ @@ -951,105 +881,7 @@ GENERATED_SYM_FILES +=3D \ libvirt_admin.syms libvirt_admin.def \ $(NULL) =20 -if WITH_REMOTE -noinst_LTLIBRARIES +=3D libvirt_driver_remote.la -libvirt_la_BUILT_LIBADD +=3D libvirt_driver_remote.la -libvirt_driver_remote_la_CFLAGS =3D \ - $(XDR_CFLAGS) \ - -I$(srcdir)/conf \ - -I$(srcdir)/rpc \ - $(AM_CFLAGS) -libvirt_driver_remote_la_LDFLAGS =3D $(AM_LDFLAGS) -libvirt_driver_remote_la_SOURCES =3D $(REMOTE_DRIVER_SOURCES) - -BUILT_SOURCES +=3D $(REMOTE_DRIVER_GENERATED) =20 -endif WITH_REMOTE - - -if WITH_LIBVIRTD - -sbin_PROGRAMS +=3D libvirtd - -BUILT_SOURCES +=3D $(LIBVIRTD_GENERATED) - -augeas_DATA +=3D remote/libvirtd.aug - -augeastest_DATA +=3D test_libvirtd.aug - -conf_DATA +=3D remote/libvirtd.conf - -CLEANFILES +=3D test_libvirtd.aug - -if WITH_POLKIT -if WITH_POLKIT0 -policydir =3D $(datadir)/PolicyKit/policy -policyauth =3D auth_admin_keep_session -else ! WITH_POLKIT0 -policydir =3D $(datadir)/polkit-1/actions -policyauth =3D auth_admin_keep -endif ! WITH_POLKIT0 -endif WITH_POLKIT - -BUILT_SOURCES +=3D libvirtd.policy -CLEANFILES +=3D libvirtd.policy - -libvirtd.policy: remote/libvirtd.policy.in $(top_builddir)/config.status - $(AM_V_GEN) sed \ - -e 's|[@]authaction[@]|$(policyauth)|g' \ - < $< > $@-t && \ - mv $@-t $@ - -libvirtd_SOURCES =3D $(LIBVIRTD_SOURCES) - -libvirtd_CFLAGS =3D \ - $(LIBXML_CFLAGS) $(GNUTLS_CFLAGS) $(SASL_CFLAGS) \ - $(XDR_CFLAGS) $(DBUS_CFLAGS) $(LIBNL_CFLAGS) \ - $(WARN_CFLAGS) $(PIE_CFLAGS) \ - $(COVERAGE_CFLAGS) \ - -I$(srcdir)/access \ - -I$(srcdir)/conf \ - -I$(srcdir)/rpc \ - $(NULL) - -libvirtd_LDFLAGS =3D \ - $(RELRO_LDFLAGS) \ - $(PIE_LDFLAGS) \ - $(COVERAGE_LDFLAGS) \ - $(NO_INDIRECT_LDFLAGS) \ - $(NO_UNDEFINED_LDFLAGS) \ - $(NULL) - -libvirtd_LDADD =3D \ - $(LIBXML_LIBS) \ - $(GNUTLS_LIBS) \ - $(SASL_LIBS) \ - $(DBUS_LIBS) \ - $(LIBNL_LIBS) \ - $(NULL) - -if WITH_DTRACE_PROBES -libvirtd_LDADD +=3D ../src/libvirt_probes.lo -endif WITH_DTRACE_PROBES - -libvirtd_LDADD +=3D \ - libvirt_driver_admin.la \ - libvirt-lxc.la \ - libvirt-qemu.la \ - libvirt.la \ - ../gnulib/lib/libgnu.la $(LIBSOCKET) \ - $(NULL) - -endif WITH_LIBVIRTD -EXTRA_DIST +=3D \ - remote/test_libvirtd.aug.in \ - remote/libvirtd.aug \ - remote/libvirtd.conf \ - remote/libvirtd.policy.in \ - remote/libvirtd.rules \ - remote/libvirtd.sasl \ - remote/libvirtd.sysctl \ - $(NULL) =20 %protocol.c: %protocol.x %protocol.h $(srcdir)/rpc/genprotocol.pl $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/genprotocol.pl $(RPCGEN) -c \ @@ -1174,7 +1006,6 @@ access/viraccessapichecklxc.c: $(srcdir)/rpc/gendispa= tch.pl \ =20 # Add all conditional sources just in case... EXTRA_DIST +=3D \ - $(REMOTE_DRIVER_SOURCES) \ $(SECURITY_DRIVER_SELINUX_SOURCES) \ $(SECURITY_DRIVER_APPARMOR_SOURCES) \ $(ACCESS_DRIVER_POLKIT_POLICY) @@ -1184,13 +1015,12 @@ check-local: check-augeas .PHONY: check-augeas \ check-augeas-sanlock \ check-augeas-lockd \ - check-augeas-libvirtd \ $(NULL) =20 check-augeas: $(AUGEAS_DIRS:%=3Dcheck-augeas-%) \ check-augeas-sanlock \ check-augeas-lockd check-augeas-virtlockd \ - check-augeas-virtlogd check-augeas-libvirtd + check-augeas-virtlogd =20 AUG_GENTEST =3D $(PERL) $(top_srcdir)/build-aux/augeas-gentest.pl EXTRA_DIST +=3D $(top_srcdir)/build-aux/augeas-gentest.pl @@ -1245,18 +1075,6 @@ check-augeas-virtlogd: test_virtlogd.aug '$(AUGPARSE)' -I $(srcdir)/logging test_virtlogd.aug; \ fi =20 -if WITH_LIBVIRTD -test_libvirtd.aug: remote/test_libvirtd.aug.in \ - remote/libvirtd.conf $(AUG_GENTEST) - $(AM_V_GEN)$(AUG_GENTEST) $(srcdir)/remote/libvirtd.conf $< $@ - -check-augeas-libvirtd: test_libvirtd.aug - $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ - '$(AUGPARSE)' -I $(srcdir)/remote test_libvirtd.aug; \ - fi -else ! WITH_LIBVIRTD -check-augeas-libvirtd: -endif ! WITH_LIBVIRTD # # Build our version script. This is composed of three parts: # @@ -1284,12 +1102,6 @@ else ! WITH_LINUX SYM_FILES +=3D $(srcdir)/libvirt_linux.syms endif ! WITH_LINUX =20 -if WITH_REMOTE -USED_SYM_FILES +=3D $(srcdir)/libvirt_remote.syms -else ! WITH_REMOTE -SYM_FILES +=3D $(srcdir)/libvirt_remote.syms -endif ! WITH_REMOTE - if WITH_VMX USED_SYM_FILES +=3D $(srcdir)/libvirt_vmx.syms else ! WITH_VMX @@ -1732,10 +1544,9 @@ EXTRA_DIST +=3D $(LOCK_DAEMON_SOURCES) \ $(LOG_DAEMON_SOURCES) endif ! WITH_LIBVIRTD =20 -SYSCONF_FILES =3D \ +SYSCONF_FILES +=3D \ locking/virtlockd.sysconf \ logging/virtlogd.sysconf \ - remote/libvirtd.sysconf \ $(NULL) =20 EXTRA_DIST +=3D \ @@ -1762,30 +1573,19 @@ uninstall-sysconfig: done rmdir $(DESTDIR)$(sysconfdir)/sysconfig || : =20 -SYSVINIT_FILES_IN =3D \ +SYSVINIT_FILES_IN +=3D \ locking/virtlockd.init.in \ logging/virtlogd.init.in \ - remote/libvirtd.init.in \ $(NULL) =20 SYSVINIT_FILES =3D $(notdir $(SYSVINIT_FILES_IN:%.in=3D%)) =20 EXTRA_DIST +=3D $(SYSVINIT_FILES_IN) =20 -LOGROTATE_FILES_IN =3D \ - remote/libvirtd.qemu.logrotate.in \ - remote/libvirtd.lxc.logrotate.in \ - remote/libvirtd.libxl.logrotate.in \ - remote/libvirtd.uml.logrotate.in \ - remote/libvirtd.logrotate.in \ - $(NULL) +LOGROTATE_FILES :=3D $(LOGROTATE_FILES_IN:remote/%.in=3D%) =20 EXTRA_DIST +=3D $(LOGROTATE_FILES_IN) =20 -if WITH_LIBVIRTD - -LOGROTATE_FILES :=3D $(LOGROTATE_FILES_IN:remote/%.in=3D%) - BUILT_SOURCES +=3D $(LOGROTATE_FILES) CLEANFILES +=3D $(LOGROTATE_FILES) =20 @@ -1795,6 +1595,7 @@ CLEANFILES +=3D $(LOGROTATE_FILES) < $< > $@-t && \ mv $@-t $@ =20 +if WITH_LIBVIRTD install-logrotate: $(LOGROTATE_FILES) $(MKDIR_P) $(DESTDIR)$(sysconfdir)/logrotate.d/ for f in $(LOGROTATE_FILES) ; \ @@ -1807,45 +1608,10 @@ install-logrotate: $(LOGROTATE_FILES) uninstall-logrotate: rm -f $(LOGROTATE_FILES:%.logrotate=3D$(DESTDIR)$(sysconfdir)/logrotate.d= /%) rmdir $(DESTDIR)$(sysconfdir)/logrotate.d || : - -if WITH_SYSCTL -# Use $(prefix)/lib rather than $(libdir), since man sysctl.d insists on -# /usr/lib/sysctl.d/ even when libdir is /usr/lib64 -install-sysctl: - $(MKDIR_P) $(DESTDIR)$(prefix)/lib/sysctl.d - $(INSTALL_DATA) $(srcdir)/remote/libvirtd.sysctl \ - $(DESTDIR)$(prefix)/lib/sysctl.d/60-libvirtd.conf - -uninstall-sysctl: - rm -f $(DESTDIR)$(prefix)/lib/sysctl.d/60-libvirtd.conf - rmdir $(DESTDIR)$(prefix)/lib/sysctl.d || : -else ! WITH_SYSCTL -install-sysctl: -uninstall-sysctl: -endif ! WITH_SYSCTL - -if WITH_POLKIT -install-polkit:: - $(MKDIR_P) $(DESTDIR)$(policydir) - $(INSTALL_DATA) libvirtd.policy $(DESTDIR)$(policydir)/org.libvirt.unix.p= olicy -if ! WITH_POLKIT0 - $(MKDIR_P) $(DESTDIR)$(datadir)/polkit-1/rules.d - $(INSTALL_DATA) $(srcdir)/remote/libvirtd.rules \ - $(DESTDIR)$(datadir)/polkit-1/rules.d/50-libvirt.rules -endif ! WITH_POLKIT0 - -uninstall-polkit:: - rm -f $(DESTDIR)$(policydir)/org.libvirt.unix.policy - rmdir $(DESTDIR)$(policydir) || : -if ! WITH_POLKIT0 - rm -f $(DESTDIR)$(datadir)/polkit-1/rules.d/50-libvirt.rules - rmdir $(DESTDIR)$(datadir)/polkit-1/rules.d || : -endif ! WITH_POLKIT0 - -else ! WITH_POLKIT -install-polkit:: -uninstall-polkit:: -endif ! WITH_POLKIT +else ! WITH_LIBVIRTD +install-logrotate: +uninstall-logrotate: +endif ! WITH_LIBVIRTD =20 if LIBVIRT_INIT_SCRIPT_RED_HAT install-init:: $(SYSVINIT_FILES) install-sysconfig @@ -1865,42 +1631,7 @@ else ! LIBVIRT_INIT_SCRIPT_RED_HAT install-init:: uninstall-init:: endif ! LIBVIRT_INIT_SCRIPT_RED_HAT -else ! WITH_LIBVIRTD -install-polkit:: -uninstall-polkit:: -install-sysctl:: -uninstall-sysctl:: -install-init:: -uninstall-init:: -install-logrotate:: -uninstall-logrotate:: -endif ! WITH_LIBVIRTD - -# This is needed for clients too, so can't wrap in -# the WITH_LIBVIRTD conditional -if WITH_SASL -install-sasl: - $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sasl2/ - $(INSTALL_DATA) $(srcdir)/remote/libvirtd.sasl \ - $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf - -uninstall-sasl: - rm -f $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf - rmdir $(DESTDIR)$(sysconfdir)/sasl2/ || : -else ! WITH_SASL -install-sasl: -uninstall-sasl: -endif ! WITH_SASL - =20 -libvirtd.init: remote/libvirtd.init.in $(top_builddir)/config.status - $(AM_V_GEN)sed \ - -e 's|[@]localstatedir[@]|$(localstatedir)|g' \ - -e 's|[@]sbindir[@]|$(sbindir)|g' \ - -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ - < $< > $@-t && \ - chmod a+x $@-t && \ - mv $@-t $@ =20 virtlockd.init: locking/virtlockd.init.in $(top_builddir)/config.status $(AM_V_GEN)sed \ @@ -1940,16 +1671,6 @@ virtlogd.8.in: logging/virtlogd.pod rm -f $@-t1 && \ mv $@-t2 $@ =20 -libvirtd.8.in: remote/libvirtd.pod - $(AM_V_GEN)$(POD2MAN) --section=3D8 $< $@-t1 && \ - if grep 'POD ERROR' $@-t1; then rm $@-t1; exit 1; fi && \ - sed \ - -e 's|SYSCONFDIR|\@sysconfdir\@|g' \ - -e 's|LOCALSTATEDIR|\@localstatedir\@|g' \ - < $@-t1 > $@-t2 && \ - rm -f $@-t1 && \ - mv $@-t2 $@ - %.8: %.8.in $(top_srcdir)/configure.ac $(AM_V_GEN)sed \ -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ @@ -1958,7 +1679,7 @@ libvirtd.8.in: remote/libvirtd.pod mv $@-t $@ =20 if WITH_LIBVIRTD -man8_MANS =3D virtlockd.8 virtlogd.8 libvirtd.8 +man8_MANS +=3D virtlockd.8 virtlogd.8 =20 conf_DATA +=3D locking/virtlockd.conf logging/virtlogd.conf =20 @@ -1966,30 +1687,26 @@ augeas_DATA +=3D locking/virtlockd.aug logging/virt= logd.aug augeastest_DATA +=3D test_virtlockd.aug test_virtlogd.aug endif WITH_LIBVIRTD =20 -PODFILES =3D \ +PODFILES +=3D \ locking/virtlockd.pod \ logging/virtlogd.pod \ - remote/libvirtd.pod \ $(NULL) =20 -MANINFILES =3D \ +MANINFILES +=3D \ virtlockd.8.in \ virtlogd.8.in \ - libvirtd.8.in \ $(NULL) =20 CLEANFILES +=3D test_virtlockd.aug test_virtlogd.aug $(man8_MANS) MAINTAINERCLEANFILES +=3D $(MANINFILES) =20 -SYSTEMD_UNIT_FILES_IN =3D \ +SYSTEMD_UNIT_FILES_IN +=3D \ locking/virtlockd.service.in \ locking/virtlockd.socket.in \ locking/virtlockd-admin.socket.in \ logging/virtlogd.service.in \ logging/virtlogd.socket.in \ logging/virtlogd-admin.socket.in \ - remote/libvirtd.service.in \ - remote/virt-guest-shutdown.target.in \ $(NULL) =20 EXTRA_DIST +=3D \ @@ -2033,18 +1750,6 @@ install-systemd: uninstall-systemd: endif ! WITH_LIBVIRTD =20 -libvirtd.service: remote/libvirtd.service.in $(top_builddir)/config.status - $(AM_V_GEN)sed \ - -e 's|[@]localstatedir[@]|$(localstatedir)|g' \ - -e 's|[@]sbindir[@]|$(sbindir)|g' \ - -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ - < $< > $@-t && \ - mv $@-t $@ - -virt-guest-shutdown.target: remote/virt-guest-shutdown.target.in \ - $(top_builddir)/config.status - $(AM_V_GEN)cp $< $@ - virtlockd.service: locking/virtlockd.service.in $(top_builddir)/config.sta= tus $(AM_V_GEN)sed \ -e 's|[@]sbindir[@]|$(sbindir)|g' \ @@ -2084,10 +1789,6 @@ virtlogd-admin.socket: logging/virtlogd-admin.socket= .in \ mv $@-t $@ =20 =20 -UPSTART_FILES =3D \ - remote/libvirtd.upstart \ - $(NULL) - EXTRA_DIST +=3D $(UPSTART_FILES) =20 if WITH_LIBVIRTD @@ -2401,7 +2102,6 @@ install-data-local: install-init install-systemd inst= all-upstart \ install-sysctl install-polkit install-sasl \ install-logrotate $(INSTALL_DATA_DIRS:%=3Dinstall-data-%) if WITH_LIBVIRTD - $(MKDIR_P) "$(DESTDIR)$(localstatedir)/log/libvirt" $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/lockd" $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/lockd/files" $(MKDIR_P) "$(DESTDIR)$(localstatedir)/run/libvirt/lockd" @@ -2418,7 +2118,6 @@ uninstall-local:: uninstall-init uninstall-systemd un= install-upstart \ uninstall-sysctl uninstall-polkit uninstall-sasl \ uninstall-logrotate $(INSTALL_DATA_DIRS:%=3Duninstall-data-%) if WITH_LIBVIRTD - rmdir "$(DESTDIR)$(localstatedir)/log/libvirt" ||: rmdir "$(DESTDIR)$(localstatedir)/lib/libvirt/lockd/files" ||: rmdir "$(DESTDIR)$(localstatedir)/lib/libvirt/lockd" ||: rmdir "$(DESTDIR)$(localstatedir)/run/libvirt/lockd" ||: @@ -2435,7 +2134,5 @@ endif WITH_SANLOCK CLEANFILES +=3D *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda *.i *.s DISTCLEANFILES +=3D $(GENERATED_SYM_FILES) MAINTAINERCLEANFILES +=3D \ - $(REMOTE_DRIVER_GENERATED) \ - $(LIBVIRTD_GENERATED) \ $(VIR_NET_RPC_GENERATED) \ $(NULL) diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am new file mode 100644 index 0000000000..3d0d557bd9 --- /dev/null +++ b/src/remote/Makefile.inc.am @@ -0,0 +1,342 @@ +REMOTE_DRIVER_GENERATED =3D \ + remote/remote_protocol.c \ + remote/remote_protocol.h \ + remote/remote_client_bodies.h \ + remote/lxc_protocol.c \ + remote/lxc_protocol.h \ + remote/lxc_client_bodies.h \ + remote/qemu_protocol.c \ + remote/qemu_protocol.h \ + remote/qemu_client_bodies.h \ + $(NULL) + +REMOTE_DRIVER_SOURCES =3D \ + remote/remote_driver.c \ + remote/remote_driver.h \ + $(REMOTE_DRIVER_GENERATED) \ + $(NULL) + +LIBVIRTD_GENERATED =3D \ + remote/remote_daemon_dispatch_stubs.h \ + remote/remote_daemon_dispatch_lxc_stubs.h \ + remote/remote_daemon_dispatch_qemu_stubs.h \ + $(NULL) + +LIBVIRTD_SOURCES =3D \ + remote/remote_daemon.c \ + remote/remote_daemon.h \ + remote/remote_daemon_config.c \ + remote/remote_daemon_config.h \ + remote/remote_daemon_dispatch.c \ + remote/remote_daemon_dispatch.h \ + remote/remote_daemon_stream.c \ + remote/remote_daemon_stream.h \ + $(LIBVIRTD_GENERATED) \ + $(NULL) + + +LOGROTATE_FILES_IN +=3D \ + remote/libvirtd.qemu.logrotate.in \ + remote/libvirtd.lxc.logrotate.in \ + remote/libvirtd.libxl.logrotate.in \ + remote/libvirtd.uml.logrotate.in \ + remote/libvirtd.logrotate.in \ + $(NULL) + +SYSVINIT_FILES_IN +=3D remote/libvirtd.init.in + +SYSCONF_FILES +=3D remote/libvirtd.sysconf + +PODFILES +=3D remote/libvirtd.pod +MANINFILES +=3D libvirtd.8.in + +SYSTEMD_UNIT_FILES_IN +=3D \ + remote/libvirtd.service.in \ + remote/virt-guest-shutdown.target.in \ + $(NULL) + +UPSTART_FILES +=3D remote/libvirtd.upstart + +REMOTE_PROTOCOL =3D $(srcdir)/remote/remote_protocol.x +LXC_PROTOCOL =3D $(srcdir)/remote/lxc_protocol.x +QEMU_PROTOCOL =3D $(srcdir)/remote/qemu_protocol.x +REMOTE_DRIVER_PROTOCOL =3D \ + $(REMOTE_PROTOCOL) \ + $(QEMU_PROTOCOL) \ + $(LXC_PROTOCOL) \ + $(NULL) + +DRIVER_SOURCE_FILES +=3D $(REMOTE_DRIVER_SOURCES) + +EXTRA_DIST +=3D \ + $(REMOTE_DRIVER_PROTOCOL) \ + $(REMOTE_DRIVER_SOURCES) \ + $(LIBVIRTD_SOURCES) \ + remote/test_libvirtd.aug.in \ + remote/libvirtd.aug \ + remote/libvirtd.conf \ + remote/libvirtd.policy.in \ + remote/libvirtd.rules \ + remote/libvirtd.sasl \ + remote/libvirtd.sysctl \ + $(NULL) + +if WITH_REMOTE +noinst_LTLIBRARIES +=3D libvirt_driver_remote.la +libvirt_la_BUILT_LIBADD +=3D libvirt_driver_remote.la +libvirt_driver_remote_la_CFLAGS =3D \ + $(XDR_CFLAGS) \ + -I$(srcdir)/conf \ + -I$(srcdir)/rpc \ + $(AM_CFLAGS) \ + $(NULL) +libvirt_driver_remote_la_LDFLAGS =3D $(AM_LDFLAGS) +libvirt_driver_remote_la_SOURCES =3D $(REMOTE_DRIVER_SOURCES) + +BUILT_SOURCES +=3D $(REMOTE_DRIVER_GENERATED) +MAINTAINERCLEANFILES +=3D $(REMOTE_DRIVER_GENERATED) + +endif WITH_REMOTE + +if WITH_REMOTE +USED_SYM_FILES +=3D $(srcdir)/libvirt_remote.syms +else ! WITH_REMOTE +SYM_FILES +=3D $(srcdir)/libvirt_remote.syms +endif ! WITH_REMOTE + +if WITH_LIBVIRTD + +sbin_PROGRAMS +=3D libvirtd + +BUILT_SOURCES +=3D $(LIBVIRTD_GENERATED) +MAINTAINERCLEANFILES +=3D $(LIBVIRTD_GENERATED) + +augeas_DATA +=3D remote/libvirtd.aug + +augeastest_DATA +=3D test_libvirtd.aug + +conf_DATA +=3D remote/libvirtd.conf + +CLEANFILES +=3D test_libvirtd.aug + +if WITH_POLKIT +if WITH_POLKIT0 +policydir =3D $(datadir)/PolicyKit/policy +policyauth =3D auth_admin_keep_session +else ! WITH_POLKIT0 +policydir =3D $(datadir)/polkit-1/actions +policyauth =3D auth_admin_keep +endif ! WITH_POLKIT0 +endif WITH_POLKIT + +BUILT_SOURCES +=3D libvirtd.policy +CLEANFILES +=3D libvirtd.policy + +man8_MANS +=3D libvirtd.8 + +libvirtd_SOURCES =3D $(LIBVIRTD_SOURCES) + +libvirtd_CFLAGS =3D \ + $(LIBXML_CFLAGS) \ + $(GNUTLS_CFLAGS) \ + $(SASL_CFLAGS) \ + $(XDR_CFLAGS) \ + $(DBUS_CFLAGS) \ + $(LIBNL_CFLAGS) \ + $(WARN_CFLAGS) \ + $(PIE_CFLAGS) \ + $(COVERAGE_CFLAGS) \ + -I$(srcdir)/access \ + -I$(srcdir)/conf \ + -I$(srcdir)/rpc \ + $(NULL) + +libvirtd_LDFLAGS =3D \ + $(RELRO_LDFLAGS) \ + $(PIE_LDFLAGS) \ + $(COVERAGE_LDFLAGS) \ + $(NO_INDIRECT_LDFLAGS) \ + $(NO_UNDEFINED_LDFLAGS) \ + $(NULL) + +libvirtd_LDADD =3D \ + $(LIBXML_LIBS) \ + $(GNUTLS_LIBS) \ + $(SASL_LIBS) \ + $(DBUS_LIBS) \ + $(LIBNL_LIBS) \ + $(NULL) + +if WITH_DTRACE_PROBES +libvirtd_LDADD +=3D ../src/libvirt_probes.lo +endif WITH_DTRACE_PROBES + +libvirtd_LDADD +=3D \ + libvirt_driver_admin.la \ + libvirt-lxc.la \ + libvirt-qemu.la \ + libvirt.la \ + ../gnulib/lib/libgnu.la \ + $(LIBSOCKET) \ + $(NULL) + +INSTALL_DATA_DIRS +=3D remote + +install-data-remote: + $(MKDIR_P) "$(DESTDIR)$(localstatedir)/log/libvirt" + +uninstall-data-remote: + rmdir "$(DESTDIR)$(localstatedir)/log/libvirt" ||: + +AUGEAS_DIRS +=3D remote + +test_libvirtd.aug: remote/test_libvirtd.aug.in \ + remote/libvirtd.conf $(AUG_GENTEST) + $(AM_V_GEN)$(AUG_GENTEST) $(srcdir)/remote/libvirtd.conf $< $@ + +check-augeas-remote: test_libvirtd.aug + $(AM_V_GEN)if test -x '$(AUGPARSE)'; then \ + '$(AUGPARSE)' -I $(srcdir)/remote test_libvirtd.aug; \ + fi + +if WITH_SYSCTL +# Use $(prefix)/lib rather than $(libdir), since man sysctl.d insists on +# /usr/lib/sysctl.d/ even when libdir is /usr/lib64 +install-sysctl: + $(MKDIR_P) $(DESTDIR)$(prefix)/lib/sysctl.d + $(INSTALL_DATA) $(srcdir)/remote/libvirtd.sysctl \ + $(DESTDIR)$(prefix)/lib/sysctl.d/60-libvirtd.conf + +uninstall-sysctl: + rm -f $(DESTDIR)$(prefix)/lib/sysctl.d/60-libvirtd.conf + rmdir $(DESTDIR)$(prefix)/lib/sysctl.d || : +else ! WITH_SYSCTL +install-sysctl: +uninstall-sysctl: +endif ! WITH_SYSCTL + +if WITH_POLKIT +install-polkit:: + $(MKDIR_P) $(DESTDIR)$(policydir) + $(INSTALL_DATA) libvirtd.policy $(DESTDIR)$(policydir)/org.libvirt.unix.p= olicy +if ! WITH_POLKIT0 + $(MKDIR_P) $(DESTDIR)$(datadir)/polkit-1/rules.d + $(INSTALL_DATA) $(srcdir)/remote/libvirtd.rules \ + $(DESTDIR)$(datadir)/polkit-1/rules.d/50-libvirt.rules +endif ! WITH_POLKIT0 + +uninstall-polkit:: + rm -f $(DESTDIR)$(policydir)/org.libvirt.unix.policy + rmdir $(DESTDIR)$(policydir) || : +if ! WITH_POLKIT0 + rm -f $(DESTDIR)$(datadir)/polkit-1/rules.d/50-libvirt.rules + rmdir $(DESTDIR)$(datadir)/polkit-1/rules.d || : +endif ! WITH_POLKIT0 + +else ! WITH_POLKIT +install-polkit:: +uninstall-polkit:: +endif ! WITH_POLKIT + +else ! WITH_LIBVIRTD +install-polkit:: +uninstall-polkit:: +install-sysctl:: +uninstall-sysctl:: +endif ! WITH_LIBVIRTD + +.PHONY: \ + install-data-remote \ + uninstall-data-remote \ + check-augeas-remote \ + $(NULL) + +# This is needed for clients too, so can't wrap in +# the WITH_LIBVIRTD conditional +if WITH_SASL +install-sasl: + $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sasl2/ + $(INSTALL_DATA) $(srcdir)/remote/libvirtd.sasl \ + $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf + +uninstall-sasl: + rm -f $(DESTDIR)$(sysconfdir)/sasl2/libvirt.conf + rmdir $(DESTDIR)$(sysconfdir)/sasl2/ || : +else ! WITH_SASL +install-sasl: +uninstall-sasl: +endif ! WITH_SASL + +libvirtd.policy: remote/libvirtd.policy.in $(top_builddir)/config.status + $(AM_V_GEN) sed \ + -e 's|[@]authaction[@]|$(policyauth)|g' \ + < $< > $@-t && \ + mv $@-t $@ + +libvirtd.init: remote/libvirtd.init.in $(top_builddir)/config.status + $(AM_V_GEN)sed \ + -e 's|[@]localstatedir[@]|$(localstatedir)|g' \ + -e 's|[@]sbindir[@]|$(sbindir)|g' \ + -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ + < $< > $@-t && \ + chmod a+x $@-t && \ + mv $@-t $@ + +libvirtd.service: remote/libvirtd.service.in $(top_builddir)/config.status + $(AM_V_GEN)sed \ + -e 's|[@]localstatedir[@]|$(localstatedir)|g' \ + -e 's|[@]sbindir[@]|$(sbindir)|g' \ + -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ + < $< > $@-t && \ + mv $@-t $@ + +virt-guest-shutdown.target: remote/virt-guest-shutdown.target.in \ + $(top_builddir)/config.status + $(AM_V_GEN)cp $< $@ + + +remote/remote_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \ + $(REMOTE_PROTOCOL) Makefile.am + $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \ + remote REMOTE $(REMOTE_PROTOCOL) \ + > $(srcdir)/remote/remote_client_bodies.h + +remote/lxc_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \ + $(LXC_PROTOCOL) Makefile.am + $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \ + lxc LXC $(LXC_PROTOCOL) \ + > $(srcdir)/remote/lxc_client_bodies.h + +remote/qemu_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \ + $(QEMU_PROTOCOL) Makefile.am + $(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \ + qemu QEMU $(QEMU_PROTOCOL) \ + > $(srcdir)/remote/qemu_client_bodies.h + +remote/remote_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \ + $(REMOTE_PROTOCOL) Makefile.am + $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ + --mode=3Dserver remote REMOTE $(REMOTE_PROTOCOL) \ + > $(srcdir)/remote/remote_daemon_dispatch_stubs.h + +remote/remote_daemon_dispatch_lxc_stubs.h: $(srcdir)/rpc/gendispatch.pl \ + $(LXC_PROTOCOL) Makefile.am + $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ + --mode=3Dserver lxc LXC $(LXC_PROTOCOL) \ + > $(srcdir)/remote/remote_daemon_dispatch_lxc_stubs.h + +remote/remote_daemon_dispatch_qemu_stubs.h: $(srcdir)/rpc/gendispatch.pl \ + $(QEMU_PROTOCOL) Makefile.am + $(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \ + --mode=3Dserver qemu QEMU $(QEMU_PROTOCOL) \ + > $(srcdir)/remote/remote_daemon_dispatch_qemu_stubs.h + +libvirtd.8.in: remote/libvirtd.pod + $(AM_V_GEN)$(POD2MAN) --section=3D8 $< $@-t1 && \ + if grep 'POD ERROR' $@-t1; then rm $@-t1; exit 1; fi && \ + sed \ + -e 's|SYSCONFDIR|\@sysconfdir\@|g' \ + -e 's|LOCALSTATEDIR|\@localstatedir\@|g' \ + < $@-t1 > $@-t2 && \ + rm -f $@-t1 && \ + mv $@-t2 $@ --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list