[libvirt] [PATCH 1/4] travis: Drop precise

Andrea Bolognani posted 4 patches 7 years, 2 months ago
[libvirt] [PATCH 1/4] travis: Drop precise
Posted by Andrea Bolognani 7 years, 2 months ago
Support for building on precise is going to be dropped from
Travis CI in a couple of months, let's get ahead of the game.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 .travis.yml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 3f26a1eeee..9219ccd173 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,12 +4,8 @@ cache: ccache
 
 matrix:
   include:
-    - compiler: gcc
-      dist: precise
     - compiler: gcc
       dist: trusty
-    - compiler: clang
-      dist: precise
     - compiler: clang
       dist: trusty
     - compiler: clang
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/4] travis: Drop precise
Posted by Daniel P. Berrangé 7 years, 2 months ago
On Wed, Feb 28, 2018 at 12:42:57PM +0100, Andrea Bolognani wrote:
> Support for building on precise is going to be dropped from
> Travis CI in a couple of months, let's get ahead of the game.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .travis.yml | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 3f26a1eeee..9219ccd173 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -4,12 +4,8 @@ cache: ccache
>  
>  matrix:
>    include:
> -    - compiler: gcc
> -      dist: precise
>      - compiler: gcc
>        dist: trusty
> -    - compiler: clang
> -      dist: precise
>      - compiler: clang
>        dist: trusty
>      - compiler: clang

This is incomplete because there's CFLAGS defined later on to work around
a bug on Precise that should also be removed. 

Unfortunately removing that CFLAGS then reveals the fact that building
with Clang breaks "make check" on the remote protocol files. This failure
has been hidden before now because the -Wno-error=variadic-args flag for
some reason caused pdwtags to fail to emit any output, which accidentally
caused libvirt to ignore the failure.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list