[libvirt] [PATCH v2 3/5] travis: run "make distcheck" instead of just "make check"

Daniel P. Berrangé posted 5 patches 7 years, 2 months ago
[libvirt] [PATCH v2 3/5] travis: run "make distcheck" instead of just "make check"
Posted by Daniel P. Berrangé 7 years, 2 months ago
Running "make distcheck"  includes the "make check", and "make dist"
targets. It ensures that we have CLEANFILES and uninstall rules setup
correctly, as well as validating VPATH builds succeed.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 33887e7284..0cfdf80950 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -96,7 +96,7 @@ before_script:
 script:
   # Many unit tests still fail on macOS, and there are a bunch of issues with
   # syntax-check as well, so skip those steps on that platform for now
-  - make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 check; fi
+  - make -j3 && if [ "$TRAVIS_OS_NAME" != "osx" ]; then make -j3 syntax-check && make -j3 distcheck; fi
 
 after_failure:
   - echo '============================================================================'
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 3/5] travis: run "make distcheck" instead of just "make check"
Posted by Andrea Bolognani 7 years, 2 months ago
On Wed, 2018-02-28 at 14:55 +0000, Daniel P. Berrangé wrote:
> Running "make distcheck"  includes the "make check", and "make dist"

Double spacing here.

> targets. It ensures that we have CLEANFILES and uninstall rules setup
> correctly, as well as validating VPATH builds succeed.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list