[libvirt] [PATCH perl 2/2] Fix docs for Sys::Virt::NWFilter undefine method

Daniel P. Berrangé posted 2 patches 7 years, 2 months ago
[libvirt] [PATCH perl 2/2] Fix docs for Sys::Virt::NWFilter undefine method
Posted by Daniel P. Berrangé 7 years, 2 months ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 Changes                  | 1 +
 lib/Sys/Virt/NWFilter.pm | 6 ++----
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Changes b/Changes
index d2d9a94..016fcf2 100644
--- a/Changes
+++ b/Changes
@@ -3,6 +3,7 @@ Revision history for perl module Sys::Virt
 4.2.0 2018-00-00
 
  - Add missing define_nwfilter and define_secret APIs in Sys::Virt
+ - Misc docs fixes
 
 4.1.0 2018-03-05
 
diff --git a/lib/Sys/Virt/NWFilter.pm b/lib/Sys/Virt/NWFilter.pm
index 8ede8a0..980532d 100644
--- a/lib/Sys/Virt/NWFilter.pm
+++ b/lib/Sys/Virt/NWFilter.pm
@@ -91,10 +91,8 @@ the network's configuration
 
 =item $filter->undefine()
 
-Remove the configuration associated with a network previously defined
-with the C<define_network> method in L<Sys::Virt>. If the network is
-running, you probably want to use the C<shutdown> or C<destroy>
-methods instead.
+Remove the configuration associated with a network filter previously defined
+with the C<define_nwfilter> method in L<Sys::Virt>.
 
 =cut
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH perl 2/2] Fix docs for Sys::Virt::NWFilter undefine method
Posted by Laine Stump 7 years, 2 months ago
On 03/06/2018 07:44 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Laine Stump <laine@laine.org>

> ---
>  Changes                  | 1 +
>  lib/Sys/Virt/NWFilter.pm | 6 ++----
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Changes b/Changes
> index d2d9a94..016fcf2 100644
> --- a/Changes
> +++ b/Changes
> @@ -3,6 +3,7 @@ Revision history for perl module Sys::Virt
>  4.2.0 2018-00-00
>  
>   - Add missing define_nwfilter and define_secret APIs in Sys::Virt
> + - Misc docs fixes
>  
>  4.1.0 2018-03-05
>  
> diff --git a/lib/Sys/Virt/NWFilter.pm b/lib/Sys/Virt/NWFilter.pm
> index 8ede8a0..980532d 100644
> --- a/lib/Sys/Virt/NWFilter.pm
> +++ b/lib/Sys/Virt/NWFilter.pm
> @@ -91,10 +91,8 @@ the network's configuration
>  
>  =item $filter->undefine()
>  
> -Remove the configuration associated with a network previously defined
> -with the C<define_network> method in L<Sys::Virt>. If the network is
> -running, you probably want to use the C<shutdown> or C<destroy>
> -methods instead.
> +Remove the configuration associated with a network filter previously defined
> +with the C<define_nwfilter> method in L<Sys::Virt>.
>  
>  =cut
>  


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list