From nobody Thu May 15 00:20:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520361214082691.7183854614952; Tue, 6 Mar 2018 10:33:34 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE26A28216; Tue, 6 Mar 2018 18:33:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D44A18026; Tue, 6 Mar 2018 18:33:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E73424A470; Tue, 6 Mar 2018 18:33:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w26IXB9G008979 for ; Tue, 6 Mar 2018 13:33:11 -0500 Received: by smtp.corp.redhat.com (Postfix) id 648401C71C; Tue, 6 Mar 2018 18:33:11 +0000 (UTC) Received: from vhost2.laine.org (ovpn-116-195.phx2.redhat.com [10.3.116.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id F05D31C71F for ; Tue, 6 Mar 2018 18:33:10 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Tue, 6 Mar 2018 13:33:02 -0500 Message-Id: <20180306183302.522518-4-laine@laine.org> In-Reply-To: <20180306183302.522518-1-laine@laine.org> References: <20180306183302.522518-1-laine@laine.org> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [perl PATCH 3/3] docs: fix other assorted example variable names X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 06 Mar 2018 18:33:32 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" There were quite a few instances of apparent copy/paste from domain examples over to examples of the same action on a different type of object (e.g. calling define_network() and assigning the result to a variable called $dom). This patch removes as many of them as I noticed while doing a search for "=3D item ". Hopefully this makes the examples less confusing. Signed-off-by: Laine Stump Reviewed-by: Daniel P. Berrang=C3=A9 --- lib/Sys/Virt.pm | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/lib/Sys/Virt.pm b/lib/Sys/Virt.pm index 13b2603..4726f9a 100644 --- a/lib/Sys/Virt.pm +++ b/lib/Sys/Virt.pm @@ -281,7 +281,7 @@ sub define_domain { return Sys::Virt::Domain->_new(connection =3D> $self, xml =3D> $xml, n= ocreate =3D> 1, flags =3D> $flags); } =20 -=3Ditem my $dom =3D $conn->create_network($xml); +=3Ditem my $net =3D $conn->create_network($xml); =20 Create a new network based on the XML description passed into the C<$xml> parameter. The returned object is an instance of the L @@ -297,7 +297,7 @@ sub create_network { return Sys::Virt::Network->_new(connection =3D> $self, xml =3D> $xml); } =20 -=3Ditem my $dom =3D $conn->define_network($xml); +=3Ditem my $net =3D $conn->define_network($xml); =20 Defines, but does not start, a new network based on the XML description passed into the C<$xml> parameter. The returned object is an instance @@ -315,7 +315,7 @@ sub define_network { return Sys::Virt::Network->_new(connection =3D> $self, xml =3D> $xml, = nocreate =3D> 1); } =20 -=3Ditem my $dom =3D $conn->create_storage_pool($xml); +=3Ditem my $pool =3D $conn->create_storage_pool($xml); =20 Create a new storage pool based on the XML description passed into the C<$= xml> parameter. The returned object is an instance of the L @@ -331,7 +331,7 @@ sub create_storage_pool { return Sys::Virt::StoragePool->_new(connection =3D> $self, xml =3D> $x= ml); } =20 -=3Ditem my $dom =3D $conn->define_storage_pool($xml); +=3Ditem my $pool =3D $conn->define_storage_pool($xml); =20 Defines, but does not start, a new storage pol based on the XML description passed into the C<$xml> parameter. The returned object is an instance @@ -349,7 +349,7 @@ sub define_storage_pool { return Sys::Virt::StoragePool->_new(connection =3D> $self, xml =3D> $x= ml, nocreate =3D> 1); } =20 -=3Ditem my $dom =3D $conn->create_interface($xml); +=3Ditem my $pool =3D $conn->create_interface($xml); =20 Create a new interface based on the XML description passed into the C<$xml> parameter. The returned object is an instance of the L @@ -365,7 +365,7 @@ sub create_interface { return Sys::Virt::Interface->_new(connection =3D> $self, xml =3D> $xml= ); } =20 -=3Ditem my $dom =3D $conn->define_interface($xml); +=3Ditem my $iface =3D $conn->define_interface($xml); =20 Defines, but does not start, a new interface based on the XML description passed into the C<$xml> parameter. The returned object is an instance @@ -383,7 +383,7 @@ sub define_interface { return Sys::Virt::Interface->_new(connection =3D> $self, xml =3D> $xml= , nocreate =3D> 1); } =20 -=3Ditem my $dom =3D $conn->create_node_device($xml); +=3Ditem my $dev =3D $conn->create_node_device($xml); =20 Create a new virtual node device based on the XML description passed into = the C<$xml> parameter. The returned object is an instance of the L @@ -463,7 +463,7 @@ sub list_defined_domains { return @domains; } =20 -=3Ditem my $nnames =3D $conn->num_of_defined_domains() +=3Ditem my $ndoms =3D $conn->num_of_defined_domains() =20 Return the number of running domains known to the hypervisor. This can be used as the C parameter to C. @@ -507,7 +507,7 @@ sub list_networks { return @networks; } =20 -=3Ditem my $nnames =3D $conn->num_of_networks() +=3Ditem my $nnets =3D $conn->num_of_networks() =20 Return the number of running networks known to the hypervisor. This can be used as the C parameter to C. @@ -544,7 +544,7 @@ sub list_defined_networks { return @networks; } =20 -=3Ditem my $nnamess =3D $conn->num_of_defined_networks() +=3Ditem my $nnets =3D $conn->num_of_defined_networks() =20 Return the number of running networks known to the host. This can be used as the C parameter to C. @@ -588,7 +588,7 @@ sub list_storage_pools { return @pools; } =20 -=3Ditem my $nnames =3D $conn->num_of_storage_pools() +=3Ditem my $npools =3D $conn->num_of_storage_pools() =20 Return the number of running storage pools known to the hypervisor. This c= an be used as the C parameter to C. @@ -625,7 +625,7 @@ sub list_defined_storage_pools { return @pools; } =20 -=3Ditem my $nnames =3D $conn->num_of_defined_storage_pools() +=3Ditem my $npools =3D $conn->num_of_defined_storage_pools() =20 Return the number of running networks known to the host. This can be used as the C parameter to C. @@ -672,7 +672,7 @@ sub list_node_devices { return @devs; } =20 -=3Ditem my $nnames =3D $conn->num_of_node_devices($capability[, $flags]) +=3Ditem my $ndevs =3D $conn->num_of_node_devices($capability[, $flags]) =20 Return the number of host devices known to the hypervisor. This can be used as the C parameter to C. @@ -681,7 +681,7 @@ only devices with a particular capability type, and sho= uld be left as C if the full list is required. The optional parameter is currently unused and defaults to 0 if omitted. =20 -=3Ditem my @netNames =3D $conn->list_node_device_names($capability, $maxna= mes[, $flags]) +=3Ditem my @devNames =3D $conn->list_node_device_names($capability, $maxna= mes[, $flags]) =20 Return a list of all host device names currently known to the hypervisor. = The names can be used with the C method. @@ -724,7 +724,7 @@ sub list_interfaces { return @interfaces; } =20 -=3Ditem my $nnames =3D $conn->num_of_interfaces() +=3Ditem my $nifaces =3D $conn->num_of_interfaces() =20 Return the number of running interfaces known to the hypervisor. This can = be used as the C parameter to C. @@ -761,7 +761,7 @@ sub list_defined_interfaces { return @interfaces; } =20 -=3Ditem my $nnames =3D $conn->num_of_defined_interfaces() +=3Ditem my $nifaces =3D $conn->num_of_defined_interfaces() =20 Return the number of inactive interfaces known to the hypervisor. This can= be used as the C parameter to C. @@ -822,7 +822,7 @@ in the returned list are instances of the L class. The C<$flags> parameter can be used to filter the list of returned secrets. =20 -=3Ditem my @nets =3D $conn->list_nwfilters() +=3Ditem my @nwfilters =3D $conn->list_nwfilters() =20 Return a list of all nwfilters currently known to the hypervisor. The elem= ents in the returned list are instances of the L class. @@ -849,7 +849,7 @@ sub list_nwfilters { return @nwfilters; } =20 -=3Ditem my $nnames =3D $conn->num_of_nwfilters() +=3Ditem my $nnwfilters =3D $conn->num_of_nwfilters() =20 Return the number of running nwfilters known to the hypervisor. This can be used as the C parameter to C. @@ -1139,7 +1139,7 @@ sub get_secret_by_usage { usageID =3D> $id); } =20 -=3Ditem my $dom =3D $conn->get_nwfilter_by_name($name) +=3Ditem my $nwfilter =3D $conn->get_nwfilter_by_name($name) =20 Return the domain with a name of C<$name>. The returned object is an instance of the L class. @@ -1154,7 +1154,7 @@ sub get_nwfilter_by_name { } =20 =20 -=3Ditem my $dom =3D $conn->get_nwfilter_by_uuid($uuid) +=3Ditem my $nwfilter =3D $conn->get_nwfilter_by_uuid($uuid) =20 Return the nwfilter with a globally unique id of C<$uuid>. The returned ob= ject is an instance of the L class. --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list