Fix virConnect(Un)RegisterCloseCallback and get rid of global variables

[libvirt] [PATCH 16/20] remote: Set eventID explicitly to an invalid value

Posted by Marc Hartmayer 7 years, 2 months ago

Set the eventID for remoteRelayDomainQemuMonitorEvent explicitly to an
invalid value. Although the value is not used by
remoteRelayDomainQemuMonitorEvent, but it might be less prone to
errors for further refactorings.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
---
 src/remote/remote_daemon_dispatch.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index bf6c00348a5e..ff26574c9f6b 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -6215,6 +6215,7 @@ qemuDispatchConnectDomainMonitorEventRegister(virNetServerPtr server ATTRIBUTE_U
     if (VIR_ALLOC(callback) < 0)
         goto cleanup;
     callback->client = virObjectRef(client);
+    callback->eventID = -1;
     callback->callbackID = -1;
     ref = callback;
     if (VIR_APPEND_ELEMENT(priv->qemuEventCallbacks,
-- 
2.13.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 16/20] remote: Set eventID explicitly to an invalid value

Posted by John Ferlan 7 years, 1 month ago


On 03/08/2018 07:20 AM, Marc Hartmayer wrote:
> Set the eventID for remoteRelayDomainQemuMonitorEvent explicitly to an
> invalid value. Although the value is not used by
> remoteRelayDomainQemuMonitorEvent, but it might be less prone to
> errors for further refactorings.
> 
> Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
> Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
> ---
>  src/remote/remote_daemon_dispatch.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

(always a bit "nervous" changing anything in these APIs...)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 16/20] remote: Set eventID explicitly to an invalid value

Posted by Marc Hartmayer 7 years, 1 month ago

On Thu, Mar 15, 2018 at 04:39 PM +0100, John Ferlan <jferlan@redhat.com> wrote:
> On 03/08/2018 07:20 AM, Marc Hartmayer wrote:
>> Set the eventID for remoteRelayDomainQemuMonitorEvent explicitly to an
>> invalid value. Although the value is not used by
>> remoteRelayDomainQemuMonitorEvent, but it might be less prone to
>> errors for further refactorings.
>>
>> Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
>> Reviewed-by: Bjoern Walk <bwalk@linux.vnet.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
>> ---
>>  src/remote/remote_daemon_dispatch.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>
> Reviewed-by: John Ferlan <jferlan@redhat.com>
>
> John
>
> (always a bit "nervous" changing anything in these APIs...)

Yep, I know that feeling :)

>
--
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list