From nobody Wed Dec 17 00:15:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1520889141788421.1692374113943; Mon, 12 Mar 2018 14:12:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A5E428207; Mon, 12 Mar 2018 21:12:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E415217CC2; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9B08F181BA04; Mon, 12 Mar 2018 21:12:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2CLC9pa028710 for ; Mon, 12 Mar 2018 17:12:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 40C7E608EE; Mon, 12 Mar 2018 21:12:09 +0000 (UTC) Received: from unknown54ee7586bd10.attlocal.net.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id F410717A70 for ; Mon, 12 Mar 2018 21:12:08 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 12 Mar 2018 17:11:49 -0400 Message-Id: <20180312211158.28343-3-jferlan@redhat.com> In-Reply-To: <20180312211158.28343-1-jferlan@redhat.com> References: <20180312211158.28343-1-jferlan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 02/11] virsh: Fix man page argument ordering for vol-clone command X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 12 Mar 2018 21:12:20 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The proper command order is 'virsh vol-clone source-vol target-vol pool'. While making the modification clean up the description a bit too in order to help clarify under what circumstances the source-vol could be found if the pool name was not provided. Signed-off-by: John Ferlan --- tools/virsh.pod | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 52f45d721..ff3b0729e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4031,19 +4031,27 @@ support full allocation). This option creates a spa= rse image file with metadata, resulting in higher performance compared to images with no preallocation a= nd only slightly higher initial disk space usage. =20 -=3Ditem B [I<--pool> I] I -I [I<--prealloc-metadata>] [I<--reflink>] +=3Ditem B I I +[I<--pool> I] [I<--prealloc-metadata>] [I<--reflink>] =20 Clone an existing volume within the parent pool. Less powerful, but easier to type, version of B. -I<--pool> I is the name or UUID of the storage pool -that contains the source volume, and will contain the new volume. + I is the name or key or path of the source volume. + I is the name of the new volume. + +I<--pool> I is the name or UUID of the storage pool +that contains the source volume and will contain the new volume. +If the source volume name is provided instead of the key or path, then +providing the pool is necessary to find the volume to be cloned; otherwise, +the first volume found by the key or path will be used. + [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't support full allocation). This option creates a sparse image file with met= adata, resulting in higher performance compared to images with no preallocation a= nd only slightly higher initial disk space usage. + When I<--reflink> is specified, perform a COW lightweight copy, where the data blocks are copied only when modified. If this is not possible, the copy fails. --=20 2.13.6 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list