spec: Drop polkit from {,Build}Requires:

[libvirt] [PATCH] spec: Drop polkit from {,Build}Requires:

Posted by Andrea Bolognani 7 years, 2 months ago

As of 2499d1a09508 we don't link against libpolkit or look for
the pkcheck command anymore, so these package relationships are
no longer necessary and can be safely dropped.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 5e05d706f8..e70cc02dc8 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -357,13 +357,6 @@ BuildRequires: radvd
 BuildRequires: ebtables
 BuildRequires: module-init-tools
 BuildRequires: cyrus-sasl-devel
-%if 0%{?fedora} || 0%{?rhel} >= 7
-# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck
-BuildRequires: polkit >= 0.112
-BuildRequires: polkit-devel >= 0.112
-%else
-BuildRequires: polkit-devel >= 0.93
-%endif
 # For mount/umount in FS driver
 BuildRequires: util-linux
 %if %{with_qemu}
@@ -489,11 +482,6 @@ Requires: module-init-tools
 # for /sbin/ip & /sbin/tc
 Requires: iproute
 Requires: avahi-libs
-%if 0%{?fedora} || 0%{?rhel} >= 7
-Requires: polkit >= 0.112
-%else
-Requires: polkit >= 0.93
-%endif
 %if %{with_cgconfig}
 Requires: libcgroup
 %endif
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Drop polkit from {,Build}Requires:

Posted by Daniel P. Berrangé 7 years, 1 month ago

On Wed, Mar 14, 2018 at 05:31:39PM +0100, Andrea Bolognani wrote:
> As of 2499d1a09508 we don't link against libpolkit or look for
> the pkcheck command anymore, so these package relationships are
> no longer necessary and can be safely dropped.

We still require polkit to be installed - the "polkit" RPM is what
provides the DBus service we talk to.

> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  libvirt.spec.in | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 5e05d706f8..e70cc02dc8 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -357,13 +357,6 @@ BuildRequires: radvd
>  BuildRequires: ebtables
>  BuildRequires: module-init-tools
>  BuildRequires: cyrus-sasl-devel
> -%if 0%{?fedora} || 0%{?rhel} >= 7
> -# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck
> -BuildRequires: polkit >= 0.112
> -BuildRequires: polkit-devel >= 0.112
> -%else
> -BuildRequires: polkit-devel >= 0.93
> -%endif
>  # For mount/umount in FS driver
>  BuildRequires: util-linux
>  %if %{with_qemu}
> @@ -489,11 +482,6 @@ Requires: module-init-tools
>  # for /sbin/ip & /sbin/tc
>  Requires: iproute
>  Requires: avahi-libs
> -%if 0%{?fedora} || 0%{?rhel} >= 7
> -Requires: polkit >= 0.112
> -%else
> -Requires: polkit >= 0.93
> -%endif
>  %if %{with_cgconfig}
>  Requires: libcgroup
>  %endif
> -- 
> 2.14.3
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Drop polkit from {,Build}Requires:

Posted by Andrea Bolognani 7 years, 1 month ago

On Thu, 2018-03-15 at 09:00 +0000, Daniel P. Berrangé wrote:
> On Wed, Mar 14, 2018 at 05:31:39PM +0100, Andrea Bolognani wrote:
> > As of 2499d1a09508 we don't link against libpolkit or look for
> > the pkcheck command anymore, so these package relationships are
> > no longer necessary and can be safely dropped.
> 
> We still require polkit to be installed - the "polkit" RPM is what
> provides the DBus service we talk to.

That makes sense.

So the Requires: need to stay; the BuildRequires: can be dropped
though, right? Or at the very least we should be able to remove
any reference to polkit-devel and only {,Build}Requires: polkit,
as we're definitely no longer linking against any library.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Drop polkit from {,Build}Requires:

Posted by Daniel P. Berrangé 7 years, 1 month ago

On Thu, Mar 15, 2018 at 11:07:36AM +0100, Andrea Bolognani wrote:
> On Thu, 2018-03-15 at 09:00 +0000, Daniel P. Berrangé wrote:
> > On Wed, Mar 14, 2018 at 05:31:39PM +0100, Andrea Bolognani wrote:
> > > As of 2499d1a09508 we don't link against libpolkit or look for
> > > the pkcheck command anymore, so these package relationships are
> > > no longer necessary and can be safely dropped.
> > 
> > We still require polkit to be installed - the "polkit" RPM is what
> > provides the DBus service we talk to.
> 
> That makes sense.
> 
> So the Requires: need to stay; the BuildRequires: can be dropped
> though, right? Or at the very least we should be able to remove
> any reference to polkit-devel and only {,Build}Requires: polkit,
> as we're definitely no longer linking against any library.

Yeah the -devel is not needed, since m4/virt-polkit.m4 only looks at the
--enable-polkit and --enable-dbus args now


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list