The isinstance() function [1] returns true if an object argument is an
instance of a classinfo argument or of a direct, indirect subclass
thereof.

1: https://docs.python.org/3/library/functions.html#isinstance

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
---
 docs/apibuild.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/docs/apibuild.py b/docs/apibuild.py
index 51abf8383..7faa083b2 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -742,7 +742,7 @@ class CParser:
         return line
 
     def cleanupComment(self):
-        if type(self.comment) != type(""):
+        if not isinstance(self.comment, str):
             return
         # remove the leading * on multi-line comments
         lines = self.comment.splitlines(True)
@@ -2223,9 +2223,8 @@ class docBuilder:
             output.write("    <struct name='%s' file='%s' type='%s'" % (
                      name, self.modulename_file(id.header), id.info))
             name = id.info[7:]
-            if name in self.idx.structs and ( \
-               type(self.idx.structs[name].info) == type(()) or
-                type(self.idx.structs[name].info) == type([])):
+            if (name in self.idx.structs and
+                    isinstance(self.idx.structs[name].info, (list, tuple))):
                 output.write(">\n")
                 try:
                     for field in self.idx.structs[name].info:
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Sat, 2018-03-17 at 14:23 +0000, Radostin Stoyanov wrote:
> The isinstance() function [1] returns true if an object argument is an
> instance of a classinfo argument or of a direct, indirect subclass
> thereof.
> 
> 1: https://docs.python.org/3/library/functions.html#isinstance
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
> ---
>  docs/apibuild.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

s/isinctance/isinstance/ in the subject.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

s/isinctance/isinstance/ in the $subject

On Sat, Mar 17, 2018 at 02:23:19PM +0000, Radostin Stoyanov wrote:
> The isinstance() function [1] returns true if an object argument is an
> instance of a classinfo argument or of a direct, indirect subclass
> thereof.
> 
> 1: https://docs.python.org/3/library/functions.html#isinstance
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
> ---
>  docs/apibuild.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list