[libvirt] [PATCH 08/22] esx_vi_generator: Simplify alignment function

Radostin Stoyanov posted 22 patches 7 years, 3 months ago
[libvirt] [PATCH 08/22] esx_vi_generator: Simplify alignment function
Posted by Radostin Stoyanov 7 years, 3 months ago
Generate whitespace using the standard function ljust() that is
available in both Py3 [1] and Py2 [2].

1: https://docs.python.org/3/library/stdtypes.html?highlight=strip#str.ljust
2: https://docs.python.org/2.7/library/string.html#string.ljust

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
---
 src/esx/esx_vi_generator.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index e4890c61b..0dca44fed 100755
--- a/src/esx/esx_vi_generator.py
+++ b/src/esx/esx_vi_generator.py
@@ -49,10 +49,7 @@ separator = "/* " + ("* " * 37) + "*\n"
 
 
 def aligned(left, right, length=59):
-    while len(left) < length:
-        left += " "
-
-    return left + right
+    return left.ljust(length, ' ') + right
 
 
 
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 08/22] esx_vi_generator: Simplify alignment function
Posted by Daniel P. Berrangé 7 years, 3 months ago
On Sat, Mar 17, 2018 at 02:23:26PM +0000, Radostin Stoyanov wrote:
> Generate whitespace using the standard function ljust() that is
> available in both Py3 [1] and Py2 [2].
> 
> 1: https://docs.python.org/3/library/stdtypes.html?highlight=strip#str.ljust
> 2: https://docs.python.org/2.7/library/string.html#string.ljust
> 
> Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
> ---
>  src/esx/esx_vi_generator.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list