From nobody Mon Jul 7 04:42:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1521528599540959.8660193221169; Mon, 19 Mar 2018 23:49:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52C33804E2; Tue, 20 Mar 2018 06:49:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20E0F5D6A8; Tue, 20 Mar 2018 06:49:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5D624CAA4; Tue, 20 Mar 2018 06:49:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w2K6nZj5019423 for ; Tue, 20 Mar 2018 02:49:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id E8911190C9; Tue, 20 Mar 2018 06:49:35 +0000 (UTC) Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E25D160A9E for ; Tue, 20 Mar 2018 06:49:33 +0000 (UTC) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D3B6780467 for ; Tue, 20 Mar 2018 06:49:32 +0000 (UTC) Received: by mail-wm0-f68.google.com with SMTP id l16so1273378wmh.3 for ; Mon, 19 Mar 2018 23:49:32 -0700 (PDT) Received: from rst.Home ([2a02:c7d:692a:c500:1ebc:73f3:5f60:b131]) by smtp.gmail.com with ESMTPSA id g38sm1923269wra.77.2018.03.19.23.49.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Mar 2018 23:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=P2EwZUZ4LstnHhjtrf8VI9REcLfKzJLFw2frusdkRYM=; b=rN0SDkHPbODg46jo+6y6ylsrd51bpxGliJnnOVtMjssIj+Cs0HxWbkLnaJSXFIN7qc wFaktjc5dLVkgVSvMXXJajfWy2ubfoY7y94J0/gQf7D4i2XEfiTKqlU5z4im/CNFOGLu JV5ArYtyfEj7dINp8hqT7UJMpf2ivsnProoRDsWvx0RfdBGS/oXe1/v16Z+vfAHnAzDa c4V3O5kpU8KgZ4FIkXPACDlP5dnyNPbOQG/eom003UIwTlgOyFhJIuf9jRZkHaiPXL73 owmEzVUXztgQjJIVFkR379uMZv9p6p9C7dUhaPix+5FTJHyDfHvjHAHiWXuCnOxT6V51 vsMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P2EwZUZ4LstnHhjtrf8VI9REcLfKzJLFw2frusdkRYM=; b=BVVdTBvxgmjFZGCwCUGkZEP5aEdg/PCgqkW7xOBx+gfK2dWQ6ql2n4Bs5Ou7MRzYmB DPo7DHasxPj5rmM26ZMb3LbQ/cJAzraVxgmlJ/6il/3Wb3JbS4jETq/0FPTbrrpidegC vFGTs1uz+9W4tZUOziR5l7rvw1D9G10Mz17hVY+Ef9p7tHtM9d2yPwabWpgsRZLGAYvM AgRknW7Q5pZ74zQ22nKsitT61Khjdf31xOcNmcB0MlRdNGR+cIhI9GjAfPQbtDpLfgxf ZujG9P5zVTUtiBNRK/aPo5MYWj6E8fAaf7uNHzZ8mBgDtevaJkn0ZPUN6l9DZ4N1kt7M t9Cw== X-Gm-Message-State: AElRT7HVx8dkBXklaJ+U3Zq3mlYdeR8/FmOwANIpOCwUTUW3+djlRHhD HlXPzy56DcqEh8JosiG8R+1JPYXk X-Google-Smtp-Source: AG47ELtaI5WYosIs6ZZVNkgsojljR23ATJeI6vrQrpjJ4/F+yosI46oTpvVlpLyz1nMZdS5eqjblCg== X-Received: by 10.28.32.210 with SMTP id g201mr937007wmg.9.1521528571143; Mon, 19 Mar 2018 23:49:31 -0700 (PDT) From: Radostin Stoyanov To: libvir-list@redhat.com Date: Tue, 20 Mar 2018 06:48:49 +0000 Message-Id: <20180320064908.17723-7-rstoyanov1@gmail.com> In-Reply-To: <20180320064908.17723-1-rstoyanov1@gmail.com> References: <20180320064908.17723-1-rstoyanov1@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 20 Mar 2018 06:49:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 20 Mar 2018 06:49:33 +0000 (UTC) for IP:'74.125.82.68' DOMAIN:'mail-wm0-f68.google.com' HELO:'mail-wm0-f68.google.com' FROM:'rstoyanov1@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.12 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.82.68 mail-wm0-f68.google.com 74.125.82.68 mail-wm0-f68.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Radostin Stoyanov Subject: [libvirt] [PATCHv2 06/25] esx_vi_generator: Simplify generate_helper_header X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 20 Mar 2018 06:49:58 +0000 (UTC) X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The function generate_helper_header() only returns a formatted string. This could be achieved without performing string concatenation. Signed-off-by: Radostin Stoyanov --- src/esx/esx_vi_generator.py | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py index 8f581c41e..95521fa1e 100755 --- a/src/esx/esx_vi_generator.py +++ b/src/esx/esx_vi_generator.py @@ -1021,20 +1021,16 @@ class ManagedObject(GenericObject): =20 =20 def generate_helper_header(self): - header =3D "" - # functions - header +=3D ("int esxVI_Lookup%s(esxVI_Context *ctx, " - "const char *name, " - "esxVI_ManagedObjectReference *root,= " - "esxVI_String *selectedPropertyNameL= ist, " - "esxVI_%s **item, " - "esxVI_Occurrence occurrence);\n") \ - % (self.name, self.name) - - header +=3D "\n" - - return header + return ( + "int esxVI_Lookup%(name)s(esxVI_Context *ctx," + " const char *name," + " esxVI_ManagedObjectReference *root," + " esxVI_String *selectedPropertyNameL= ist," + " esxVI_%(name)s **item," + " esxVI_Occurrence occurrence);\n\n" + % {"name": self.name} + ) =20 =20 def generate_source(self): --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list