[libvirt] [PATCH 1/2] util: honor reportError parameter in virSocketAddrParseInternal

Jim Fehlig posted 2 patches 7 years, 1 month ago
[libvirt] [PATCH 1/2] util: honor reportError parameter in virSocketAddrParseInternal
Posted by Jim Fehlig 7 years, 1 month ago
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 src/util/virsocketaddr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index 95b527436..31a740cb8 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
@@ -107,7 +107,8 @@ virSocketAddrParseInternal(struct addrinfo **res,
     int err;
 
     if (val == NULL) {
-        virReportError(VIR_ERR_INVALID_ARG, "%s", _("Missing address"));
+        if (reportError)
+            virReportError(VIR_ERR_INVALID_ARG, "%s", _("Missing address"));
         return -1;
     }
 
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/2] util: honor reportError parameter in virSocketAddrParseInternal
Posted by John Ferlan 7 years, 1 month ago

On 03/26/2018 04:29 PM, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
>  src/util/virsocketaddr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

May was well wait for 4.2.0 to be released before pushing...

John

> diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
> index 95b527436..31a740cb8 100644
> --- a/src/util/virsocketaddr.c
> +++ b/src/util/virsocketaddr.c
> @@ -107,7 +107,8 @@ virSocketAddrParseInternal(struct addrinfo **res,
>      int err;
>  
>      if (val == NULL) {
> -        virReportError(VIR_ERR_INVALID_ARG, "%s", _("Missing address"));
> +        if (reportError)
> +            virReportError(VIR_ERR_INVALID_ARG, "%s", _("Missing address"));
>          return -1;
>      }
>  
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list