Impement some APIs for network Interface

[libvirt] [dbus PATCH 05/10] Rename virtDBusEventsRegisterEvent to virtDBusDomainEventsRegisterEvent

Posted by Katerina Koukiou 7 years, 8 months ago

This function was specific to Domain Lifecycle Events.
Rename it now, so that we can keep consistent naming when introducing
Events for other entities.

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 src/events.c | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/events.c b/src/events.c
index eb85a3a..c6896d4 100644
--- a/src/events.c
+++ b/src/events.c
@@ -171,9 +171,9 @@ virtDBusEventsDomainDiskChange(virConnectPtr connection G_GNUC_UNUSED,
 }
 
 static void
-virtDBusEventsRegisterEvent(virtDBusConnect *connect,
-                            gint id,
-                            virConnectDomainEventGenericCallback callback)
+virtDBusDomainEventsRegisterEvent(virtDBusConnect *connect,
+                                  gint id,
+                                  virConnectDomainEventGenericCallback callback)
 {
     g_assert(connect->callback_ids[id] == -1);
 
@@ -188,24 +188,24 @@ virtDBusEventsRegisterEvent(virtDBusConnect *connect,
 void
 virtDBusEventsRegister(virtDBusConnect *connect)
 {
-    virtDBusEventsRegisterEvent(connect,
-                                VIR_DOMAIN_EVENT_ID_LIFECYCLE,
-                                VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainLifecycle));
+    virtDBusDomainEventsRegisterEvent(connect,
+                                      VIR_DOMAIN_EVENT_ID_LIFECYCLE,
+                                      VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainLifecycle));
 
-    virtDBusEventsRegisterEvent(connect,
-                                VIR_DOMAIN_EVENT_ID_DEVICE_ADDED,
-                                VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainDeviceAdded));
+    virtDBusDomainEventsRegisterEvent(connect,
+                                      VIR_DOMAIN_EVENT_ID_DEVICE_ADDED,
+                                      VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainDeviceAdded));
 
-    virtDBusEventsRegisterEvent(connect,
-                                VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED,
-                                VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainDeviceRemoved));
+    virtDBusDomainEventsRegisterEvent(connect,
+                                      VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED,
+                                      VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainDeviceRemoved));
 
-    virtDBusEventsRegisterEvent(connect,
-                                VIR_DOMAIN_EVENT_ID_DISK_CHANGE,
-                                VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainDiskChange));
+    virtDBusDomainEventsRegisterEvent(connect,
+                                      VIR_DOMAIN_EVENT_ID_DISK_CHANGE,
+                                      VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainDiskChange));
 
-    virtDBusEventsRegisterEvent(connect,
-                                VIR_DOMAIN_EVENT_ID_TRAY_CHANGE,
-                                VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainTrayChange));
+    virtDBusDomainEventsRegisterEvent(connect,
+                                      VIR_DOMAIN_EVENT_ID_TRAY_CHANGE,
+                                      VIR_DOMAIN_EVENT_CALLBACK(virtDBusEventsDomainTrayChange));
 
 }
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 05/10] Rename virtDBusEventsRegisterEvent to virtDBusDomainEventsRegisterEvent

Posted by Pavel Hrdina 7 years, 8 months ago

On Thu, Apr 05, 2018 at 03:29:29PM +0200, Katerina Koukiou wrote:
> This function was specific to Domain Lifecycle Events.
> Rename it now, so that we can keep consistent naming when introducing
> Events for other entities.
> 
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---
>  src/events.c | 36 ++++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/src/events.c b/src/events.c
> index eb85a3a..c6896d4 100644
> --- a/src/events.c
> +++ b/src/events.c
> @@ -171,9 +171,9 @@ virtDBusEventsDomainDiskChange(virConnectPtr connection G_GNUC_UNUSED,
>  }
>  
>  static void
> -virtDBusEventsRegisterEvent(virtDBusConnect *connect,
> -                            gint id,
> -                            virConnectDomainEventGenericCallback callback)
> +virtDBusDomainEventsRegisterEvent(virtDBusConnect *connect,

The name should be virtDBusEventsRegisterDomainEvent.  virtDBusEvents
is prefix for this file.

> +                                  gint id,
> +                                  virConnectDomainEventGenericCallback callback)
>  {
>      g_assert(connect->callback_ids[id] == -1);

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list