From nobody Wed May 14 16:12:50 2025
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28
 as permitted sender) client-ip=209.132.183.28;
 envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com;
Authentication-Results: mx.zohomail.com;
	spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com
Return-Path: <libvir-list-bounces@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by
 mx.zohomail.com
	with SMTPS id 1523013872836557.5687889605425;
 Fri, 6 Apr 2018 04:24:32 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 96DB0356DE;
	Fri,  6 Apr 2018 11:24:31 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 709D92CFD4;
	Fri,  6 Apr 2018 11:24:31 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 39E174CAA1;
	Fri,  6 Apr 2018 11:24:31 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
	[10.11.54.6])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id w36BKhJK027353 for <libvir-list@listman.util.phx.redhat.com>;
	Fri, 6 Apr 2018 07:20:43 -0400
Received: by smtp.corp.redhat.com (Postfix)
	id 28EF12166BC7; Fri,  6 Apr 2018 11:20:43 +0000 (UTC)
Received: from katerina.brq.redhat.com (unknown [10.43.2.101])
	by smtp.corp.redhat.com (Postfix) with ESMTP id BBDB82166BAE
	for <libvir-list@redhat.com>; Fri,  6 Apr 2018 11:20:42 +0000 (UTC)
From: Katerina Koukiou <kkoukiou@redhat.com>
To: libvir-list@redhat.com
Date: Fri,  6 Apr 2018 13:20:34 +0200
Message-Id: <20180406112034.31179-10-kkoukiou@redhat.com>
In-Reply-To: <20180406112034.31179-1-kkoukiou@redhat.com>
References: <20180406112034.31179-1-kkoukiou@redhat.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-loop: libvir-list@redhat.com
Subject: [libvirt] [dbus PATCH 9/9] Implement Setter for Autostart property
	of Network Interface.
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	<libvir-list.redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/libvir-list>,
	<mailto:libvir-list-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/libvir-list>
List-Post: <mailto:libvir-list@redhat.com>
List-Help: <mailto:libvir-list-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/libvir-list>,
	<mailto:libvir-list-request@redhat.com?subject=subscribe>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted,
 not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]);
 Fri, 06 Apr 2018 11:24:32 +0000 (UTC)
X-ZohoMail: RSF_0  Z_629925259 SPT_0
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---
 data/org.libvirt.Network.xml |  5 +++--
 src/network.c                | 22 +++++++++++++++++++++-
 test/test_network.py         |  8 ++++++++
 3 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/data/org.libvirt.Network.xml b/data/org.libvirt.Network.xml
index 863f4d2..1d89ae3 100644
--- a/data/org.libvirt.Network.xml
+++ b/data/org.libvirt.Network.xml
@@ -7,9 +7,10 @@
       <annotation name=3D"org.gtk.GDBus.DocString"
         value=3D"See https://libvirt.org/html/libvirt-libvirt-network.html=
#virNetworkIsActive"/>
     </property>
-    <property name=3D"Autostart" type=3D"b" access=3D"read">
+    <property name=3D"Autostart" type=3D"b" access=3D"readwrite">
       <annotation name=3D"org.gtk.GDBus.DocString"
-        value=3D"See https://libvirt.org/html/libvirt-libvirt-network.html=
#virNetworkGetAutostart"/>
+          value=3D"See https://libvirt.org/html/libvirt-libvirt-network.ht=
ml#virNetworkGetAutostart and
+                 https://libvirt.org/html/libvirt-libvirt-network.html#vir=
NetworkSetAutostart"/>
     </property>
     <property name=3D"BridgeName" type=3D"s" access=3D"read">
       <annotation name=3D"org.gtk.GDBus.DocString"
diff --git a/src/network.c b/src/network.c
index 5ca1379..1448777 100644
--- a/src/network.c
+++ b/src/network.c
@@ -149,6 +149,26 @@ virtDBusNetworkGetUUID(const gchar *objectPath,
     *value =3D g_variant_new("s", uuid);
 }
=20
+static void
+virtDBusNetworkSetAutostart(GVariant *value,
+                            const gchar *objectPath,
+                            gpointer userData,
+                            GError **error)
+{
+    virtDBusConnect *connect =3D userData;
+    g_autoptr(virNetwork) network =3D NULL;
+    gboolean autostart;
+
+    g_variant_get(value, "b", &autostart);
+
+    network =3D virtDBusNetworkGetVirNetwork(connect, objectPath, error);
+    if (!network)
+        return;
+
+    if (virNetworkSetAutostart(network, autostart) < 0)
+        return virtDBusUtilSetLastVirtError(error);
+}
+
 static void
 virtDBusNetworkCreate(GVariant *inArgs G_GNUC_UNUSED,
                       GUnixFDList *inFDs G_GNUC_UNUSED,
@@ -238,7 +258,7 @@ virtDBusNetworkUndefine(GVariant *inArgs G_GNUC_UNUSED,
=20
 static virtDBusGDBusPropertyTable virtDBusNetworkPropertyTable[] =3D {
     { "Active", virtDBusNetworkGetActive, NULL },
-    { "Autostart", virtDBusNetworkGetAutostart, NULL },
+    { "Autostart", virtDBusNetworkGetAutostart, virtDBusNetworkSetAutostar=
t },
     { "BridgeName", virtDBusNetworkGetBridgeName, NULL },
     { "Name", virtDBusNetworkGetName, NULL },
     { "Persistent", virtDBusNetworkGetPersistent, NULL },
diff --git a/test/test_network.py b/test/test_network.py
index a5987e5..0dda923 100755
--- a/test/test_network.py
+++ b/test/test_network.py
@@ -19,6 +19,14 @@ class TestNetwork(libvirttest.BaseTestClass):
         assert isinstance(props['Persistent'], dbus.Boolean)
         assert isinstance(props['UUID'], dbus.String)
=20
+    def test_network_autostart(self):
+        _,test_network =3D self.test_network()
+        interface_obj =3D dbus.Interface(test_network, 'org.libvirt.Networ=
k')
+        autostart_expected =3D True
+        interface_obj.Set('org.libvirt.Network', 'Autostart', autostart_ex=
pected, dbus_interface=3Ddbus.PROPERTIES_IFACE)
+        autostart_current =3D interface_obj.Get('org.libvirt.Network', 'Au=
tostart', dbus_interface=3Ddbus.PROPERTIES_IFACE)
+        assert autostart_current =3D=3D dbus.Boolean(autostart_expected)
+
     def test_network_create(self):
         def domain_started(path, _event):
             assert isinstance(path, dbus.ObjectPath)
--=20
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list