From nobody Wed May 14 16:09:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1523013661471384.6607902101654; Fri, 6 Apr 2018 04:21:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAC75C058ECE; Fri, 6 Apr 2018 11:20:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF70618823; Fri, 6 Apr 2018 11:20:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 803A71800CA0; Fri, 6 Apr 2018 11:20:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w36BKcZw027284 for ; Fri, 6 Apr 2018 07:20:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8732E2166BC7; Fri, 6 Apr 2018 11:20:38 +0000 (UTC) Received: from katerina.brq.redhat.com (unknown [10.43.2.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25E7E2166BAE for ; Fri, 6 Apr 2018 11:20:38 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Fri, 6 Apr 2018 13:20:27 +0200 Message-Id: <20180406112034.31179-3-kkoukiou@redhat.com> In-Reply-To: <20180406112034.31179-1-kkoukiou@redhat.com> References: <20180406112034.31179-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 2/9] Add Domain prefix to CreateXML method, test and related functions. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 06 Apr 2018 11:21:00 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This method is domain specific and should be clear from the naming, so that we can later define *CreateXML methods for other entities. Signed-off-by: Katerina Koukiou Reviewed-by: Pavel Hrdina --- data/org.libvirt.Connect.xml | 2 +- src/connect.c | 16 ++++++++-------- test/test_connect.py | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 6aa07f6..c29076d 100644 --- a/data/org.libvirt.Connect.xml +++ b/data/org.libvirt.Connect.xml @@ -13,7 +13,7 @@ - + diff --git a/src/connect.c b/src/connect.c index 85c85ee..3715d25 100644 --- a/src/connect.c +++ b/src/connect.c @@ -150,13 +150,13 @@ virtDBusConnectListDomains(GVariant *inArgs, } =20 static void -virtDBusConnectCreateXML(GVariant *inArgs, - GUnixFDList *inFDs G_GNUC_UNUSED, - const gchar *objectPath G_GNUC_UNUSED, - gpointer userData, - GVariant **outArgs, - GUnixFDList **outFDs G_GNUC_UNUSED, - GError **error) +virtDBusConnectDomainCreateXML(GVariant *inArgs, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath G_GNUC_UNUSED, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) { virtDBusConnect *connect =3D userData; g_autoptr(virDomain) domain =3D NULL; @@ -393,7 +393,7 @@ static virtDBusGDBusPropertyTable virtDBusConnectProper= tyTable[] =3D { =20 static virtDBusGDBusMethodTable virtDBusConnectMethodTable[] =3D { { "ListDomains", virtDBusConnectListDomains }, - { "CreateXML", virtDBusConnectCreateXML }, + { "DomainCreateXML", virtDBusConnectDomainCreateXML }, { "DefineXML", virtDBusConnectDefineXML }, { "DomainLookupByID", virtDBusDomainLookupByID }, { "DomainLookupByName", virtDBusDomainLookupByName }, diff --git a/test/test_connect.py b/test/test_connect.py index 5436a29..2b2031d 100755 --- a/test/test_connect.py +++ b/test/test_connect.py @@ -28,14 +28,14 @@ class TestConnect(libvirttest.BaseTestClass): # ensure the path exists by calling Introspect on it domain.Introspect(dbus_interface=3Ddbus.INTROSPECTABLE_IFACE) =20 - def test_create(self): + def test_connect_domain_create_xml(self): def domain_started(path, _event): assert isinstance(path, dbus.ObjectPath) self.loop.quit() =20 self.connect.connect_to_signal('DomainEvent', domain_started, arg1= =3D'Started') =20 - path =3D self.connect.CreateXML(self.minimal_domain_xml, 0) + path =3D self.connect.DomainCreateXML(self.minimal_domain_xml, 0) assert isinstance(path, dbus.ObjectPath) =20 self.main_loop() --=20 2.15.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list