This is very convenient for developers using the 'test' flavor,
because it ensures

  $ ./lcitool update all

still works by logging in as root, but at the same time ad-hoc
invocations such as

  $ ansible all -m shell -a 'cd libvirt && $MAKE -j check'

and custom playbooks log in as the 'test' user instead, and as
such have all the usual environment variables ($MAKE, $PYTHON,
$PATH, $VIRT_PREFIX and friends) available to them, which makes
testing changes locally a breeze.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/group_vars/all/main.yml | 2 --
 guests/site.yml                | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/guests/group_vars/all/main.yml b/guests/group_vars/all/main.yml
index 2bdb7b3..4e05c66 100644
--- a/guests/group_vars/all/main.yml
+++ b/guests/group_vars/all/main.yml
@@ -1,6 +1,4 @@
 ---
-ansible_user: root
-
 # This password is only used to access the guest the very first time
 # Ansible is used: afterwards, the user's SSH key will have been installed
 # in the guest and SSH password authentication will have been disabled
diff --git a/guests/site.yml b/guests/site.yml
index 26127be..520aea7 100644
--- a/guests/site.yml
+++ b/guests/site.yml
@@ -1,5 +1,6 @@
 ---
 - hosts: all
+  remote_user: root
   gather_facts: no
 
   tasks:
@@ -8,6 +9,7 @@
     - include: tasks/bootstrap.yml
 
 - hosts: all
+  remote_user: root
 
   vars_files:
     - vars/mappings.yml
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Apr 11, 2018 at 02:36:15PM +0200, Andrea Bolognani wrote:
> This is very convenient for developers using the 'test' flavor,
> because it ensures
> 
>   $ ./lcitool update all
> 
> still works by logging in as root, but at the same time ad-hoc
> invocations such as
> 
>   $ ansible all -m shell -a 'cd libvirt && $MAKE -j check'
> 
> and custom playbooks log in as the 'test' user instead, and as
> such have all the usual environment variables ($MAKE, $PYTHON,
> $PATH, $VIRT_PREFIX and friends) available to them, which makes
> testing changes locally a breeze.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/group_vars/all/main.yml | 2 --
>  guests/site.yml                | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list