Both gtk-vnc and gtk-vnc2 exist: the former is based on GTK+
2 and is considered deprecated, the latter uses GTK+ 3 and
it's actively developed.

We need the GTK+ 3-based version for our builds: make that
more explicit by renaming the mapping. The MinGW variant of
the mapping already does this.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/mappings.yml             | 2 +-
 guests/vars/projects/virt-viewer.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 1c1a872..f1777fe 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -164,7 +164,7 @@ mappings:
     default: gtk-doc
     deb: gtk-doc-tools
 
-  gtk-vnc:
+  gtk-vnc2:
     deb: libgtk-vnc-2.0-dev
     pkg: gtk-vnc
     rpm: gtk-vnc2-devel
diff --git a/guests/vars/projects/virt-viewer.yml b/guests/vars/projects/virt-viewer.yml
index 6f3dbf9..cd32176 100644
--- a/guests/vars/projects/virt-viewer.yml
+++ b/guests/vars/projects/virt-viewer.yml
@@ -1,7 +1,7 @@
 ---
 packages:
   - glib2
-  - gtk-vnc
+  - gtk-vnc2
   - gtk3
   - intltool
   - libgovirt
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Apr 16, 2018 at 06:47:56PM +0200, Andrea Bolognani wrote:
> Both gtk-vnc and gtk-vnc2 exist: the former is based on GTK+
> 2 and is considered deprecated, the latter uses GTK+ 3 and
> it's actively developed.
> 
> We need the GTK+ 3-based version for our builds: make that
> more explicit by renaming the mapping. The MinGW variant of
> the mapping already does this.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/vars/mappings.yml             | 2 +-
>  guests/vars/projects/virt-viewer.yml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list