[v2] Add function that raises error if domain is not active

[libvirt] [PATCH v2 9/9] vz: start using virDomainObjCheckActive

Posted by Clementine Hayat 7 years ago

Signed-off-by: Clementine Hayat <clem@lse.epita.fr>
---
 src/vz/vz_driver.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index e51d968f2..3094afccb 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -3998,11 +3998,8 @@ vzDomainBlockResize(virDomainPtr domain,
     if (vzEnsureDomainExists(dom) < 0)
         goto cleanup;
 
-    if (!virDomainObjIsActive(dom)) {
-        virReportError(VIR_ERR_OPERATION_INVALID,
-                       "%s", _("domain is not running"));
+    if (virDomainObjCheckActive(dom) < 0)
         goto cleanup;
-    }
 
     if (!(disk = virDomainDiskByName(dom->def, path, false))) {
         virReportError(VIR_ERR_INVALID_ARG,
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 9/9] vz: start using virDomainObjCheckActive

Posted by Ján Tomko 7 years ago

On Tue, Apr 17, 2018 at 10:13:34PM +0000, Clementine Hayat wrote:
>Signed-off-by: Clementine Hayat <clem@lse.epita.fr>
>---
> src/vz/vz_driver.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list