From nobody Wed May 14 16:55:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524065147276121.02718376764585; Wed, 18 Apr 2018 08:25:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B97FD3130382; Wed, 18 Apr 2018 15:25:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40B9F7CA0B; Wed, 18 Apr 2018 15:25:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3DDA1180BAD5; Wed, 18 Apr 2018 15:25:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3IFPW97006944 for ; Wed, 18 Apr 2018 11:25:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2CE401C727; Wed, 18 Apr 2018 15:25:32 +0000 (UTC) Received: from inaba.usersys.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4A781C723 for ; Wed, 18 Apr 2018 15:25:31 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Wed, 18 Apr 2018 17:25:22 +0200 Message-Id: <20180418152522.17923-6-abologna@redhat.com> In-Reply-To: <20180418152522.17923-1-abologna@redhat.com> References: <20180418152522.17923-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 5/5] jobs: Remove $CC override X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 18 Apr 2018 15:25:46 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Neither Go nor MinGW builds were able to deal with our previous way of enabling ccache correctly, which forced us to work around the issue at the job template level. Now that ccache is enabled in a completely transparent fashion through a symlink farm, we can drop the workaround. Signed-off-by: Andrea Bolognani --- jobs/defaults.yaml | 6 ------ jobs/go.yaml | 8 -------- 2 files changed, 14 deletions(-) diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml index 99e8b62..43686c5 100644 --- a/jobs/defaults.yaml +++ b/jobs/defaults.yaml @@ -23,17 +23,11 @@ global_env: | local_env: | mingw32_local_env: | - # The MinGW build needs to use the MinGW compiler toolchain, - # while $CC is pointing to the native toolchain, so we have - # to unset it here. - export CC=3D export VIRT_PREFIX=3D"$VIRT_PREFIX/i686-w64-mingw32/sys-root/mingw" export PKG_CONFIG_PATH=3D"$VIRT_PREFIX/lib/pkgconfig" export PKG_CONFIG_LIBDIR=3D"/usr/i686-w64-mingw32/sys-root/mingw/lib= /pkgconfig:/usr/i686-w64-mingw32/sys-root/mingw/share/pkgconfig" mingw32_autogen_args: --host=3Di686-w64-mingw32 mingw64_local_env: | - # See above - export CC=3D export VIRT_PREFIX=3D"$VIRT_PREFIX/x86_64-w64-mingw32/sys-root/mingw" export PKG_CONFIG_PATH=3D"$VIRT_PREFIX/lib/pkgconfig" export PKG_CONFIG_LIBDIR=3D"/usr/x86_64-w64-mingw32/sys-root/mingw/l= ib/pkgconfig:/usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig" diff --git a/jobs/go.yaml b/jobs/go.yaml index 9a349ca..bffe56e 100644 --- a/jobs/go.yaml +++ b/jobs/go.yaml @@ -42,11 +42,6 @@ - shell: | {global_env} {local_env} - # go doesn't handle the $CC variable containing whitespace - # correctly, so we have to make sure it's unset when building. - # See https://github.com/golang/go/issues/11685 - export CC=3D - go build -v publishers: - email: @@ -85,9 +80,6 @@ - shell: | {global_env} {local_env} - # See above - export CC=3D - go test $TEST_ARGS publishers: - email: --=20 2.14.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list