[libvirt] [dbus PATCH 4/8] Move definition for g_autoptr virDomainStatsRecordPtr to util.h

Katerina Koukiou posted 8 patches 7 years ago
[libvirt] [dbus PATCH 4/8] Move definition for g_autoptr virDomainStatsRecordPtr to util.h
Posted by Katerina Koukiou 7 years ago
We be reused in connect.c

Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 src/domain.c | 2 --
 src/util.h   | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/domain.c b/src/domain.c
index 6c44377..010758b 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -1017,8 +1017,6 @@ virtDBusDomainGetSchedulerParameters(GVariant *inArgs,
     *outArgs = g_variant_new_tuple(&grecords, 1);
 }
 
-G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainStatsRecordPtr, virDomainStatsRecordListFree);
-
 static void
 virtDBusDomainGetStats(GVariant *inArgs,
                        GUnixFDList *inFDs G_GNUC_UNUSED,
diff --git a/src/util.h b/src/util.h
index 7bb4ad6..5141172 100644
--- a/src/util.h
+++ b/src/util.h
@@ -38,6 +38,8 @@ virtDBusUtilVirDomainListFree(virDomainPtr *domains);
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomain, virDomainFree);
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainPtr, virtDBusUtilVirDomainListFree);
 
+G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainStatsRecordPtr, virDomainStatsRecordListFree);
+
 gint
 virtDBusUtilEnumFromString(const gchar *const *types,
                            guint ntypes,
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 4/8] Move definition for g_autoptr virDomainStatsRecordPtr to util.h
Posted by Ján Tomko 7 years ago
On Thu, Apr 19, 2018 at 03:58:03PM +0200, Katerina Koukiou wrote:
>We be reused in connect.c
>

s/We/Will/

>Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>---
> src/domain.c | 2 --
> src/util.h   | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 4/8] Move definition for g_autoptr virDomainStatsRecordPtr to util.h
Posted by Pavel Hrdina 7 years ago
On Thu, Apr 19, 2018 at 03:58:03PM +0200, Katerina Koukiou wrote:
> We be reused in connect.c

s/We/We'll/

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 4/8] Move definition for g_autoptr virDomainStatsRecordPtr to util.h
Posted by Pavel Hrdina 7 years ago
On Thu, Apr 19, 2018 at 04:47:51PM +0200, Pavel Hrdina wrote:
> On Thu, Apr 19, 2018 at 03:58:03PM +0200, Katerina Koukiou wrote:
> > We be reused in connect.c
> 
> s/We/We'll/

Ehm, ignore this, it supposed to be s/We/Will/.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list