1. Patchew
  2. Libvirt
  3. [libvirt] [dbus PATCH 0/8] Last APIs for Connect Interface
  4. View patch

[libvirt] [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface

Katerina Koukiou posted 8 patches 7 years ago
[libvirt] [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface
Posted by Katerina Koukiou 7 years ago 
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 data/org.libvirt.Connect.xml |  7 +++++++
 src/connect.c                | 40 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)

diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index e5504f7..3ef965d 100644
--- a/data/org.libvirt.Connect.xml
+++ b/data/org.libvirt.Connect.xml
@@ -94,6 +94,13 @@
       <arg name="flags" type="u" direction="in"/>
       <arg name="storagePoolSources" type="s" direction="out"/>
     </method>
+    <method name="GetAllDomainStats">
+      <annotation name="org.gtk.GDBus.DocString"
+        value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetAllDomainStats"/>
+      <arg name="stats" type="u" direction="in"/>
+      <arg name="flags" type="u" direction="in"/>
+      <arg name="records" type="av" direction="out"/>
+    </method>
     <method name="GetCapabilities">
       <annotation name="org.gtk.GDBus.DocString"
         value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetCapabilities"/>
diff --git a/src/connect.c b/src/connect.c
index 4e64238..e774fa4 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -503,6 +503,45 @@ virtDBusConnectFindStoragePoolSources(GVariant *inArgs,
     *outArgs = g_variant_new("(s)", ret);
 }
 
+static void
+virtDBusConnectGetAllDomainStats(GVariant *inArgs,
+                                 GUnixFDList *inFDs G_GNUC_UNUSED,
+                                 const gchar *objectPath G_GNUC_UNUSED,
+                                 gpointer userData,
+                                 GVariant **outArgs,
+                                 GUnixFDList **outFDs G_GNUC_UNUSED,
+                                 GError **error)
+{
+    virtDBusConnect *connect = userData;
+    g_autoptr(virDomainStatsRecordPtr) records = NULL;
+    guint stats;
+    gint nstats;
+    guint flags;
+    GVariant *grecords;
+    GVariant *gret;
+    GVariantBuilder builder;
+
+    g_variant_get(inArgs, "(uu)", &stats, &flags);
+
+    if (!virtDBusConnectOpen(connect, error))
+        return;
+
+    nstats = virConnectGetAllDomainStats(connect->connection,
+                                         stats, &records, flags);
+    if (nstats < 0)
+        return virtDBusUtilSetLastVirtError(error);
+
+    g_variant_builder_init(&builder, G_VARIANT_TYPE("av"));
+    for (gint i = 0; i < nstats; i++) {
+        grecords = virtDBusUtilTypedParamsToGVariant(records[i]->params,
+                                                     records[i]->nparams);
+        g_variant_builder_add(&builder, "v", grecords);
+    }
+    gret = g_variant_builder_end(&builder);
+
+    *outArgs = g_variant_new_tuple(&gret, 1);
+}
+
 static void
 virtDBusConnectGetSysinfo(GVariant *inArgs,
                           GUnixFDList *inFDs G_GNUC_UNUSED,
@@ -741,6 +780,7 @@ static virtDBusGDBusMethodTable virtDBusConnectMethodTable[] = {
     { "DomainRestore", virtDBusConnectDomainRestoreFlags },
     { "DomainSaveImageDefineXML", virtDBusConnectDomainSaveImageDefineXML },
     { "FindStoragePoolSources", virtDBusConnectFindStoragePoolSources },
+    { "GetAllDomainStats", virtDBusConnectGetAllDomainStats },
     { "GetCapabilities", virtDBusConnectGetCapabilities },
     { "GetSysinfo", virtDBusConnectGetSysinfo },
     { "ListDomains", virtDBusConnectListDomains },
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface
Posted by Ján Tomko 7 years ago 
On Thu, Apr 19, 2018 at 03:58:04PM +0200, Katerina Koukiou wrote:
>Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>---
> data/org.libvirt.Connect.xml |  7 +++++++
> src/connect.c                | 40 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
>diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
>index e5504f7..3ef965d 100644
>--- a/data/org.libvirt.Connect.xml
>+++ b/data/org.libvirt.Connect.xml
>@@ -94,6 +94,13 @@
>       <arg name="flags" type="u" direction="in"/>
>       <arg name="storagePoolSources" type="s" direction="out"/>
>     </method>
>+    <method name="GetAllDomainStats">
>+      <annotation name="org.gtk.GDBus.DocString"
>+        value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetAllDomainStats"/>

This one is documented in https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectGetAllDomainStats

Given that our API names are set in stone but our website URLs are not,
maybe we need some stable link that would redirect to the correct doc
page when given an API name.

Jano

>+      <arg name="stats" type="u" direction="in"/>
>+      <arg name="flags" type="u" direction="in"/>
>+      <arg name="records" type="av" direction="out"/>
>+    </method>
>     <method name="GetCapabilities">
>       <annotation name="org.gtk.GDBus.DocString"
>         value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetCapabilities"/>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface
Posted by Katerina Koukiou 7 years ago 
On Thu, 2018-04-19 at 16:45 +0200, Ján Tomko wrote:
> On Thu, Apr 19, 2018 at 03:58:04PM +0200, Katerina Koukiou wrote:
> > Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> > ---
> > data/org.libvirt.Connect.xml |  7 +++++++
> > src/connect.c                | 40
> > ++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 47 insertions(+)
> > 
> > diff --git a/data/org.libvirt.Connect.xml
> > b/data/org.libvirt.Connect.xml
> > index e5504f7..3ef965d 100644
> > --- a/data/org.libvirt.Connect.xml
> > +++ b/data/org.libvirt.Connect.xml
> > @@ -94,6 +94,13 @@
> >       <arg name="flags" type="u" direction="in"/>
> >       <arg name="storagePoolSources" type="s" direction="out"/>
> >     </method>
> > +    <method name="GetAllDomainStats">
> > +      <annotation name="org.gtk.GDBus.DocString"
> > +        value="See https://libvirt.org/html/libvirt-libvirt-host.h
> > tml#virConnectGetAllDomainStats"/>;
> 
> This one is documented in https://libvirt.org/html/libvirt-libvirt-do
> main.html#virConnectGetAllDomainStats
> 
> Given that our API names are set in stone but our website URLs are
> not,
> maybe we need some stable link that would redirect to the correct doc
> page when given an API name.
> 

Yes, good point. The docs need to be enhanced in general anyway.

> Jano
> 
> > +      <arg name="stats" type="u" direction="in"/>
> > +      <arg name="flags" type="u" direction="in"/>
> > +      <arg name="records" type="av" direction="out"/>
> > +    </method>
> >     <method name="GetCapabilities">
> >       <annotation name="org.gtk.GDBus.DocString"
> >         value="See https://libvirt.org/html/libvirt-libvirt-host.ht
> > ml#virConnectGetCapabilities"/>;

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface
Posted by Pavel Hrdina 7 years ago 
On Thu, Apr 19, 2018 at 03:58:04PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> ---
>  data/org.libvirt.Connect.xml |  7 +++++++
>  src/connect.c                | 40 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+)
> 
> diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
> index e5504f7..3ef965d 100644
> --- a/data/org.libvirt.Connect.xml
> +++ b/data/org.libvirt.Connect.xml
> @@ -94,6 +94,13 @@
>        <arg name="flags" type="u" direction="in"/>
>        <arg name="storagePoolSources" type="s" direction="out"/>
>      </method>
> +    <method name="GetAllDomainStats">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetAllDomainStats"/>
> +      <arg name="stats" type="u" direction="in"/>
> +      <arg name="flags" type="u" direction="in"/>
> +      <arg name="records" type="av" direction="out"/>

The return type should be "a(sa{sv})" because it returns stats for
multiple domains.  For example:

[
    ( "centos6", { "state.state": 1, "state.reason": 1 } ),
    ( "centos7", { "state.state": 5, "state.reason": 1 } )
]

and the code needs to be updated accordingly.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.