From nobody Wed May 14 16:31:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524146310740748.1277849988386; Thu, 19 Apr 2018 06:58:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6070F23E6CE; Thu, 19 Apr 2018 13:58:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2840C85F8B; Thu, 19 Apr 2018 13:58:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 87180180BADB; Thu, 19 Apr 2018 13:58:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3JDwG9j000704 for ; Thu, 19 Apr 2018 09:58:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6D2B642226; Thu, 19 Apr 2018 13:58:16 +0000 (UTC) Received: from katerina.brq.redhat.com (unknown [10.43.2.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 110BE6F9E8 for ; Thu, 19 Apr 2018 13:58:15 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Thu, 19 Apr 2018 15:58:06 +0200 Message-Id: <20180419135807.28636-8-kkoukiou@redhat.com> In-Reply-To: <20180419135807.28636-1-kkoukiou@redhat.com> References: <20180419135807.28636-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 7/8] Implement GetCPUModelNames method for Connect Interface X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 19 Apr 2018 13:58:29 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Katerina Koukiou Reviewed-by: J=EF=BF=BDn Tomko --- data/org.libvirt.Connect.xml | 7 +++++++ src/connect.c | 35 +++++++++++++++++++++++++++++++++++ tests/test_connect.py | 4 ++++ 3 files changed, 46 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 3ef965d..43a6241 100644 --- a/data/org.libvirt.Connect.xml +++ b/data/org.libvirt.Connect.xml @@ -106,6 +106,13 @@ value=3D"See https://libvirt.org/html/libvirt-libvirt-host.html#vi= rConnectGetCapabilities"/> + + + + + + diff --git a/src/connect.c b/src/connect.c index e774fa4..169a070 100644 --- a/src/connect.c +++ b/src/connect.c @@ -542,6 +542,40 @@ virtDBusConnectGetAllDomainStats(GVariant *inArgs, *outArgs =3D g_variant_new_tuple(&gret, 1); } =20 +static void +virtDBusConnectGetCPUModelNames(GVariant *inArgs, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath G_GNUC_UNUSED, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) +{ + virtDBusConnect *connect =3D userData; + const gchar *arch; + guint flags; + g_autoptr(GCharArray) models =3D NULL; + gint nmodels; + GVariant *gret; + GVariantBuilder builder; + + g_variant_get(inArgs, "(&su)", &arch, &flags); + + if (!virtDBusConnectOpen(connect, error)) + return; + + nmodels =3D virConnectGetCPUModelNames(connect->connection, arch, &mod= els, flags); + if (nmodels < 0) + return virtDBusUtilSetLastVirtError(error); + + g_variant_builder_init(&builder, G_VARIANT_TYPE("as")); + for (gint i =3D 0; i < nmodels; i++) + g_variant_builder_add(&builder, "s", models[i]); + gret =3D g_variant_builder_end(&builder); + + *outArgs =3D g_variant_new_tuple(&gret, 1); +} + static void virtDBusConnectGetSysinfo(GVariant *inArgs, GUnixFDList *inFDs G_GNUC_UNUSED, @@ -782,6 +816,7 @@ static virtDBusGDBusMethodTable virtDBusConnectMethodTa= ble[] =3D { { "FindStoragePoolSources", virtDBusConnectFindStoragePoolSources }, { "GetAllDomainStats", virtDBusConnectGetAllDomainStats }, { "GetCapabilities", virtDBusConnectGetCapabilities }, + { "GetCPUModelNames", virtDBusConnectGetCPUModelNames }, { "GetSysinfo", virtDBusConnectGetSysinfo }, { "ListDomains", virtDBusConnectListDomains }, { "ListNetworks", virtDBusConnectListNetworks }, diff --git a/tests/test_connect.py b/tests/test_connect.py index d7ec704..57f0658 100755 --- a/tests/test_connect.py +++ b/tests/test_connect.py @@ -116,6 +116,10 @@ class TestConnect(libvirttest.BaseTestClass): def test_connect_get_capabilities(self): assert isinstance(self.connect.GetCapabilities(), dbus.String) =20 + def test_connect_get_cpu_model_names(self): + arch =3D "x86_64" + assert isinstance(self.connect.GetCPUModelNames(arch, 0), dbus.Arr= ay) + def test_connect_network_create_xml(self): def network_started(path, _event): assert isinstance(path, dbus.ObjectPath) --=20 2.15.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list