[libvirt] [PATCH 2/4] log: rename virLogFlags to virLogFilterFlags to match docs

Daniel P. Berrangé posted 4 patches 7 years ago
There is a newer version of this series
[libvirt] [PATCH 2/4] log: rename virLogFlags to virLogFilterFlags to match docs
Posted by Daniel P. Berrangé 7 years ago
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 src/util/virlog.c | 2 +-
 src/util/virlog.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/virlog.c b/src/util/virlog.c
index 5810643e1b..5262d613f6 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -87,7 +87,7 @@ VIR_ENUM_IMPL(virLogDestination, VIR_LOG_TO_OUTPUT_LAST,
 struct _virLogFilter {
     char *match;
     virLogPriority priority;
-    unsigned int flags;
+    unsigned int flags; /* bitwise OR of virLogFilterFlags */
 };
 
 static int virLogFiltersSerial = 1;
diff --git a/src/util/virlog.h b/src/util/virlog.h
index 8973f83b20..35dba16cfe 100644
--- a/src/util/virlog.h
+++ b/src/util/virlog.h
@@ -174,7 +174,7 @@ typedef void (*virLogCloseFunc) (void *data);
 
 typedef enum {
     VIR_LOG_STACK_TRACE = (1 << 0),
-} virLogFlags;
+} virLogFilterFlags;
 
 int virLogGetNbFilters(void);
 int virLogGetNbOutputs(void);
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/4] log: rename virLogFlags to virLogFilterFlags to match docs
Posted by Erik Skultety 7 years ago
On Fri, Apr 20, 2018 at 05:56:37PM +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/util/virlog.c | 2 +-
>  src/util/virlog.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/util/virlog.c b/src/util/virlog.c
> index 5810643e1b..5262d613f6 100644
> --- a/src/util/virlog.c
> +++ b/src/util/virlog.c
> @@ -87,7 +87,7 @@ VIR_ENUM_IMPL(virLogDestination, VIR_LOG_TO_OUTPUT_LAST,
>  struct _virLogFilter {
>      char *match;
>      virLogPriority priority;
> -    unsigned int flags;
> +    unsigned int flags; /* bitwise OR of virLogFilterFlags */
>  };
>
>  static int virLogFiltersSerial = 1;
> diff --git a/src/util/virlog.h b/src/util/virlog.h
> index 8973f83b20..35dba16cfe 100644
> --- a/src/util/virlog.h
> +++ b/src/util/virlog.h
> @@ -174,7 +174,7 @@ typedef void (*virLogCloseFunc) (void *data);
>
>  typedef enum {
>      VIR_LOG_STACK_TRACE = (1 << 0),
> -} virLogFlags;
> +} virLogFilterFlags;
>
>  int virLogGetNbFilters(void);
>  int virLogGetNbOutputs(void);

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list