1. Patchew
  2. Libvirt
  3. [libvirt] [dbus PATCH 00/15] Some more get APIs for Domain Interface
  4. View patch

[libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface

Katerina Koukiou posted 15 patches 7 years ago
[libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface
Posted by Katerina Koukiou 7 years ago 
Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
---
 data/org.libvirt.Domain.xml |  7 +++++++
 src/domain.c                | 40 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)

diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 2d8f6fe..6f80cc7 100644
--- a/data/org.libvirt.Domain.xml
+++ b/data/org.libvirt.Domain.xml
@@ -171,6 +171,13 @@
       <arg name="flags" type="u" direction="in"/>
       <arg name="BlkioParameters" type="a{sv}" direction="out"/>
     </method>
+    <method name="GetBlockIoTune">
+      <annotation name="org.gtk.GDBus.DocString"
+        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetBlockIoTune"/>
+      <arg name="disk" type="s" direction="in"/>
+      <arg name="flags" type="u" direction="in"/>
+      <arg name="blockIoTune" type="a{sv}" direction="out"/>
+    </method>
     <method name="GetControlInfo">
       <annotation name="org.gtk.GDBus.DocString"
         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetControlInfo"/>
diff --git a/src/domain.c b/src/domain.c
index b61e9f1..b4bdd34 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -866,6 +866,45 @@ virtDBusDomainGetBlkioParameters(GVariant *inArgs,
     *outArgs = g_variant_new_tuple(&grecords, 1);
 }
 
+static void
+virtDBusDomainGetBlockIoTune(GVariant *inArgs,
+                             GUnixFDList *inFDs G_GNUC_UNUSED,
+                             const gchar *objectPath,
+                             gpointer userData,
+                             GVariant **outArgs,
+                             GUnixFDList **outFDs G_GNUC_UNUSED,
+                             GError **error)
+{
+    virtDBusConnect *connect = userData;
+    g_autoptr(virDomain) domain = NULL;
+    g_auto(virtDBusUtilTypedParams) params = { 0 };
+    const gchar *disk;
+    guint flags;
+    gint ret;
+    GVariant *grecords;
+
+    g_variant_get(inArgs, "(&su)", &disk, &flags);
+
+    domain = virtDBusDomainGetVirDomain(connect, objectPath, error);
+    if (!domain)
+        return;
+
+    ret = virDomainGetBlockIoTune(domain, disk, NULL, &params.nparams, flags);
+    if (ret < 0)
+        return virtDBusUtilSetLastVirtError(error);
+    if (ret == 0 && params.nparams != 0) {
+        params.params = g_new0(virTypedParameter, params.nparams);
+        if (virDomainGetBlockIoTune(domain, disk, params.params,
+                                    &params.nparams, flags) < 0) {
+            return virtDBusUtilSetLastVirtError(error);
+        }
+    }
+
+    grecords = virtDBusUtilTypedParamsToGVariant(params.params, params.nparams);
+
+    *outArgs = g_variant_new_tuple(&grecords, 1);
+}
+
 static void
 virtDBusDomainGetControlInfo(GVariant *inArgs,
                              GUnixFDList *inFDs G_GNUC_UNUSED,
@@ -1986,6 +2025,7 @@ static virtDBusGDBusMethodTable virtDBusDomainMethodTable[] = {
     { "FSThaw", virtDBusDomainFSThaw },
     { "FSTrim", virtDBusDomainFSTrim },
     { "GetBlkioParameters", virtDBusDomainGetBlkioParameters },
+    { "GetBlockIoTune", virtDBusDomainGetBlockIoTune },
     { "GetControlInfo", virtDBusDomainGetControlInfo },
     { "GetJobInfo", virtDBusDomainGetJobInfo },
     { "GetMemoryParameters", virtDBusDomainGetMemoryParameters },
-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface
Posted by Ján Tomko 7 years ago 
On Wed, Apr 25, 2018 at 12:20:18PM +0200, Katerina Koukiou wrote:
>Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>---
> data/org.libvirt.Domain.xml |  7 +++++++
> src/domain.c                | 40 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
>diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
>index 2d8f6fe..6f80cc7 100644
>--- a/data/org.libvirt.Domain.xml
>+++ b/data/org.libvirt.Domain.xml
>@@ -171,6 +171,13 @@
>       <arg name="flags" type="u" direction="in"/>
>       <arg name="BlkioParameters" type="a{sv}" direction="out"/>
>     </method>
>+    <method name="GetBlockIoTune">

s/Io/IO/

it's capitalized in every API implemented so far

>+      <annotation name="org.gtk.GDBus.DocString"
>+        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetBlockIoTune"/>
>+      <arg name="disk" type="s" direction="in"/>
>+      <arg name="flags" type="u" direction="in"/>
>+      <arg name="blockIoTune" type="a{sv}" direction="out"/>

here too

>+    </method>
>     <method name="GetControlInfo">
>       <annotation name="org.gtk.GDBus.DocString"
>         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetControlInfo"/>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface
Posted by Katerina Koukiou 7 years ago 
On Wed, 2018-04-25 at 13:43 +0200, Ján Tomko wrote:
> On Wed, Apr 25, 2018 at 12:20:18PM +0200, Katerina Koukiou wrote:
> > Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
> > ---
> > data/org.libvirt.Domain.xml |  7 +++++++
> > src/domain.c                | 40
> > ++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 47 insertions(+)
> > 
> > diff --git a/data/org.libvirt.Domain.xml
> > b/data/org.libvirt.Domain.xml
> > index 2d8f6fe..6f80cc7 100644
> > --- a/data/org.libvirt.Domain.xml
> > +++ b/data/org.libvirt.Domain.xml
> > @@ -171,6 +171,13 @@
> >       <arg name="flags" type="u" direction="in"/>
> >       <arg name="BlkioParameters" type="a{sv}" direction="out"/>
> >     </method>
> > +    <method name="GetBlockIoTune">
> 
> s/Io/IO/
> 
> it's capitalized in every API implemented so far'

I follow the convention that I keep the method name as the original API
name, apart from when there is the `Flags` suffix. Would you mind if we
keep using this approach?

Katerina

> 
> > +      <annotation name="org.gtk.GDBus.DocString"
> > +        value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetBlockIoTune"/>;
> > +      <arg name="disk" type="s" direction="in"/>
> > +      <arg name="flags" type="u" direction="in"/>
> > +      <arg name="blockIoTune" type="a{sv}" direction="out"/>
> 
> here too
> 
> > +    </method>
> >     <method name="GetControlInfo">
> >       <annotation name="org.gtk.GDBus.DocString"
> >         value="See https://libvirt.org/html/libvirt-libvirt-domain.
> > html#virDomainGetControlInfo"/>;
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> 
> Jano

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [dbus PATCH 03/15] Implement GetBlockIoTune method for Domain Interface
Posted by Ján Tomko 7 years ago 
On Wed, Apr 25, 2018 at 02:58:12PM +0200, Katerina Koukiou wrote:
>On Wed, 2018-04-25 at 13:43 +0200, Ján Tomko wrote:
>> On Wed, Apr 25, 2018 at 12:20:18PM +0200, Katerina Koukiou wrote:
>> > Signed-off-by: Katerina Koukiou <kkoukiou@redhat.com>
>> > ---
>> > data/org.libvirt.Domain.xml |  7 +++++++
>> > src/domain.c                | 40
>> > ++++++++++++++++++++++++++++++++++++++++
>> > 2 files changed, 47 insertions(+)
>> >
>> > diff --git a/data/org.libvirt.Domain.xml
>> > b/data/org.libvirt.Domain.xml
>> > index 2d8f6fe..6f80cc7 100644
>> > --- a/data/org.libvirt.Domain.xml
>> > +++ b/data/org.libvirt.Domain.xml
>> > @@ -171,6 +171,13 @@
>> >       <arg name="flags" type="u" direction="in"/>
>> >       <arg name="BlkioParameters" type="a{sv}" direction="out"/>
>> >     </method>
>> > +    <method name="GetBlockIoTune">
>>
>> s/Io/IO/
>>
>> it's capitalized in every API implemented so far'
>
>I follow the convention that I keep the method name as the original API
>name, apart from when there is the `Flags` suffix. Would you mind if we
>keep using this approach?
>

Yes, I would mind.

But the explanation makes sense.
With or without the name change:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.