From nobody Wed May 14 08:56:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1525704073403175.30930694546214; Mon, 7 May 2018 07:41:13 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 45FDE81DE6; Mon, 7 May 2018 14:41:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 298AD5C293; Mon, 7 May 2018 14:41:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 826B01809547; Mon, 7 May 2018 14:41:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w47Ef4BM032357 for ; Mon, 7 May 2018 10:41:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id F3C902024CA2; Mon, 7 May 2018 14:41:03 +0000 (UTC) Received: from katerina.brq.redhat.com (unknown [10.43.2.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 990AA2024CA1 for ; Mon, 7 May 2018 14:41:03 +0000 (UTC) From: Katerina Koukiou To: libvir-list@redhat.com Date: Mon, 7 May 2018 16:40:43 +0200 Message-Id: <20180507144100.25045-3-kkoukiou@redhat.com> In-Reply-To: <20180507144100.25045-1-kkoukiou@redhat.com> References: <20180507144100.25045-1-kkoukiou@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Subject: [libvirt] [dbus PATCH 02/19] Implement ListStoragePools method for Connect Interface X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 07 May 2018 14:41:12 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++++++ src/connect.c | 40 ++++++++++++++++++++++++++++++++++++++++ tests/test_connect.py | 12 ++++++++++++ 3 files changed, 58 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index a235872..9207295 100644 --- a/data/org.libvirt.Connect.xml +++ b/data/org.libvirt.Connect.xml @@ -145,6 +145,12 @@ + + + + + diff --git a/src/connect.c b/src/connect.c index e838e98..858db43 100644 --- a/src/connect.c +++ b/src/connect.c @@ -709,6 +709,45 @@ virtDBusConnectListNetworks(GVariant *inArgs, *outArgs =3D g_variant_new_tuple(&gnetworks, 1); } =20 +static void +virtDBusConnectListStoragePools(GVariant *inArgs, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath G_GNUC_UNUSED, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) +{ + virtDBusConnect *connect =3D userData; + g_autoptr(virStoragePoolPtr) storagePools =3D NULL; + guint flags; + GVariantBuilder builder; + GVariant *gstoragePools; + + g_variant_get(inArgs, "(u)", &flags); + + if (!virtDBusConnectOpen(connect, error)) + return; + + if (virConnectListAllStoragePools(connect->connection, &storagePools, + flags) < 0) { + return virtDBusUtilSetLastVirtError(error); + } + + g_variant_builder_init(&builder, G_VARIANT_TYPE("ao")); + + for (gint i =3D 0; storagePools[i]; i++) { + g_autofree gchar *path =3D NULL; + path =3D virtDBusUtilBusPathForVirStoragePool(storagePools[i], + connect->storagePoolPa= th); + + g_variant_builder_add(&builder, "o", path); + } + + gstoragePools =3D g_variant_builder_end(&builder); + *outArgs =3D g_variant_new_tuple(&gstoragePools, 1); +} + static void virtDBusConnectNetworkCreateXML(GVariant *inArgs, GUnixFDList *inFDs G_GNUC_UNUSED, @@ -1082,6 +1121,7 @@ static virtDBusGDBusMethodTable virtDBusConnectMethod= Table[] =3D { { "GetSysinfo", virtDBusConnectGetSysinfo }, { "ListDomains", virtDBusConnectListDomains }, { "ListNetworks", virtDBusConnectListNetworks }, + { "ListStoragePools", virtDBusConnectListStoragePools }, { "NetworkCreateXML", virtDBusConnectNetworkCreateXML }, { "NetworkDefineXML", virtDBusConnectNetworkDefineXML }, { "NetworkLookupByName", virtDBusConnectNetworkLookupByName }, diff --git a/tests/test_connect.py b/tests/test_connect.py index 3eeecb9..d8f05e8 100755 --- a/tests/test_connect.py +++ b/tests/test_connect.py @@ -126,6 +126,18 @@ class TestConnect(libvirttest.BaseTestClass): arch =3D "x86_64" assert isinstance(self.connect.GetCPUModelNames(arch, 0), dbus.Arr= ay) =20 + def test_connect_list_storage_pools(self): + storage_pools =3D self.connect.ListStoragePools(0) + assert isinstance(storage_pools, dbus.Array) + assert len(storage_pools) =3D=3D 1 + + for path in storage_pools: + assert isinstance(path, dbus.ObjectPath) + storage_pool =3D self.bus.get_object('org.libvirt', path) + + # ensure the path exists by calling Introspect on it + storage_pool.Introspect(dbus_interface=3Ddbus.INTROSPECTABLE_I= FACE) + def test_connect_network_create_xml(self): def network_started(path, event): if event !=3D libvirttest.NetworkEvent.STARTED: --=20 2.15.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list