Some fixes and improvement for virsh completion in non interactive mode

[libvirt] [PATCH v2 02/12] virsh: Add domain name completion to 'migrate-postcopy' command

Posted by Lin Ma 7 years ago

Signed-off-by: Lin Ma <lma@suse.com>
---
 tools/virsh-domain.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index aa11a81638..ace5c02871 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -11213,11 +11213,7 @@ static const vshCmdInfo info_migrate_postcopy[] = {
 };
 
 static const vshCmdOptDef opts_migrate_postcopy[] = {
-    {.name = "domain",
-     .type = VSH_OT_DATA,
-     .flags = VSH_OFLAG_REQ,
-     .help = N_("domain name, id or uuid")
-    },
+    VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE),
     {.name = NULL}
 };
 
-- 
2.15.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 02/12] virsh: Add domain name completion to 'migrate-postcopy' command

Posted by Michal Privoznik 7 years ago

On 05/08/2018 04:20 PM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma@suse.com>
> ---
>  tools/virsh-domain.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list