Some fixes and improvement for virsh completion in non interactive mode

[libvirt] [PATCH v2 04/12] virsh: Create macros for VSH_OT_STRING "domain" option

Posted by Lin Ma 7 years ago

Signed-off-by: Lin Ma <lma@suse.com>
---
 tools/virsh.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/virsh.h b/tools/virsh.h
index 9e717ef574..b1b641bc41 100644
--- a/tools/virsh.h
+++ b/tools/virsh.h
@@ -110,6 +110,17 @@
      .help = _helpstr \
     }
 
+# define VIRSH_COMMON_OPT_DOMAIN_OT_STRING(_helpstr, cflags) \
+    {.name = "domain", \
+     .type = VSH_OT_STRING, \
+     .help = _helpstr, \
+     .completer = virshDomainNameCompleter, \
+     .completer_flags = cflags, \
+    }
+
+#define VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL(cflags) \
+    VIRSH_COMMON_OPT_DOMAIN_OT_STRING(N_("domain name, id or uuid"), cflags)
+
 typedef struct _virshControl virshControl;
 typedef virshControl *virshControlPtr;
 
-- 
2.15.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 04/12] virsh: Create macros for VSH_OT_STRING "domain" option

Posted by Michal Privoznik 7 years ago

On 05/08/2018 04:20 PM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma@suse.com>
> ---
>  tools/virsh.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tools/virsh.h b/tools/virsh.h
> index 9e717ef574..b1b641bc41 100644
> --- a/tools/virsh.h
> +++ b/tools/virsh.h
> @@ -110,6 +110,17 @@
>       .help = _helpstr \
>      }
>  
> +# define VIRSH_COMMON_OPT_DOMAIN_OT_STRING(_helpstr, cflags) \
> +    {.name = "domain", \
> +     .type = VSH_OT_STRING, \
> +     .help = _helpstr, \
> +     .completer = virshDomainNameCompleter, \
> +     .completer_flags = cflags, \
> +    }
> +
> +#define VIRSH_COMMON_OPT_DOMAIN_OT_STRING_FULL(cflags) \
> +    VIRSH_COMMON_OPT_DOMAIN_OT_STRING(N_("domain name, id or uuid"), cflags)

Again, missing space after #.

ACK with that fixed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list