[libvirt] [jenkins-ci PATCH 1/3] jobs: Run commands after loading environments

Andrea Bolognani posted 3 patches 7 years ago
[libvirt] [jenkins-ci PATCH 1/3] jobs: Run commands after loading environments
Posted by Andrea Bolognani 7 years ago
The contents of either global_env or local_env might affect
the behavior of the build, so no command should be executed
before loading them both.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 jobs/perl-makemaker.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/jobs/perl-makemaker.yaml b/jobs/perl-makemaker.yaml
index 84b368e..065b38e 100644
--- a/jobs/perl-makemaker.yaml
+++ b/jobs/perl-makemaker.yaml
@@ -40,9 +40,9 @@
           values: '{obj:machines}'
     builders:
       - shell: |
-          perl Makefile.PL PREFIX="$VIRT_PREFIX"
           {global_env}
           {local_env}
+          perl Makefile.PL PREFIX="$VIRT_PREFIX"
           $MAKE
           $MAKE -j{smp} install
           $MAKE -j{smp} manifest
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 1/3] jobs: Run commands after loading environments
Posted by Erik Skultety 6 years, 12 months ago
On Thu, May 10, 2018 at 05:35:43PM +0200, Andrea Bolognani wrote:
> The contents of either global_env or local_env might affect
> the behavior of the build, so no command should be executed
> before loading them both.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list