[libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too

Andrea Bolognani posted 3 patches 7 years ago
[libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too
Posted by Andrea Bolognani 7 years ago
Perl jobs use the -test suffix instead of -check, which is
used everywhere else. Rename them in order to be consistent.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 jobs/perl-makemaker.yaml   | 6 +++---
 jobs/perl-modulebuild.yaml | 6 +++---
 projects/libvirt-perl.yaml | 4 ++--
 projects/libvirt-tck.yaml  | 4 ++--
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/jobs/perl-makemaker.yaml b/jobs/perl-makemaker.yaml
index 491b7fa..29bf2a1 100644
--- a/jobs/perl-makemaker.yaml
+++ b/jobs/perl-makemaker.yaml
@@ -54,10 +54,10 @@
 
 
 - job-template:
-    id: perl-makemaker-test-job
-    name: '{name}-{branch}-test{variant}'
+    id: perl-makemaker-check-job
+    name: '{name}-{branch}-check{variant}'
     project-type: matrix
-    description: '{title} Test'
+    description: '{title} Check'
     workspace: '{name}-{branch}{variant}'
     child-workspace: '.'
     block-downstream: true
diff --git a/jobs/perl-modulebuild.yaml b/jobs/perl-modulebuild.yaml
index b159ab3..65c1710 100644
--- a/jobs/perl-modulebuild.yaml
+++ b/jobs/perl-modulebuild.yaml
@@ -54,10 +54,10 @@
 
 
 - job-template:
-    id: perl-modulebuild-test-job
-    name: '{name}-{branch}-test{variant}'
+    id: perl-modulebuild-check-job
+    name: '{name}-{branch}-check{variant}'
     project-type: matrix
-    description: '{title} Test'
+    description: '{title} Check'
     workspace: '{name}-{branch}{variant}'
     child-workspace: '.'
     block-downstream: true
diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml
index 165470a..8023cfe 100644
--- a/projects/libvirt-perl.yaml
+++ b/projects/libvirt-perl.yaml
@@ -6,10 +6,10 @@
     jobs:
       - perl-makemaker-build-job:
           parent_jobs: 'libvirt-master-build'
-      - perl-makemaker-test-job:
+      - perl-makemaker-check-job:
           parent_jobs: 'libvirt-perl-master-build'
           local_env: |
             export TEST_ARGS="TEST_MAINTAINER=1"
       - perl-makemaker-rpm-job:
-          parent_jobs: 'libvirt-perl-master-test'
+          parent_jobs: 'libvirt-perl-master-check'
           machines: '{rpm_machines}'
diff --git a/projects/libvirt-tck.yaml b/projects/libvirt-tck.yaml
index 25b674a..065678d 100644
--- a/projects/libvirt-tck.yaml
+++ b/projects/libvirt-tck.yaml
@@ -13,10 +13,10 @@
     jobs:
       - perl-modulebuild-build-job:
           parent_jobs: 'libvirt-perl-master-build'
-      - perl-modulebuild-test-job:
+      - perl-modulebuild-check-job:
           parent_jobs: 'libvirt-tck-master-build'
       - perl-modulebuild-rpm-job:
-          parent_jobs: 'libvirt-tck-master-test'
+          parent_jobs: 'libvirt-tck-master-check'
           machines:
             - libvirt-fedora-27
             - libvirt-fedora-28
-- 
2.17.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too
Posted by Erik Skultety 6 years, 12 months ago
On Thu, May 10, 2018 at 05:35:45PM +0200, Andrea Bolognani wrote:
> Perl jobs use the -test suffix instead of -check, which is
> used everywhere else. Rename them in order to be consistent.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [jenkins-ci PATCH 3/3] jobs: Use *-check for Perl jobs too
Posted by Andrea Bolognani 6 years, 12 months ago
On Wed, 2018-05-16 at 17:42 +0200, Erik Skultety wrote:
> On Thu, May 10, 2018 at 05:35:45PM +0200, Andrea Bolognani wrote:
> > Perl jobs use the -test suffix instead of -check, which is
> > used everywhere else. Rename them in order to be consistent.
> > 
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> 
> Reviewed-by: Erik Skultety <eskultet@redhat.com>

Thanks, I've pushed this patch; the other patches in the series
are no longer relevant since we're in the process of switching
libvirt-perl to Module::Build and removing ExtUtils::MakeMaker
support, so I've skipped them to reduce churn.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list